Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46035

"Hardcoded Script Checker - Threshold": Don't count comment lines or empty lines

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: jenkinslint-plugin
    • Labels:
    • Environment:
      Jenkins 2.71 running using JDK1.8_141 on RH6 Linux, no container
      jenkinslint 0.10.1
    • Similar Issues:

      Description

      It seems the

        Hardcoded Script Checker - Threshold

      counts at least comment lines (and probably also empty lines or lines just containing whitespace)

      It would be nice, to not count these. We sometimes have comment blocks before one or two lines of script calling. This now forces us, to set a rather big threshold.

      And as an extra a help entry on the configuration page would be nice for this entry.

        Attachments

          Activity

          martinjost Martin Jost created issue -
          v2v Victor Martinez made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          v2v Victor Martinez made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          v2v Victor Martinez made changes -
          Resolution Fixed [ 1 ]
          Status In Review [ 10005 ] Resolved [ 5 ]
          v2v Victor Martinez made changes -
          Labels 0.11.0
          v2v Victor Martinez made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            Assignee:
            v2v Victor Martinez
            Reporter:
            martinjost Martin Jost
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: