Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46065

Provide extension point for contributing validation checks to Declarative

    XMLWordPrintable

    Details

    • Similar Issues:
    • Sprint:
      Declarative - 1.2

      Description

      Right now, all validation for Declarative is hardcoded in ModelValidatorImpl. This means that an extension of, say, DeclarativeAgent or DeclarativeStageConditional can't require any specific validation unless it's in pipeline-model-definition and we add it to ModelValidatorImpl. I'd suggest we add an extension point for contributing more validation checks.

        Attachments

          Issue Links

          links to

          Web Link PR #179

            Activity

            Ascending order - Click to sort in descending order
            abayer Andrew Bayer created issue -
            abayer Andrew Bayer made changes -
            Field Original Value New Value
            Sprint Declarative - 1.2 [ 366 ]
            abayer Andrew Bayer made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            abayer Andrew Bayer made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            Hide
            Permalink
            abayer Andrew Bayer added a comment -

            PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/179

            Show
            abayer Andrew Bayer added a comment - PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/179
            abayer Andrew Bayer made changes -
            Remote Link This issue links to "PR #179 (Web Link)" [ 17429 ]
            jglick Jesse Glick made changes -
            Labels api
            Hide
            Permalink
            abayer Andrew Bayer added a comment -

            This will be in Declarative 1.2.

            Show
            abayer Andrew Bayer added a comment - This will be in Declarative 1.2.
            abayer Andrew Bayer made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy
            pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java
            pipeline-model-definition/src/test/resources/errors/validatorContributor.groovy
            pipeline-model-extensions/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/validator/DeclarativeValidatorContributor.java
            http://jenkins-ci.org/commit/pipeline-model-definition-plugin/b496df9254bae6f4aea68c7cc9c70f6b3af90650
            Log:
            [FIXED JENKINS-46065] Add extension point for contributing validation

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java pipeline-model-definition/src/test/resources/errors/validatorContributor.groovy pipeline-model-extensions/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/validator/DeclarativeValidatorContributor.java http://jenkins-ci.org/commit/pipeline-model-definition-plugin/b496df9254bae6f4aea68c7cc9c70f6b3af90650 Log: [FIXED JENKINS-46065] Add extension point for contributing validation
            Hide
            Permalink
            bitwiseman Liam Newman added a comment -

            Bulk closing resolved issues.

            Show
            bitwiseman Liam Newman added a comment - Bulk closing resolved issues.
            bitwiseman Liam Newman made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              Assignee:
              abayer Andrew Bayer
              Reporter:
              abayer Andrew Bayer
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: