-
Bug
-
Resolution: Unresolved
-
Major
-
None
-
Pipeline: Stage View Plugin 2.8
The stage view was broken when we upgraded from 2.4 to 2.8. The stage view matrix with stages vs runs ended up far down, at the very bottom of the page, beneath the list of build history in the left column if it's wider than what fits on the screen.
I guess the problem was introduced with Pipeline: Stage View Plugin v 2.5:
2.5 (Feb 13, 2017)
- Fix a minor CSS layout issue with stage view interfering with test results trends graphs
This is a critical bug for this plugin considering that the main purpose of the plugin is to render this view, and it fails in doing so in a good way.
[JENKINS-46096] Pipeline stage view rendered at bottom of page, below build history
| Summary | Original: Pipeline stage view rendered | New: Pipeline stage view rendered at bottom of page, below build history |
| Description |
Original:
The stage view was broken when we upgraded from 2.4 to 2.8. The stage view matrix with stages vs runs ended up far down, at the very bottom of the page, beneath the list of runs in the left column if it's wider than what fits on the screen. I guess the problem was introduced with Pipeline: Stage View Plugin v 2.5: {quote} h4. 2.5 (Feb 13, 2017) * Fix a minor CSS layout issue with stage view interfering with test results trends graphs{quote} This is a critical bug for this plugin considering that the main purpose of the plugin is to render this view, and it fails in doing so in a good way. |
New:
The stage view was broken when we upgraded from 2.4 to 2.8. The stage view matrix with stages vs runs ended up far down, at the very bottom of the page, beneath the list of build history in the left column if it's wider than what fits on the screen. I guess the problem was introduced with Pipeline: Stage View Plugin v 2.5: {quote} h4. 2.5 (Feb 13, 2017) * Fix a minor CSS layout issue with stage view interfering with test results trends graphs{quote} This is a critical bug for this plugin considering that the main purpose of the plugin is to render this view, and it fails in doing so in a good way. |
| Attachment | New: Screen Shot 2017-08-09 at 16.30.01.png [ 39219 ] |
| Attachment | Original: Screen Shot 2017-08-09 at 16.30.01.png [ 39219 ] |
| Attachment | New: Screen Shot OK v2_4.png [ 39220 ] |
Merge of: https://github.com/jenkinsci/pipeline-stage-view-plugin/commit/8cc39feb4b6c60d952d0bc331083f7a2269a3be0
from PR: https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/35
released in 2.5 was a regressions.
The author says "with no side effects from my basic checks.". Well, basic checks was not enough.
I don't think it's a good idea to just change the CSS to fix a small specific problem and introduce a larger problem.
Please revert this!
From https://www.w3schools.com/css/css_float.asp:
When clearing floats, you should match the clear to the float. If an element is floated to the left, then you should clear to the left. Your floated element will continue to float, but the cleared element will appear below it on the web page.
The test results div has float: right, so I guess the stage view should have clear: right.
This assumes test results plugin is doing it right. That can maybe be argued. But they where here first and it's a very widely used plugin.
Same issue here, and it is worse because to the right we have graphs for Checkstyle, Duplicate Code, Open Tasks and Test Result trends.
As a result, the pipeline is not visible on the screen at all without scrolling down.
The screenshot shows how it was in 2.4. I didn't capture the problem in 2.8 before I downgraded. But this screenshot illustrates the width of my pipeline