• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None
    • Platform: All, OS: All

      Although I have the Include culprits option checked for Unstable builds, the
      emails still only go to the global + committer, but not the culprits.

          [JENKINS-4617] "Include culprits" option not working

          mcrooney created issue -

          mcrooney added a comment -

          To elaborate, I have an Unstable trigger sent to email Recipients, Committers,
          and Culprits. Person A is on the global list, and person B commits and breaks a
          test. The build is now unstable and an email goes to A+B. Now person C commits,
          and the test still fails because no one has fixed it yet. An email goes to A+C,
          instead of A+B+C.

          So it seems that include culprits isn't working, which is very useful to remind
          the person who broke the test that it is affecting other committers and they
          should fix it in a timely manner.

          mcrooney added a comment - To elaborate, I have an Unstable trigger sent to email Recipients, Committers, and Culprits. Person A is on the global list, and person B commits and breaks a test. The build is now unstable and an email goes to A+B. Now person C commits, and the test still fails because no one has fixed it yet. An email goes to A+C, instead of A+B+C. So it seems that include culprits isn't working, which is very useful to remind the person who broke the test that it is affecting other committers and they should fix it in a timely manner.

          Alan Harder added a comment -

          Can you update the latest email-ext (released today) and see if this is still a problem? Also turn on Hudson's built-in email notification with "Send separate e-mails to individuals who broke the build" checked, and see if it has the same problem (this also sends to build.getCulprits()).

          Alan Harder added a comment - Can you update the latest email-ext (released today) and see if this is still a problem? Also turn on Hudson's built-in email notification with "Send separate e-mails to individuals who broke the build" checked, and see if it has the same problem (this also sends to build.getCulprits()).

          Alan Harder added a comment -

          Reminder to retest on current releases, thanks..

          Alan Harder added a comment - Reminder to retest on current releases, thanks..

          mcrooney added a comment -

          Still an issue with Hudson 1.341 and email-ext 2.4, indeed.

          mcrooney added a comment - Still an issue with Hudson 1.341 and email-ext 2.4, indeed.

          Alan Harder added a comment -

          what SCM are you using? I wasn't able to reproduce this problem with a subversion project. In a project where email-ext isn't emailing the right people, access /job/JOBNAME/BUILDNUMBER/api/xml and look at the culprit info listed here.. is this list accurate? (email-ext should be using that list)

          Alan Harder added a comment - what SCM are you using? I wasn't able to reproduce this problem with a subversion project. In a project where email-ext isn't emailing the right people, access /job/JOBNAME/BUILDNUMBER/api/xml and look at the culprit info listed here.. is this list accurate? (email-ext should be using that list)

          mcrooney added a comment -

          We are using SVN. Were you trying with sequential Unstable builds with different committers, not Failed builds? If I look at the api/xml it is indeed wrong there. The first unstable build it has the two committers as culprits (correct), but the next unstable build doesn't have those people but instead the two people that made commits in that revision set. It doesn't seem to be carrying over culprits.

          mcrooney added a comment - We are using SVN. Were you trying with sequential Unstable builds with different committers, not Failed builds? If I look at the api/xml it is indeed wrong there. The first unstable build it has the two committers as culprits (correct), but the next unstable build doesn't have those people but instead the two people that made commits in that revision set. It doesn't seem to be carrying over culprits.

          Alan Harder added a comment -

          What is your Hudson version and subversion plugin version?

          Moving out of email-ext component, as core determines the culprit list and email-ext just uses that info from the build. If the remote API also has incorrect data, the problem is not in email-ext.

          I did: failed build with personA, failed build with personB, unstable build
          I'll try now with only unstables..

          Alan Harder added a comment - What is your Hudson version and subversion plugin version? Moving out of email-ext component, as core determines the culprit list and email-ext just uses that info from the build. If the remote API also has incorrect data, the problem is not in email-ext. I did: failed build with personA, failed build with personB, unstable build I'll try now with only unstables..
          Alan Harder made changes -
          Component/s New: core [ 15593 ]
          Component/s New: subversion [ 15485 ]
          Component/s Original: email-ext [ 15538 ]

          mcrooney added a comment -

          Hudson 1.341 with Subversion 1.8. I'll upgrade to 1.9 and test but I don't see anything relevant in the changes.

          mcrooney added a comment - Hudson 1.341 with Subversion 1.8. I'll upgrade to 1.9 and test but I don't see anything relevant in the changes.

            markltbaker markltbaker
            mcrooney mcrooney
            Votes:
            6 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: