Details
-
New Feature
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Fixed
-
None
Description
Currently the git plugin doesn't seem to support tags in multi-branch builds. It looks like this is because the ref prefixes are hard-coded. See: https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java#L417
This is similar to JENKINS-34395 but for the git plugin. I'm creating a separate issue because the causes and the fixes appear to be unrelated.
Attachments
Issue Links
- is duplicated by
-
-
- Closed
-
-
JENKINS-37050 Pipeline Job Cannot Checkout Git Tag
-
- Closed
-
- is related to
-
-
- Closed
-
-
-
- Closed
-
- links to
Activity
Kevin Browder
created issue -
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Mark Waite [ markewaite ] |
Kevin Browder
made changes -
| Link |
This issue duplicates |
Kevin Browder
made changes -
| Resolution | Duplicate [ 3 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
Prefer this one to JENKINS-46208 as this has a better description
| Resolution | Duplicate [ 3 ] | |
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| Link |
This issue is duplicated by |
| Link |
This issue duplicates |
Nothing to do with ref-specs, the actual impl is more complex.
My initial stab at an implementation is https://github.com/jenkinsci/git-plugin/pull/528
Will need testing before we can merge... will likely need changes in branch-api to prevent build storms unless I was good at anticipating the needs of tags
| Remote Link | This issue links to "PR#528 (Web Link)" [ 17611 ] |
https://github.com/jenkinsci/branch-api-plugin/commit/cf848af4addf33f0aae9c86149fc0cfd1fee5c82#diff-b347159a8a8075d4e700065f8668b804R1811 Looks like a was good at anticipating the needs of tags... ok just requires testing!
| Status | Reopened [ 4 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | In Review [ 10005 ] |
| Assignee | Stephen Connolly [ stephenconnolly ] |
| Link |
This issue is related to |
| Link |
This issue is duplicated by |
Kevin Browder
added a comment - Very cool, simpler than what I was thinking too, thanks Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
src/main/java/jenkins/plugins/git/GitSCMSource.java
src/main/java/jenkins/plugins/git/GitTagSCMHead.java
src/main/java/jenkins/plugins/git/GitTagSCMRevision.java
src/main/java/jenkins/plugins/git/traits/BranchDiscoveryTrait.java
src/main/java/jenkins/plugins/git/traits/TagDiscoveryTrait.java
src/main/resources/jenkins/plugins/git/traits/Messages.properties
src/main/resources/jenkins/plugins/git/traits/TagDiscoveryTrait/config.jelly
src/main/resources/jenkins/plugins/git/traits/TagDiscoveryTrait/help.html
src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java
http://jenkins-ci.org/commit/git-plugin/837ae6424c7636b6f7aaabbe8337ae3a2c053d0a
Log:
JENKINS-46207 Initial implementation, if lucky this is complete
- I suspect there are additional changes required before can merge for git
- I suspect there are additional changes required to branch-api before safe to merge for users
Code changed in jenkins
User: Mark Waite
Path:
src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
src/main/java/jenkins/plugins/git/GitSCMSource.java
src/main/java/jenkins/plugins/git/GitTagSCMHead.java
src/main/java/jenkins/plugins/git/GitTagSCMRevision.java
src/main/java/jenkins/plugins/git/traits/BranchDiscoveryTrait.java
src/main/java/jenkins/plugins/git/traits/TagDiscoveryTrait.java
src/main/resources/jenkins/plugins/git/traits/Messages.properties
src/main/resources/jenkins/plugins/git/traits/TagDiscoveryTrait/config.jelly
src/main/resources/jenkins/plugins/git/traits/TagDiscoveryTrait/help.html
src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java
http://jenkins-ci.org/commit/git-plugin/fe5a3f42a1f7e6ceb978ee2e603a1068dfeba970
Log:
Merge pull request #528 from stephenc/jenkins-46207
JENKINS-46207 Enable tag discovery
Compare: https://github.com/jenkinsci/git-plugin/compare/35745f2e3f81...fe5a3f42a1f7
Chris Stylianou
made changes -
| Link |
This issue is related to |
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10005 ] | Resolved [ 5 ] |
Konstantin Ryakhovskiy
added a comment - the solution does not work for me, I commented the problem to the PR: https://github.com/jenkinsci/git-plugin/pull/528
Konstantin Ryakhovskiy
added a comment - the solution does not work for me, I commented the problem to the PR: https://github.com/jenkinsci/git-plugin/pull/528 with git-plugin 3.6.2 tags are successfully discovered, however they are not automatically built.
Output of the scan multibranch pipeline log:
Checking tag v0.10.0 'Jenkinsfile' found Met criteria No automatic builds for v0.10.0
the reason is that Multibranch Pipeline uses heads only to schedule automatic builds:
https://github.com/jenkinsci/branch-api-plugin/blob/master/src/main/java/jenkins/branch/MultiBranchProject.java#L2151
is it intended behaviour?
Konstantin Ryakhovskiy
added a comment - - edited with git-plugin 3.6.2 tags are successfully discovered, however they are not automatically built.
Output of the scan multibranch pipeline log:
Checking tag v0.10.0
'Jenkinsfile' found
Met criteria
No automatic builds for v0.10.0
the reason is that Multibranch Pipeline uses heads only to schedule automatic builds:
https://github.com/jenkinsci/branch-api-plugin/blob/master/src/main/java/jenkins/branch/MultiBranchProject.java#L2151
is it intended behaviour? It is intended behaviour... look a few lines further down: https://github.com/jenkinsci/branch-api-plugin/blob/master/src/main/java/jenkins/branch/MultiBranchProject.java#L2165
- Some people may configure the Jenkinsfile to deploy to production for tags.
- We cannot control the order in which tags will be built if multiple tags are discovered in the same indexing
- As a result, building tags automatically would be risky.
There is an extension point (which is hidden until you have some implementations) called BranchBuildStrategy and that can determine if you want to build tags automatically, but this would be opt-in behaviour.
By default, tags will not be built. You must configure automatic building of tags... see https://github.com/jenkinsci/github-branch-source-plugin/pull/158#issuecomment-332773194 and https://github.com/AngryBytes/jenkins-build-everything-strategy-plugin for starting points if you want to build tags automatically
Bill Hamilton
added a comment - stephenconnolly markwaite If I kick off a tag build, do you know how in the Jenkinsfile I can detect that it is a tag build?
Bill Hamilton
added a comment - stephenconnolly markwaite If I kick off a tag build, do you know how in the Jenkinsfile I can detect that it is a tag build? hamiltb if you need to determine the list of all tags which point at a specific SHA1, you can use the shell command:
git tag --points-at HEAD
The env.TAG_NAME which stephenconnolly references should be more reliable than the points-at shell trick, since it is set inside the plugins, rather than being guessed from the condition of the repository.
env.TAG_NAME doesnt exist in a tag build. I printed out all envars:
@NonCPS
def printParams() {
env.getEnvironment().each { name, value -> println "$name : $value" }
}
printParams()
and TAG_NAME isnt there.
Bill Hamilton
added a comment - - edited stephenconnolly markewaite
env.TAG_NAME doesnt exist in a tag build. I printed out all envars:
@NonCPS
def printParams() {
env.getEnvironment().each { name, value -> println "$name : $value" }
}
printParams()
and TAG_NAME isnt there. Bill Hamilton
added a comment - Yep, works good now, thanks! | Status | Resolved [ 5 ] | Closed [ 6 ] |
Oh that's weird JIRA said it lost this when i created it, apparently it didn't, marking as duplicate. My Applologies