Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46324

Support for ConsoleNote

    XMLWordPrintable

Details

    Description

      Split from discussion in JENKINS-41200. Briefly, the failure to support standard ConsoleNote in Blue Ocean causes various problems; for example, if you use the ANSI Color plugin to colorize build output in the classic UI, this explodes in Blue Ocean. In general, lots of plugins use console notes for all sorts of reasons, and none of them work in B.O. Would be desirable to at least support basic inline HTML tags which should not in principle mess around with the different page layout in B.O. mode.

      Attachments

        Issue Links

          Activity

            jglick Jesse Glick added a comment - https://github.com/jenkinsci/ansicolor-plugin/pull/132#issuecomment-440937753 for this case.
            michaelneale Michael Neale added a comment - - edited

            ssbarnea no one has been able to work out a solution that works for both (after spending a week on it), so it may not be possible at this time. Or bigger brains than mine are required... (highly likely)

             

            Background doc on how complex this all is based on early jenkins design decisions: https://docs.google.com/document/d/1wIBYfU734c4CU45l_EZMwKAqoVeQL3SsbzQhESoYWI4/edit#heading=h.4kdft5qo8ksb

            Perhaps if ansicolor would not strip the codes - it could work in both, but the classic view would need to know to strip them somewhere else (just thinking aloud) - if you were only interested in ANSI working in both? (or are there other notes?)... perhaps...  

            sigh 

            **Maybe some bigger brains than mine can find a solution? But jenkins logging was never designer other than for the original view of the log (server side rendering with fixed markup, log mutation via plugins that can't be uninstalled or the log data looks broken). If ANSI color is most of it though... perhaps there is hope? It's a tought place to be in.. more brains needed. 

            michaelneale Michael Neale added a comment - - edited ssbarnea no one has been able to work out a solution that works for both (after spending a week on it), so it may not be possible at this time. Or bigger brains than mine are required... (highly likely)   Background doc on how complex this all is based on early jenkins design decisions: https://docs.google.com/document/d/1wIBYfU734c4CU45l_EZMwKAqoVeQL3SsbzQhESoYWI4/edit#heading=h.4kdft5qo8ksb Perhaps if ansicolor would not strip the codes - it could work in both, but the classic view would need to know to strip them somewhere else (just thinking aloud) - if you were only interested in ANSI working in both? (or are there other notes?)... perhaps...   sigh   **Maybe some bigger brains than mine can find a solution? But jenkins logging was never designer other than for the original view of the log (server side rendering with fixed markup, log mutation via plugins that can't be uninstalled or the log data looks broken). If ANSI color is most of it though... perhaps there is hope? It's a tought place to be in.. more brains needed. 
            ssbarnea Sorin Sbarnea added a comment -

            Any updates on the ansicolor issue? This become the No1 reason that prevents adoption of the blueocean UI: nobody wants to lose ansicolor. I am in a position when nobody wants to use blueocean because lack of coloring and where I cannot disable ansibecolor on old ui.

            We really need a solution that works for both user interfaces.

            ssbarnea Sorin Sbarnea added a comment - Any updates on the ansicolor issue? This become the No1 reason that prevents adoption of the blueocean UI: nobody wants to lose ansicolor. I am in a position when nobody wants to use blueocean because lack of coloring and where I cannot disable ansibecolor on old ui. We really need a solution that works for both user interfaces.
            jamesdumay James Dumay added a comment -

            This is a no for the same reasons outlined in JENKINS-43107.

            Ill follow up on the ansi color issue.

            jamesdumay James Dumay added a comment - This is a no for the same reasons outlined in JENKINS-43107 . Ill follow up on the ansi color issue.
            michaelneale Michael Neale added a comment -

            The ansi color wrapper removes the actual ansi color codes, so will be a PR to fix that specifically. 

            michaelneale Michael Neale added a comment - The ansi color wrapper removes the actual ansi color codes, so will be a PR to fix that specifically. 
            jglick Jesse Glick added a comment -

            As described in the original issue, if you try to use the ANSI Color wrapper, the classic build log looks nice, but Blue Ocean shows no colors; if you do not use it, then Blue Ocean is colorized, but the classic build log is full of unreadable junk (unprocessed escape sequences).

            Again, this is just one example of the broader issue of B.O. not supporting the standard Jenkins console API.

            jglick Jesse Glick added a comment - As described in the original issue, if you try to use the ANSI Color wrapper, the classic build log looks nice, but Blue Ocean shows no colors; if you do not use it, then Blue Ocean is colorized, but the classic build log is full of unreadable junk (unprocessed escape sequences). Again, this is just one example of the broader issue of B.O. not supporting the standard Jenkins console API.
            jamesdumay James Dumay added a comment - - edited

            jglick in what way does it blow up?

            Unfortunately injecting any elements that way is going to not play with react nicely.

            jamesdumay James Dumay added a comment - - edited jglick in what way does it blow up? Unfortunately injecting any elements that way is going to not play with react nicely.

            People

              Unassigned Unassigned
              jglick Jesse Glick
              Votes:
              8 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: