Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46366

REGRESSION: Github branch source does not consistently set up webhook

    XMLWordPrintable

    Details

    • Similar Issues:
    • Sprint:
      Pipeline - December

      Description

      Summary: 

      Creating a pipeline via Github, either org folder or a single MBP, does not correctly setup webhooks. 

      To reproduce: 

      • Create a github token with correct scope allowing for admin of webhooks
      • Create a MBP with the github project type, using this credential
      • Note that there is no webhook created on the github project. 
      • You will see a message in the log like: 
        INFO: GitHub webhooks activated for job CodeValet with [] (events: [REPOSITORY])

       

      This also happens if you set it up via github org folders. R. Tyler Croy swears on his grave that it used to work (he used it on jenkins.io) so this is possibly a bad regression. 

       

      ---------

       

      See the attached screenshot, I haven't yet been able to figure out why sometimes, but mostly not, a webhook is created at an Org level.

      *Most* of the time this doesn't work, but sometimes it does. MUCH CONFUSION.

      Failed logs:

      Aug 23, 2017 5:45:23 AM org.jenkinsci.plugins.github.webhook.WebhookManager$1 run              
      INFO: GitHub webhooks activated for job CodeValet with [] (events: [REPOSITORY])   
      

      Successful logs:

      INFO: GitHub webhooks activated for job CodeValet with [] (events: [REPOSITORY])                          
      Aug 23, 2017 5:41:04 AM org.jenkinsci.plugins.github_branch_source.GitHubOrgWebHook register              
      INFO: A webhook was registered for the organization https://github.com/CodeValet                                                                                                                  
      Aug 23, 2017 5:41:05 AM org.jenkinsci.plugins.github.webhook.subscriber.PingGHEventSubscriber onEvent                                                                                             
      INFO: PING webhook received from org <https://api.github.com/orgs/CodeValet>!   
      

      Related-ish to JENKINS-46365

        Attachments

          Issue Links

            Activity

            rtyler R. Tyler Croy created issue -
            michaelneale Michael Neale made changes -
            Field Original Value New Value
            Summary GitHub Org Folder does not consistently set up an org-level webhook Github branch source does not consistently set up webhook
            michaelneale Michael Neale made changes -
            Description See the attached screenshot, I haven't yet been able to figure out why sometimes, but mostly not, a webhook is created at an Org level.

            **Most** of the time this doesn't work, but sometimes it does. MUCH CONFUSION.

            Failed logs:
            {code}
            Aug 23, 2017 5:45:23 AM org.jenkinsci.plugins.github.webhook.WebhookManager$1 run
            INFO: GitHub webhooks activated for job CodeValet with [] (events: [REPOSITORY])
            {code}

            Successful logs:
            {code}
            INFO: GitHub webhooks activated for job CodeValet with [] (events: [REPOSITORY])
            Aug 23, 2017 5:41:04 AM org.jenkinsci.plugins.github_branch_source.GitHubOrgWebHook register
            INFO: A webhook was registered for the organization https://github.com/CodeValet
            Aug 23, 2017 5:41:05 AM org.jenkinsci.plugins.github.webhook.subscriber.PingGHEventSubscriber onEvent
            INFO: PING webhook received from org <https://api.github.com/orgs/CodeValet&gt;!
            {code}

            Related-ish to JENKINS-46365

            !https://github.com/rtyler/codevalet/raw/master/assets/monkey-128.png!
            Summary: 

            Creating a pipeline via Github, either org folder or a single MBP, does not correctly setup webhooks. 

            To reproduce: 
             * Create a github token with correct scope allowing for admin of webhooks
             * Create a MBP with the github project type, using this credential
             * Note that there is no webhook created on the github project. 
             * You will see a message in the log like: 
            {code:java}
            INFO: GitHub webhooks activated for job CodeValet with [] (events: [REPOSITORY]){code}

             

            This also happens if you set it up via github org folders. [~rtyler] swears on his grave that it used to work (he used it on jenkins.io) so this is possibly a bad regression. 

             

            ---------

             

            See the attached screenshot, I haven't yet been able to figure out why sometimes, but mostly not, a webhook is created at an Org level.

            **Most** of the time this doesn't work, but sometimes it does. MUCH CONFUSION.

            Failed logs:
            {code:java}
            Aug 23, 2017 5:45:23 AM org.jenkinsci.plugins.github.webhook.WebhookManager$1 run
            INFO: GitHub webhooks activated for job CodeValet with [] (events: [REPOSITORY])
            {code}
            Successful logs:
            {code:java}
            INFO: GitHub webhooks activated for job CodeValet with [] (events: [REPOSITORY])
            Aug 23, 2017 5:41:04 AM org.jenkinsci.plugins.github_branch_source.GitHubOrgWebHook register
            INFO: A webhook was registered for the organization https://github.com/CodeValet
            Aug 23, 2017 5:41:05 AM org.jenkinsci.plugins.github.webhook.subscriber.PingGHEventSubscriber onEvent
            INFO: PING webhook received from org <https://api.github.com/orgs/CodeValet&gt;!
            {code}
            Related-ish to JENKINS-46365

            !https://github.com/rtyler/codevalet/raw/master/assets/monkey-128.png!
            michaelneale Michael Neale made changes -
            Priority Minor [ 4 ] Critical [ 2 ]
            michaelneale Michael Neale made changes -
            Summary Github branch source does not consistently set up webhook REGRESSION: Github branch source does not consistently set up webhook
            michaelneale Michael Neale made changes -
            Link This issue blocks JENKINS-46365 [ JENKINS-46365 ]
            stephenconnolly Stephen Connolly made changes -
            Link This issue duplicates JENKINS-33228 [ JENKINS-33228 ]
            stephenconnolly Stephen Connolly made changes -
            Resolution Duplicate [ 3 ]
            Status Open [ 1 ] Resolved [ 5 ]
            michaelneale Michael Neale made changes -
            Resolution Duplicate [ 3 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            michaelneale Michael Neale made changes -
            Resolution Fixed [ 1 ]
            Status Reopened [ 4 ] Resolved [ 5 ]
            michaelneale Michael Neale made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            michaelneale Michael Neale made changes -
            Component/s blueocean-plugin [ 21481 ]
            michaelneale Michael Neale made changes -
            Sprint Blue Ocean 1.3 - beta 1 [ 386 ]
            michaelneale Michael Neale made changes -
            Rank Ranked higher
            michaelneale Michael Neale made changes -
            Sprint Blue Ocean 1.3 - beta 1 [ 386 ]
            michaelneale Michael Neale made changes -
            Sprint Blue Ocean 1.3 - candidates [ 326 ]
            michaelneale Michael Neale made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.4 - candidates [ 326 ] Blue Ocean 1.4 - beta 2 [ 416 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.4 - beta 3 [ 416 ] Blue Ocean 1.4 - beta 4 [ 441 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.4 - beta 4 [ 441 ] Pipeline - December [ 446 ]
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            michaelneale Michael Neale made changes -
            Assignee rsandell [ rsandell ]
            michaelneale Michael Neale made changes -
            Priority Critical [ 2 ] Major [ 3 ]
            jamesdumay James Dumay made changes -
            Component/s blueocean-plugin [ 21481 ]
            michaelneale Michael Neale made changes -
            Link This issue duplicates JENKINS-48035 [ JENKINS-48035 ]
            michaelneale Michael Neale made changes -
            Resolution Fixed [ 1 ]
            Status Reopened [ 4 ] Resolved [ 5 ]

              People

              Assignee:
              rsandell rsandell
              Reporter:
              rtyler R. Tyler Croy
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: