Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46482

Parameter Mapping is not working due to SECURITY-170

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • jira-trigger-plugin
    • None
    • Jenkins 1.651.2+
      Jenkins 2.3+
      jira-trigger-plugin 0.4.2

      See Jenkins security update:

      One of the fixes may well break some of your use cases in Jenkins, at least until plugins have been adapted: SECURITY-170. This change removes parameters that are not defined on a job from the build environment.

       

          [JENKINS-46482] Parameter Mapping is not working due to SECURITY-170

          Wisen Tanasa created issue -
          Wisen Tanasa made changes -
          Environment Original: Jenkins 1.651.2+
          Jenkins 2.3+           		New: Jenkins 1.651.2+
          Jenkins 2.3+
          jira-trigger-plugin 0.4.2

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Wisen Tanasa
          Path:
          CHANGELOG.md
          build.gradle
          http://jenkins-ci.org/commit/jira-trigger-plugin/b57199581110ae8b48a73079ae41ebea51dc82e4
          Log:
          JENKINS-46482 Update Jenkins core version from 1.642 to 1.651.2

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wisen Tanasa Path: CHANGELOG.md build.gradle http://jenkins-ci.org/commit/jira-trigger-plugin/b57199581110ae8b48a73079ae41ebea51dc82e4 Log: JENKINS-46482 Update Jenkins core version from 1.642 to 1.651.2

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Wisen Tanasa
          Path:
          src/integrationTest/groovy/com/ceilfors/jenkins/plugins/jiratrigger/JiraTriggerAcceptanceTest.groovy
          src/integrationTest/groovy/com/ceilfors/jenkins/plugins/jiratrigger/integration/JenkinsBlockingQueue.groovy
          src/integrationTest/groovy/com/ceilfors/jenkins/plugins/jiratrigger/integration/JenkinsRunner.groovy
          src/jiraIntegrationTest/groovy/com/ceilfors/jenkins/plugins/jiratrigger/integration/RealJiraRunner.groovy
          src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/JiraTrigger.groovy
          src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/ParameterMappingAction.groovy
          http://jenkins-ci.org/commit/jira-trigger-plugin/267e946e7108072417cf59d94532acbd2b34adef
          Log:
          JENKINS-46482 Migrate implementation from Parameter concept to Environment variables.

          Using Environment because theoretically what we are trying to do here is not parameters.
          Update acceptance test to assert environment instead of parameter.
          Update JenkinsBlockingQueue to return scheduled jobs instead of queue item. This is necessary as the 'environment' variable is only available in a build object.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wisen Tanasa Path: src/integrationTest/groovy/com/ceilfors/jenkins/plugins/jiratrigger/JiraTriggerAcceptanceTest.groovy src/integrationTest/groovy/com/ceilfors/jenkins/plugins/jiratrigger/integration/JenkinsBlockingQueue.groovy src/integrationTest/groovy/com/ceilfors/jenkins/plugins/jiratrigger/integration/JenkinsRunner.groovy src/jiraIntegrationTest/groovy/com/ceilfors/jenkins/plugins/jiratrigger/integration/RealJiraRunner.groovy src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/JiraTrigger.groovy src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/ParameterMappingAction.groovy http://jenkins-ci.org/commit/jira-trigger-plugin/267e946e7108072417cf59d94532acbd2b34adef Log: JENKINS-46482 Migrate implementation from Parameter concept to Environment variables. Using Environment because theoretically what we are trying to do here is not parameters. Update acceptance test to assert environment instead of parameter. Update JenkinsBlockingQueue to return scheduled jobs instead of queue item. This is necessary as the 'environment' variable is only available in a build object.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Wisen Tanasa
          Path:
          src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/ParameterMappingAction.groovy
          src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/parameter/CustomFieldParameterResolver.groovy
          src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/parameter/IssueAttributePathParameterResolver.groovy
          src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/parameter/ParameterResolver.groovy
          src/test/groovy/com/ceilfors/jenkins/plugins/jiratrigger/parameter/CustomFieldParameterResolverTest.groovy
          src/test/groovy/com/ceilfors/jenkins/plugins/jiratrigger/parameter/IssueAttributePathParameterResolverTest.groovy
          http://jenkins-ci.org/commit/jira-trigger-plugin/25354815391995a79d4f939f7d68760ee1551351
          Log:
          JENKINS-46482 Return String instead of StringParameterValue.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wisen Tanasa Path: src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/ParameterMappingAction.groovy src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/parameter/CustomFieldParameterResolver.groovy src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/parameter/IssueAttributePathParameterResolver.groovy src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/parameter/ParameterResolver.groovy src/test/groovy/com/ceilfors/jenkins/plugins/jiratrigger/parameter/CustomFieldParameterResolverTest.groovy src/test/groovy/com/ceilfors/jenkins/plugins/jiratrigger/parameter/IssueAttributePathParameterResolverTest.groovy http://jenkins-ci.org/commit/jira-trigger-plugin/25354815391995a79d4f939f7d68760ee1551351 Log: JENKINS-46482 Return String instead of StringParameterValue.

          Wisen Tanasa added a comment -

          Released under 0.5.0.

          Wisen Tanasa added a comment - Released under 0.5.0.
          Wisen Tanasa made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Michael Porter added a comment - - edited

          The latest release removed all of my parameter mappings.

           

          Jenkins version Jenkins ver. 2.60.3

          pipeline job

          String parameter

          Name -> LABELS

          Build when issue is updated:

          (summary ~ 'WPSITE UPDATES') AND resolution = Unresolved

          Parameter mapping

          Jenkins parameter -> LABELS

          Issue attribute path -> labels

           

          In the pipeline the values are empty.

           

          When I rolled back to 0.4.2 from 0.5.0 the job started working again.

           

          Michael Porter added a comment - - edited The latest release removed all of my parameter mappings.   Jenkins version  Jenkins ver. 2.60.3 pipeline job String parameter Name -> LABELS Build when issue is updated: (summary ~ 'WPSITE UPDATES') AND resolution = Unresolved Parameter mapping Jenkins parameter -> LABELS Issue attribute path -> labels   In the pipeline the values are empty.   When I rolled back to 0.4.2 from 0.5.0 the job started working again.  
          Wisen Tanasa made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]

          Wisen Tanasa added a comment -

          michaelpporter Thanks for letting me know, I have reopened the ticket.

          Wisen Tanasa added a comment - michaelpporter Thanks for letting me know, I have reopened the ticket.

            ceilfors Wisen Tanasa
            ceilfors Wisen Tanasa
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: