Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46571

Update URL scheme to remove URL encoding issues

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Major Major
    • blueocean-plugin
    • None
    • Blue Ocean 1.6 - beta 2, Blue Ocean - 1.6 - beta 4

      Users frequently run into encoding problems that require configuration changes to HTTP reverse proxy's. A good example of this is JENKINS-46339.

      Requirements

      • Existing URLs must continue to work
      • URLs should be human readable
      • Blue Ocean Display URL plugin is updated to issue URLs in the new scheme.

      Notes

      • If at all possible, can we make branch names like "topic/feature" part of the url. e.g. /blue/pipelines/cool-pipeline/branch/topic/feature"

          [JENKINS-46571] Update URL scheme to remove URL encoding issues

          James Dumay created issue -
          James Dumay made changes -
          Epic Link New: JENKINS-35759 [ 171771 ]

          James Dumay added a comment -

          michaelneale Ill let you choose an appropriate time for this one. Added to 1.3 candidates.

          James Dumay added a comment - michaelneale Ill let you choose an appropriate time for this one. Added to 1.3 candidates.

          Michael Neale added a comment -

          kzantow cliffmeyers I am soliciting feelpinions here - although not sure if stapler will screw us again - is what could we do better? the % stuff in URLs trips up 80% of people with proxies

          Michael Neale added a comment - kzantow cliffmeyers I am soliciting feelpinions here - although not sure if stapler will screw us again - is what could we do better? the % stuff in URLs trips up 80% of people with proxies

          Cliff Meyers added a comment -

          Some thoughts in no particular order:

          1. Is the thought that all the old URL's would be caught server-side and redirected to the new nicer URL's?
          2. I seem to recall React Router not liking path variables with slashes in them. I could be I was defining the routes wrong, as that was very early days. Workarounds for this could include:
            1. Upgrading to latest React Router 4
            2. Scrapping React Router, as a lot of people seem to be happily using React without it
            3. Although, any of these changes might put us in a tough spot for backwards compat for other folks building on top of Blue Ocean
          3. Given the above, perhaps we should be looking at either building our own routing system or at least putting an abstraction layer in front of it

          Seems a discussion around all this is worthwhile.

          Cliff Meyers added a comment - Some thoughts in no particular order: Is the thought that all the old URL's would be caught server-side and redirected to the new nicer URL's? I seem to recall React Router not liking path variables with slashes in them. I could be I was defining the routes wrong, as that was very early days. Workarounds for this could include: Upgrading to latest React Router 4 Scrapping React Router, as a lot of people seem to be happily using React without it Although, any of these changes might put us in a tough spot for backwards compat for other folks building on top of Blue Ocean Given the above, perhaps we should be looking at either building our own routing system or at least putting an abstraction layer in front of it Seems a discussion around all this is worthwhile.

          Michael Neale added a comment -

          cliffmeyers well the / in paths create ambiguity with folders and other things, when they are in the scm branch name (if we only had to support git, could probabl bake in assumptions). 

           

          The main thing is to avoid %2F type of thing in path, as proxies like to auto translate that. If there is some other dumber encoding scheme, it would cause less grief. I think using things like "feature/blah" is not likely to be doable in any reasonable timeframe. 

           

          feature__blah could be though (lots of escaping rules need to be tested). 

          Michael Neale added a comment - cliffmeyers well the / in paths create ambiguity with folders and other things, when they are in the scm branch name (if we only had to support git, could probabl bake in assumptions).    The main thing is to avoid %2F type of thing in path, as proxies like to auto translate that. If there is some other dumber encoding scheme, it would cause less grief. I think using things like "feature/blah" is not likely to be doable in any reasonable timeframe.    feature__blah could be though (lots of escaping rules need to be tested). 
          James Dumay made changes -
          Sprint Original: Blue Ocean 1.4 - candidates [ 326 ] New: Blue Ocean 1.5 - candidates [ 311 ]
          James Dumay made changes -
          Rank New: Ranked higher
          James Dumay made changes -
          Sprint Original: Blue Ocean 1.5 - candidates [ 311 ]
          James Dumay made changes -
          Rank New: Ranked higher

            imeredith Ivan Meredith
            jamesdumay James Dumay
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated: