[JENKINS-46738] Self-deadlock in ExecutorStepExecution$PlaceholderTask$PlaceholderExecutable$1.interrupt - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: core, workflow-durable-task-step-plugin
Labels:
- deadlock

Similar Issues:

Show

Description

What is the business impact?

Jenkins stop working due the deadlock between support-core plugin and core/org.jenkinsci.plugins.workflow.support.steps.ExecutorStepExecution$PlaceholderTask$PlaceholderExecutable$1.interrupt(ExecutorStepExecution.java:570)

What is the incorrect behaviour?

The deadlock should not happen

What is the expected behaviour?

You should be able to automatically create a bundle and stop a build execution

Step by step to reproduce

N/A

Workaround

Restart the instance, disable support-core plugin or avoid to stop builds. Issue does not seems to be very frequent.

Regression

I don't think this is a regression.

Environment

support-core:2.32:not-pinned
Version: `2.7.21.1 (CloudBees Jenkins Enterprise 2.7.21.1-rolling)`

Deadlock stacktrace

Found one Java-level deadlock:
=============================
"SupportPlugin periodic bundle generator: writing support_2017-09-07_20.55.37.zip since Thu Sep 07 16:55:37 EDT 2017":
  waiting for ownable synchronizer 0x00000006f2ccb9e0, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
  which is held by "Handling POST /computer/(master)/executors/0/stop from XXXXXX : RequestHandlerThread[#155]"
"Handling POST /computer/(master)/executors/0/stop from XXXXXX : RequestHandlerThread[#155]":
  waiting for ownable synchronizer 0x00000006f3362550, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
  which is held by "Handling POST /computer/(master)/executors/4/stop from XXXXX : RequestHandlerThread[#161]"
"Handling POST /computer/(master)/executors/4/stop from XXXXXX : RequestHandlerThread[#161]":
  waiting for ownable synchronizer 0x00000006f41de5e0, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
  which is held by "Handling POST /computer/(master)/executors/6/stop from XXXXXXX : RequestHandlerThread[#162]"
"Handling POST /computer/(master)/executors/6/stop from XXXXXXXX : RequestHandlerThread[#162]":
  waiting for ownable synchronizer 0x00000006f2ccb9e0, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
  which is held by "Handling POST /computer/(master)/executors/0/stop from XXXXXXX : RequestHandlerThread[#155]"

Found 1 deadlock.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

deadlock-stacktrace.txt
32 kB
2017-09-08 08:45

Issue Links

links to

CloudBees Internal OSS-2466

workflow-durable-task-step PR 51

Activity

Ascending order - Click to sort in descending order

Félix Belzunce Arcos created issue - 2017-09-08 08:44

Félix Belzunce Arcos made changes - 2017-09-08 08:45

Field	Original Value	New Value
Attachment		deadlock-stacktrace.txt [ 39629 ]

Félix Belzunce Arcos made changes - 2017-09-08 08:49

Description

h3. What is the business impact?

Jenkins stop working due the deadlock between support-core plugin and core/org.jenkinsci.plugins.workflow.support.steps.ExecutorStepExecution$PlaceholderTask$PlaceholderExecutable$1.interrupt(ExecutorStepExecution.java:570)

h3. What is the incorrect behaviour?

The deadlock should not happen

h3. What is the expected behaviour?

You should be able to automatically create a bundle and stop a build execution

h3. Step by step to reproduce

N/A

h3. Workaround

Restart the instance, disable support-core plugin or avoid to stop builds. Issue does not seems to be very frequent.

h3. Regression

I don't think this is a regression.

h3. Deadlock stacktrace

{code:java}
Found one Java-level deadlock:
=============================
"SupportPlugin periodic bundle generator: writing support_2017-09-07_20.55.37.zip since Thu Sep 07 16:55:37 EDT 2017":
  waiting for ownable synchronizer 0x00000006f2ccb9e0, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
  which is held by "Handling POST /computer/(master)/executors/0/stop from XXXXXX : RequestHandlerThread[#155]"
"Handling POST /computer/(master)/executors/0/stop from XXXXXX : RequestHandlerThread[#155]":
  waiting for ownable synchronizer 0x00000006f3362550, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
  which is held by "Handling POST /computer/(master)/executors/4/stop from XXXXX : RequestHandlerThread[#161]"
"Handling POST /computer/(master)/executors/4/stop from XXXXXX : RequestHandlerThread[#161]":
  waiting for ownable synchronizer 0x00000006f41de5e0, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
  which is held by "Handling POST /computer/(master)/executors/6/stop from XXXXXXX : RequestHandlerThread[#162]"
"Handling POST /computer/(master)/executors/6/stop from XXXXXXXX : RequestHandlerThread[#162]":
  waiting for ownable synchronizer 0x00000006f2ccb9e0, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
  which is held by "Handling POST /computer/(master)/executors/0/stop from XXXXXXX : RequestHandlerThread[#155]"

Found 1 deadlock.

{code}

h3. What is the business impact?

Jenkins stop working due the deadlock between support-core plugin and core/org.jenkinsci.plugins.workflow.support.steps.ExecutorStepExecution$PlaceholderTask$PlaceholderExecutable$1.interrupt(ExecutorStepExecution.java:570)

h3. What is the incorrect behaviour?

The deadlock should not happen

h3. What is the expected behaviour?

You should be able to automatically create a bundle and stop a build execution

h3. Step by step to reproduce

N/A

h3. Workaround

Restart the instance, disable support-core plugin or avoid to stop builds. Issue does not seems to be very frequent.

h3. Regression

I don't think this is a regression.

h3.Environment

support-core:2.32:not-pinned
Version: `2.7.21.1 (CloudBees Jenkins Enterprise 2.7.21.1-rolling)`

h3. Deadlock stacktrace

{code:java}
Found one Java-level deadlock:
=============================
"SupportPlugin periodic bundle generator: writing support_2017-09-07_20.55.37.zip since Thu Sep 07 16:55:37 EDT 2017":
  waiting for ownable synchronizer 0x00000006f2ccb9e0, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
  which is held by "Handling POST /computer/(master)/executors/0/stop from XXXXXX : RequestHandlerThread[#155]"
"Handling POST /computer/(master)/executors/0/stop from XXXXXX : RequestHandlerThread[#155]":
  waiting for ownable synchronizer 0x00000006f3362550, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
  which is held by "Handling POST /computer/(master)/executors/4/stop from XXXXX : RequestHandlerThread[#161]"
"Handling POST /computer/(master)/executors/4/stop from XXXXXX : RequestHandlerThread[#161]":
  waiting for ownable synchronizer 0x00000006f41de5e0, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
  which is held by "Handling POST /computer/(master)/executors/6/stop from XXXXXXX : RequestHandlerThread[#162]"
"Handling POST /computer/(master)/executors/6/stop from XXXXXXXX : RequestHandlerThread[#162]":
  waiting for ownable synchronizer 0x00000006f2ccb9e0, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
  which is held by "Handling POST /computer/(master)/executors/0/stop from XXXXXXX : RequestHandlerThread[#155]"

Found 1 deadlock.

{code}

Jesse Glick made changes - 2017-09-21 20:54

Component/s		workflow-durable-task-step-plugin [ 21715 ]
Component/s	pipeline-build-step-plugin [ 21707 ]
Component/s	support-core-plugin [ 18146 ]
Assignee	Steven Christou [ schristou ]	Jesse Glick [ jglick ]
Labels		deadlock
Summary	Deadlock between support-core plugin and core/pipeline	Self-deadlock in ExecutorStepExecution$PlaceholderTask$PlaceholderExecutable$1.interrupt

Jesse Glick made changes - 2017-09-21 20:54

Status

Open [ 1 ]

In Progress [ 3 ]

Jesse Glick made changes - 2017-09-21 21:14

Remote Link

This issue links to "workflow-durable-task-step PR 51 (Web Link)" [ 17752 ]

Jesse Glick made changes - 2017-09-21 21:15

Status

In Progress [ 3 ]

In Review [ 10005 ]

Jesse Glick made changes - 2017-09-27 14:39

Resolution		Fixed [ 1 ]
Status	In Review [ 10005 ]	Resolved [ 5 ]

Sam Van Oort made changes - 2017-10-13 17:54

Status

Resolved [ 5 ]

Closed [ 6 ]

James Dumay made changes - 2017-12-01 00:44

Remote Link

This issue links to "CloudBees Internal OSS-2466 (Web Link)" [ 18284 ]

People

Assignee:: Jesse Glick

Reporter:: Félix Belzunce Arcos

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2017-09-08 08:44

Updated:: 2017-12-01 00:44

Resolved:: 2017-09-27 14:39