Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46755

Approve Swarm review as step

XMLWordPrintable

    • Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Minor Minor
    • p4-plugin

      Similar to P4Publish (where you can create shelve/submit) add a P4Approve step to Approve/Reject/Commit a Swarm review. 

      Jenkins can be added as a required reviewer in Swarm.

          [JENKINS-46755] Approve Swarm review as step

          Paul Allen created issue -
          Paul Allen made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Paul Allen made changes -
          Assignee New: Karl Wirth [ p4karl ]
          Paul Allen made changes -
          Description Original: Similar to P4Publish (where you can create shelve/submit) add a P4Approve step to Approve/Reject/Commit a Swarm review. 

                      		New: Similar to P4Publish (where you can create shelve/submit) add a P4Approve step to Approve/Reject/Commit a Swarm review. 

          Jenkins can be added as a required reviewer in Swarm.

          Karl Wirth added a comment -

          Simple example of a review Approve and Commit:

          curl -u "username:password" -X PATCH -d "state=approved" -d "commit=1" \
     "https://my-swarm-host/api/v6/reviews/123/state/"

          From: Swarm 2017.2 API Guide

          Karl Wirth added a comment - Simple example of a review Approve and Commit: curl -u "username:password" -X PATCH -d "state=approved" -d "commit=1" \      "https: //my-swarm-host/api/v6/reviews/123/state/" From: Swarm 2017.2 API Guide

          Michael Rose added a comment -

          It would also be nice if the Swarm user good just vote on the shelf without changing the state of the review.

          Michael Rose added a comment - It would also be nice if the Swarm user good just vote on the shelf without changing the state of the review.

          Paul Allen added a comment -

          Just so I fully understand you would like Jenkins to be able to vote up/down the Swarm review as a step.  I could extend P4Approve (by adding a 'Vote Up'/'Vote Down' in the dropdown).

          Paul Allen added a comment - Just so I fully understand you would like Jenkins to be able to vote up/down the Swarm review as a step.  I could extend P4Approve (by adding a 'Vote Up'/'Vote Down' in the dropdown).

          Michael Rose added a comment -

          Yes, I want to vote up/down the specific version that we attempted to build based on the build status.

          Michael Rose added a comment - Yes, I want to vote up/down the specific version that we attempted to build based on the build status.
          Paul Allen made changes -
          Labels New: P4_B

          Paul Allen added a comment -

          Raised SW-5123 missing API endpoint in Swarm.

          Paul Allen added a comment - Raised SW-5123  missing API endpoint in Swarm.

            p4paul Paul Allen
            p4paul Paul Allen
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: