Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46764

Script Security fails for all approved signatures when a signature entry starts with whitespace

XMLWordPrintable

    • Pipeline - December

      If an entry in scriptApproval.xml starts with whitespace, it results in all approved signatures getting rejected. Not sure yet what exactly the underlying problem is, but this is obviously bad.

          [JENKINS-46764] Script Security fails for all approved signatures when a signature entry starts with whitespace

          Andrew Bayer created issue -
          Andrew Bayer made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Andrew Bayer made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          Andrew Bayer added a comment -

          Preliminary PR up at https://github.com/jenkinsci/script-security-plugin/pull/150

          Andrew Bayer added a comment - Preliminary PR up at https://github.com/jenkinsci/script-security-plugin/pull/150
          Andrew Bayer made changes -
          Remote Link New: This issue links to "PR #150 (Web Link)" [ 17651 ]

          Jesse Glick added a comment -

          If the file is malformed, it should be rejected. Doing so with a clear exception message would be appropriate, of course, if the error is not already obvious.

          (How is this “critical”?)

          Jesse Glick added a comment - If the file is malformed, it should be rejected. Doing so with a clear exception message would be appropriate, of course, if the error is not already obvious. (How is this “critical”?)

          Andrew Bayer added a comment -

          Because it was breaking a large user completely until the offending line was fixed, so I want to get a fix out ASAP.

          Andrew Bayer added a comment - Because it was breaking a large user completely until the offending line was fixed, so I want to get a fix out ASAP.

          Jesse Glick added a comment -

          If you are referring to scriptApproval.xml then it would be better to fix ApprovedWhitelist to catch exceptions in its constructor and log them.

          Jesse Glick added a comment - If you are referring to scriptApproval.xml then it would be better to fix ApprovedWhitelist to catch exceptions in its constructor and log them.
          James Dumay made changes -
          Sprint New: Pipeline - December [ 446 ]
          James Dumay made changes -
          Rank New: Ranked lower

            abayer Andrew Bayer
            abayer Andrew Bayer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: