Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46864

Jenkins agent header check doesn't meet RFC, it's case-sensitive

      When you setup slave with slave-agent.jnlp it tries to connect to /tcpSlaveAgentListener/ and get JNLP port. I'm not sure if this code is relevant but the check seem to be working like this:

      https://github.com/kpfleming/jenkins-remoting/blob/master/src/main/java/hudson/remoting/Engine.java#L166

      However according to RFC 7230 and RFC 7540 HTTP headers are case-insensitive.

       

      The problem is that if you use proxy written in go agent won't connect with an "java.io.IOException: https://myjenkins.net/ is not Jenkins" error.
      See https://github.com/golang/go/issues/21868 for more details.

          [JENKINS-46864] Jenkins agent header check doesn't meet RFC, it's case-sensitive

          Roman Belyakovsky created issue -
          Roman Belyakovsky made changes -
          Summary Original: Jenkins agent header check is case-sensitive New: Jenkins agent header check doesn't meet TFC is case-sensitive
          Roman Belyakovsky made changes -
          Summary Original: Jenkins agent header check doesn't meet TFC is case-sensitive New: Jenkins agent header check doesn't meet RFC, it's case-sensitive
          Oleg Nenashev made changes -
          Component/s New: remoting [ 15489 ]
          Component/s Original: slave-setup-plugin [ 15929 ]
          Oleg Nenashev made changes -
          Labels New: newbie-friendly
          Oleg Nenashev made changes -
          Assignee Original: Giuseppe Landolfi [ peppe ]
          Long Nguyen made changes -
          Assignee New: Long Nguyen [ vulong237 ]
          Oleg Nenashev made changes -
          Link New: This issue duplicates JENKINS-40710 [ JENKINS-40710 ]
          Oleg Nenashev made changes -
          Resolution New: Duplicate [ 3 ]
          Status Original: Open [ 1 ] New: Fixed but Unreleased [ 10203 ]
          Oleg Nenashev made changes -
          Status Original: Fixed but Unreleased [ 10203 ] New: Resolved [ 5 ]

            vulong237 Long Nguyen
            hryamzik Roman Belyakovsky
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: