Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47368

Regression: core-js config.js forces to have windows.location

    XMLWordPrintable

Details

    • Blue Ocean 1.4 - beta 1

    Description

      https://github.com/jenkinsci/blueocean-plugin/blame/release/1.3/blueocean-core-js/src/js/config.js#L13

      (window.location.href.split('?')[1] || '').split('&')
      

      window.location in unit testing is normally undefined and can be until href.

      our unit tests are failing now with

      /home/thorsten/opt/src/cloudbees/operations-center-all/bluesteel/bluesteel-cjoc/node_modules/@jenkins-cd/blueocean-core-js/dist/js/config.js:19
      (window.location.href.split('?')[1] || '').split('&').forEach(function (p) {
                      ^
      
      TypeError: Cannot read property 'href' of undefined
          at Object.<anonymous> (/source/js/config.js:13:2)
      

      Attachments

        Activity

          kshultz Karl Shultz added a comment -

          Testing notes not required, because this issue was uncovered as a result of existing unit tests.

          kshultz Karl Shultz added a comment - Testing notes not required, because this issue was uncovered as a result of existing unit tests.
          jamesdumay James Dumay added a comment -

          tscherler is this in progress or in review? I saw a PR fly by but I don't know what state this is in.

          jamesdumay James Dumay added a comment - tscherler is this in progress or in review? I saw a PR fly by but I don't know what state this is in.

          jamesdumay we are blocked in updating/sync our deps to the ones coming in the release. Since the bug is in the 1.3 release we need this otherwise our release is blocked or we need to ship with 1.2

          tscherler Thorsten Scherler added a comment - jamesdumay we are blocked in updating/sync our deps to the ones coming in the release. Since the bug is in the 1.3 release we need this otherwise our release is blocked or we need to ship with 1.2
          jamesdumay James Dumay added a comment -

          alobato michaelneale is this needed for release?

          jamesdumay James Dumay added a comment - alobato michaelneale is this needed for release?

          People

            tscherler Thorsten Scherler
            tscherler Thorsten Scherler
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: