Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47420

Gerrit Verified Commands ignored when RestAPI is enabled

XMLWordPrintable

      Took me a lot of time to figure it out... But it seems like the commands specified in "Gerrit Verified Commands" are ignored if RestAPI is enabled.

      The RestAPI has two functions:

      1. Event "Missed Events Playback" - I thought this is the only one.
      2. Review comments.

      If I read the code correctly, yhere is no way to distinguish between the two as far as I read the code:

      NotificationFactory::queueBuildStarted
if (config.isUseRestApi() && event instanceof ChangeBasedEvent) {

NotificationFactory::queueBuildCompleted
if (config.isUseRestApi()
        && memoryImprint.getEvent() instanceof ChangeBasedEvent)

       

      I guess there should be a switch in configuration if to use the "Verified Commands" via RestAPI or not, so that both "Missed Events Playback" and the "Verified Commands" can work.

      Currently I disabled the RestAPI as it is more important to have a custom command that sets a custom label.

        1. image-2022-04-22-11-24-00-159.png
          image-2022-04-22-11-24-00-159.png
          155 kB
        2. image-2022-04-22-11-23-49-974.png
          image-2022-04-22-11-23-49-974.png
          164 kB

          [JENKINS-47420] Gerrit Verified Commands ignored when RestAPI is enabled

          Alon Bar-Lev created issue -
          ch liang made changes -
          Attachment New: image-2022-04-22-11-16-17-431.png [ 57915 ]
          ch liang made changes -
          Attachment New: image-2022-04-22-11-19-11-240.png [ 57916 ]
          ch liang made changes -
          Attachment New: image-2022-04-22-11-22-56-631.png [ 57917 ]
          ch liang made changes -
          Attachment Original: image-2022-04-22-11-22-56-631.png [ 57917 ]
          ch liang made changes -
          Attachment Original: image-2022-04-22-11-19-11-240.png [ 57916 ]
          ch liang made changes -
          Attachment Original: image-2022-04-22-11-16-17-431.png [ 57915 ]
          ch liang made changes -
          Attachment New: image-2022-04-22-11-23-49-974.png [ 57918 ]
          ch liang made changes -
          Attachment New: image-2022-04-22-11-24-00-159.png [ 57919 ]

            rsandell rsandell
            alonbl Alon Bar-Lev
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: