-
New Feature
-
Resolution: Fixed
-
Minor
-
None
the README for version 0.1.1 of https://plugins.jenkins.io/bitbucket-scm-trait-commit-skip indicates, in the Description, that "The filtering is only performed at change requests events, so push events to non-pull requests will be always run."
it would be totally amazing and make my day if this functionality applied equally to non-pull request changes (we never build pull requests).
i assigned it to you, javier, just to make sure you'd see it. please feel free to detach yourself. 
- is related to
-
JENKINS-45502 Add concept of "interesting" to SCMHead and SCMRevision
-
- Open
-
[JENKINS-47643] Allow [ci skip] to work for non-pull request changes
Kevin Burnett
created issue -
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
| Link | New: This issue is related to JENKINS-45502 [ JENKINS-45502 ] |
Kevin Burnett
added a comment - I upvoted JENKINS-45502. i don't fully understand the issue. i defer to your best judgement, unless stephenconnolly wants to weigh in.
Kevin Burnett
added a comment - I upvoted JENKINS-45502 . i don't fully understand the issue. i defer to your best judgement, unless stephenconnolly wants to weigh in. Let me futher explain that risk, supposiong:
- You have a GitHub Organization or Bitbucket Team/Project job
- You have a X branch, with a Jenkinsfile
- You have an Orphaned Item Strategy, discarding disabled jobs
- You have a Scan Organization Triggers, set with an interval Y
- This feature is implemented to "skip" executions from branches
- You push one commit with [skip ci] in it message to that X branch
Whenever the event gets processed, the master branch would be tagged as excluded. Y time after, the Scan Organization Triggers will kick a full repo scan and the Orphaned Item Strategy will delete the Jenkinns job associated to that master branch, so you will end losing the whole master job history.
This seems like an edge case. Nobody should be relying on Jenkins to keep their entire build history, it's not an archival platform. And if they are by some chance, they shouldn't be using that Orphaned Item Strategy.
Please implement this feature.
Will try my best to add the feature this week, but (un)fortunately i have become pretty occupied, so there wont be any guarantees
Any update on this issue? We are very interested in using "[ci skip]" to skip maven release commits for example.
Just for the record: I have finally started working on it.
Still untested, Github associated feature seems to be easy, from the provided API, to implement. OTOH, BitBucket API seems its missing some bolts (so might slow everything a bit)
There is a potential huge risk of skipping events for non pull request events. As of current implementation, the filtering is made via the isExcuded overriden method. As a collateral hiccup, the job is marked as disabled (and would be eventually be wiped with a configured Orphaned Item Strategy)
As per stephenconnolly comment at a GitHub PR;
That ticket would (hopefully) erase the drawbacks of the current implementation.
In the mean time, if you are fully aware of the current risk (or not using any Orphaned Item Strategy), I could work on it. What are your thoughts kburnett?
Again: Implementing this feature could cause a job to become erased, losing all of its run history