Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47673

Current BO Master forces third party bo based plugins to use the exact versions of npm deps

    XMLWordPrintable

Details

    • Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2

    Description

      Since the move to hpi based jdl et. al. custom plugins are forced to sync any given dependency that is coming from BO in your plugin package.json so that you use the *exact* version as BO does.

      If not you get blank screen and some error of "0 of undefined" and then you see e.g. "react-router" involved so you need to look into your version and theirs of "react-router".

      Once you have it, you have to keep the dependency of BO on your watch to adopt when they do.

      Prior to the change the dep resolving did neither worked correctly in returning you the version BO uses and not the one you requested but at least in 90% of the cases the plugin would have still worked.

      The problem here as I see it, is it forces plugin developer to release plugins on a fixed BO version and every time BO does a new release, meaning keeping backward compatibility is becoming impossible.

      Attachments

        Issue Links

          Activity

            tscherler Thorsten Scherler created issue -
            teilo James Nord made changes -
            Field Original Value New Value
            Priority Minor [ 4 ] Major [ 3 ]
            teilo James Nord made changes -
            Issue Type Improvement [ 4 ] Bug [ 1 ]
            kzantow Keith Zantow made changes -
            Assignee Keith Zantow [ kzantow ]
            kzantow Keith Zantow made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            michaelneale Michael Neale made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            michaelneale Michael Neale added a comment -

            tscherler yes, if this is the case, this does seem bad (ie in the past you didn't quite get the version you wanted right, but you would get "a version" right?)

            michaelneale Michael Neale added a comment - tscherler yes, if this is the case, this does seem bad (ie in the past you didn't quite get the version you wanted right, but you would get "a version" right?)
            kzantow Keith Zantow added a comment -

            michaelneale no, in the past we had latent bugs because we had multiple things bundled and duplicated objects being passed around in unexpected ways.

            kzantow Keith Zantow added a comment - michaelneale no, in the past we had latent bugs because we had multiple things bundled and duplicated objects being passed around in unexpected ways.
            michaelneale Michael Neale added a comment -

            kzantow so is  resolvable ?- ie it won't fuss if the third party plugin deps don't match up 100%? 

            michaelneale Michael Neale added a comment - kzantow so is  resolvable ?- ie it won't fuss if the third party plugin deps don't match up 100%? 
            michaelneale Michael Neale made changes -
            Epic Link JENKINS-35749 [ 171790 ]
            michaelneale Michael Neale made changes -
            Sprint Blue Ocean 1.4 - beta 2 [ 426 ]
            michaelneale Michael Neale made changes -
            Priority Critical [ 2 ] Blocker [ 1 ]

            > unexpected ways

            beats completely broken everytime

            michaelneale you have summarized it well.

            tscherler Thorsten Scherler added a comment - > unexpected ways beats completely broken everytime michaelneale you have summarized it well.
            michaelneale Michael Neale added a comment -

            tscherler it may just be react router, but kzantow is looking into it, obviously not intended. 

            michaelneale Michael Neale added a comment - tscherler it may just be react router, but kzantow is looking into it, obviously not intended. 
            alobato Alvaro Lobato added a comment -

            I've linked a document that seems relevant to this issue.

            alobato Alvaro Lobato added a comment - I've linked a document that seems relevant to this issue.
            alobato Alvaro Lobato made changes -
            Remote Link This issue links to "Fixing JavaScript Bundling - JENKINS-39646 etc (Web Link)" [ 17938 ]
            tscherler Thorsten Scherler made changes -
            Link This issue is blocked by JENKINS-39646 [ JENKINS-39646 ]
            tscherler Thorsten Scherler made changes -
            Link This issue relates to JENKINS-39646 [ JENKINS-39646 ]
            tscherler Thorsten Scherler made changes -
            Link This issue is blocked by JENKINS-39646 [ JENKINS-39646 ]

            I doubt that it is only react-router, since the error I saw had come from the bundle the router had been just an example

            tscherler Thorsten Scherler added a comment - I doubt that it is only react-router, since the error I saw had come from the bundle the router had been just an example

            alobato yes I think the doc explains the problem we see point on.

            tscherler Thorsten Scherler added a comment - alobato yes I think the doc explains the problem we see point on.
            tfennelly Tom FENNELLY made changes -
            Remote Link This issue links to "Fixing JavaScript Bundling - JENKINS-39646 etc (Web Link)" [ 17938 ]
            michaelneale Michael Neale added a comment -

            kzantow this one may be done now the shrinkwrap files went back in right? 

            michaelneale Michael Neale added a comment - kzantow this one may be done now the shrinkwrap files went back in right? 
            michaelneale Michael Neale made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.4 - beta 2 [ 426 ] Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2 [ 416, 426 ]
            kshultz Karl Shultz added a comment -

            Testing Notes:

            • This isn't something that can be tested within Blue Ocean itself, because the problem stems from custom plugins which rely upon, or extend, Blue Ocean itself.
            kshultz Karl Shultz added a comment - Testing Notes: This isn't something that can be tested within Blue Ocean itself, because the problem stems from custom plugins which rely upon, or extend, Blue Ocean itself.
            kshultz Karl Shultz made changes -
            Labels cloudbees-internal-steel cloudbees-internal-steel testing-notes-reviewed
            michaelneale Michael Neale added a comment -

            still a WIP - keith working very hard at it.. .this is marked as a blocker and getting the attention it needs. 

            michaelneale Michael Neale added a comment - still a WIP - keith working very hard at it.. .this is marked as a blocker and getting the attention it needs. 
            alobato Alvaro Lobato added a comment -

            michaelneale and kzantow thanks for the effort!!!

            alobato Alvaro Lobato added a comment - michaelneale and kzantow thanks for the effort!!!
            michaelneale Michael Neale made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            jbriden Jenn Briden made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

            People

              kzantow Keith Zantow
              tscherler Thorsten Scherler
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: