-
Improvement
-
Resolution: Fixed
-
Major
-
None
-
Platform: All, OS: Windows XP
Currently -S is only used for log commands when there is a version tag
specified. I can't understand why it only does it in this case. I think it's
much more efficient to use -S in all cases.
Here is the code in ChangeLogTask. This gets executed on the slave.
I propose that the if() clause be removed and the whole block is always executed.
//whk why not do this in all cases?
if (getTag() != null) {
CvsVersion myCvsVersion = new CvsVersion();
myCvsVersion.setProject(getProject());
myCvsVersion.setTaskName("cvsversion");
myCvsVersion.setCvsRoot(getCvsRoot());
myCvsVersion.setCvsRsh(getCvsRsh());
myCvsVersion.setPassfile(getPassFile());
myCvsVersion.setDest(m_dir);
myCvsVersion.execute();
if (myCvsVersion.supportsCvsLogWithSOption())
}
I’ve been running with this change for a couple of days with different
master/slave configurations and windows clients.
[JENKINS-479] Use -S in CVS log
Resolution | New: Fixed [ 1 ] | |
Status | Original: Open [ 1 ] | New: Resolved [ 5 ] |
Status | Original: Resolved [ 5 ] | New: Closed [ 6 ] |
Workflow | Original: JNJira [ 130552 ] | New: JNJira + In-Review [ 199917 ] |