Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48055

FindBugs: Channel#current() may return null, not all routines in the core handle that

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core, remoting
    • None

      Remoting versions since 3.11 have explicit annotations for Channel#getCurrent(), and there are lots of FindBugs issues reported due to that. All usages are safe, so there is no need in backporting.

      My proposal is to...

      1) Add a convenience default method to Remoting's Callable, which throws IOException
      2) Use the new convenience method in all Callable implementations in the core

          [JENKINS-48055] FindBugs: Channel#current() may return null, not all routines in the core handle that

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Epic Link New: JENKINS-36716 [ 172750 ]
          Oleg Nenashev made changes -
          Description New: Remoting versions since 3.11 have explicit annotations for Channel#getCurrent(), and there are lots of FindBugs issues reported due to that. All usages are safe, so there is no need in backporting.

          My proposal is to...

          1) Add a convenience default method to Remoting's Callable, which throws IOException
          2) Use the new convenience method in all Callable implementations in the core

          Oleg Nenashev made changes -
          Assignee New: Oleg Nenashev [ oleg_nenashev ]
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Oleg Nenashev made changes -
          Component/s New: remoting [ 15489 ]
          Oleg Nenashev made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: