Details
-
Type:
Bug
-
Status: Reopened (View Workflow)
-
Priority:
Major
-
Resolution: Unresolved
-
Component/s: junit-plugin
-
Labels:None
-
Similar Issues:
Description
Some time back, declarative pipelines were marking a stage as unstable, and I was able to have something like:
pipeline {
stage {
steps {
sh 'runuittests'
}
post {
always {
junit 'junit.xml'
}
}
}
stage {
when {
expression {
currentBuild.resultIsBetterOrEqualTo('SUCCESS')
}
}
steps {
// Only runs when tests are stable
}
}
}
However, this stopped working at some point in the recent past.
currentBuild.result does not seem to be populated when junit marks the build unstable.
Attachments
Issue Links
- is duplicated by
-
-
- Resolved
-
- links to
Activity
Code changed in jenkins
User: Andrew Bayer
Path:
src/main/java/hudson/tasks/junit/pipeline/JUnitResultsStepExecution.java
src/test/java/hudson/tasks/junit/pipeline/JUnitResultsStepTest.java
http://jenkins-ci.org/commit/junit-plugin/acd8f4843602a4629344f4cb404cec2dfb7a54d2
Log:
[FIXED JENKINS-48178] Set run result rather than context result
This fixes currentBuild.result to be UNSTABLE after test failures are
encountered. We'll want to revisit this in the future once we have
more granular stage/step status, but going with
getContext().setResult(...) was, in retrospect, premature optimization.
Releasing as 1.23 as we speak.
I use JUnit 1.24 and still failed tests captured by JUnit don't get the pipline to unstable state. A failed test causes the pipline to go to failed status.
My Pipeline:
pipeline {
agent {
docker {
image 'qnib/pytest'
args '-v /home/user/git/:/test-reports'
}
}
stages {
stage('Test') {
steps {
sh 'pytest --junitxml result.xml testing/'
}
post {
always {
junit 'result.xml'
}
}
}
}
}
IKO BH
added a comment - - edited Andrew Bayer
I use JUnit 1.24 and still failed tests captured by JUnit don't get the pipline to unstable state. A failed test causes the pipline to go to failed status.
My Pipeline:
pipeline {
agent {
docker {
image 'qnib/pytest'
args '-v /home/user/git/:/test-reports'
}
}
stages {
stage('Test') {
steps {
sh 'pytest --junitxml result.xml testing/'
}
post {
always {
junit 'result.xml'
}
}
}
}
} This bug still exists in version 1.24
PR up for junit at https://github.com/jenkinsci/junit-plugin/pull/91 to switch to setting the Run result, getting currentBuild.result and friends back to behaving like expected.