• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Component/s: warnings-plugin
• Labels:

  • git-blamer
  • plugin
• Environment:

  Jenkins v2.9.0

[JENKINS-48302] gitblamer failed to parse relative file path

Mathieu Zhang created issue - 2017-11-29 21:03

Mathieu Zhang made changes - 2017-11-29 21:22

Environment

New: Jenkins v2.9.0

Mathieu Zhang made changes - 2017-11-29 21:24

Description

Original: I have the following workspace structure: {{- $WORKSPACE/git-checkout}} {{- $WORKSPACE/artifacts}} The codes are build with (from $WORKSPACE) {{make -C git-checkout ARTIFACTS_DIR=$\{WORKSPACE}/artifacts}} which would write output files to $WORKSPACE/artifacts, including pylint output, which contains lines like this {{src/updates/update.py:028: [E0611(no-name-in-module), ] No name 'updates' in module 'utils'}} gitblamer is unable the generate blames from this annotation, with series of warnings like this: {{<Git Blamer> Using GitBlamer to create author and commit information for all warnings.}} {{<Git Blamer> GIT_COMMIT=c636547ad11d989ef8f984591468cc00c46fb345, workspace=/var/jenkins/build/workspace/project-builder/git-checkout}} {{<Git Blamer> Skipping non-workspace file /var/jenkins/build/workspace/project-builder/git-checkout/src/updates/update.py (workspace = /var/jenkins/build/workspace/project-builder/git-checkout, absolute = /src/updates/update.py.}} {{<Git Blamer> Skipping file src/updates/update.py, no result found.}} It appears that git-blamer failed to get the correct absolute path for the files.

New: I have the following workspace structure: {{- $WORKSPACE/git-checkout}}  {{- $WORKSPACE/artifacts}} The codes are build with (from $WORKSPACE) {{make -C git-checkout ARTIFACTS_DIR=$\{WORKSPACE}/artifacts}} which would write output files to $WORKSPACE/artifacts, including pylint output, which contains lines like this {{src/updates/update.py:028: [E0611(no-name-in-module), ] No name 'updates' in module 'utils'}} gitblamer is unable the generate blames from this annotation, with series of warnings like this: {{<Git Blamer> Using GitBlamer to create author and commit information for all warnings.}}  {{<Git Blamer> GIT_COMMIT=c636547ad11d989ef8f984591468cc00c46fb345, workspace=/var/jenkins/build/workspace/project-builder/git-checkout}}  {{<Git Blamer> Skipping non-workspace file src/updates/update.py (workspace = /var/jenkins/build/workspace/project-builder/git-checkout, absolute = /src/updates/update.py.}}  {{<Git Blamer> Skipping file src/updates/update.py, no result found.}} It appears that git-blamer failed to get the correct absolute path for the files.

Collapse comment: Mathieu Zhang added a comment - 2017-11-30 21:27

Mathieu Zhang added a comment - 2017-11-30 21:27

It seems this line

https://github.com/jenkinsci/analysis-core-plugin/blob/master/src/main/java/hudson/plugins/analysis/util/AbstractBlamer.java#L115

converse the possibly relative path storedFileName to absolute path, not taking into account of workspacePath.

Expand comment: Mathieu Zhang added a comment - 2017-11-30 21:27

Mathieu Zhang added a comment - 2017-11-30 21:27 It seems this line https://github.com/jenkinsci/analysis-core-plugin/blob/master/src/main/java/hudson/plugins/analysis/util/AbstractBlamer.java#L115 converse the possibly relative path storedFileName to absolute path, not taking into account of workspacePath .

Collapse comment: Ulli Hafner added a comment - 2017-11-30 21:51

Ulli Hafner added a comment - 2017-11-30 21:51

Seems that the pylint parser does not assign absolute path names for warnings. So canonical path does not work in the way it should. Is there an option in pylon to enable absolute paths for the warnings?

Expand comment: Ulli Hafner added a comment - 2017-11-30 21:51

Ulli Hafner added a comment - 2017-11-30 21:51 Seems that the pylint parser does not assign absolute path names for warnings. So canonical path does not work in the way it should. Is there an option in pylon to enable absolute paths for the warnings?

Collapse comment: Mathieu Zhang added a comment - 2017-12-11 20:43

Mathieu Zhang added a comment - 2017-12-11 20:43

I suppose pylint has the formatting keyword 'abspath' that I can use instead.  It would include the very long Jenkins workspace path prefix.  Can we not infer that the pylint path is relative to the git workspace if it does not start with a leading /?

Expand comment: Mathieu Zhang added a comment - 2017-12-11 20:43

Mathieu Zhang added a comment - 2017-12-11 20:43 I suppose pylint has the formatting keyword 'abspath' that I can use instead.  It would include the very long Jenkins workspace path prefix.  Can we not infer that the pylint path is relative to the git workspace if it does not start with a leading /?

Collapse comment: Ulli Hafner added a comment - 2018-10-02 23:14

Ulli Hafner added a comment - 2018-10-02 23:14

Absolute path resolving should be more robust in the latest beta.

Expand comment: Ulli Hafner added a comment - 2018-10-02 23:14

Ulli Hafner added a comment - 2018-10-02 23:14 Absolute path resolving should be more robust in the latest beta.

Ulli Hafner made changes - 2018-10-02 23:14

Resolution		New: Fixed [ 1 ]
Status	Original: Open [ 1 ]	New: Fixed but Unreleased [ 10203 ]

Ulli Hafner made changes - 2018-10-05 08:38

Released As		New: 5.0.0-beta3
Status	Original: Fixed but Unreleased [ 10203 ]	New: Resolved [ 5 ]