Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48365

Command launcher plugin does not get installed on core update crossing 2.86

      The plugin manager is supposed to install detached plugins if you upgrade from a version which previously had their functionality as part of core to a version which now has it detached. This is not working for some reason and we need to investigate why.

      Steps to reproduce:

      Install 2.84

      Pass setup wizard installing no plugins.

      Update to 2.93 for same home

      Expected:

      Update installs command-launcher plugin (plus deps as needed)

      Actual:

      No plugins installed

          [JENKINS-48365] Command launcher plugin does not get installed on core update crossing 2.86

          Daniel Beck created issue -

          Jesse Glick added a comment -

          Possibly related to this apparent bug. I think we have no test coverage for this kind of upgrade scenario because AFAIK JenkinsRule cannot express it.

          Jesse Glick added a comment - Possibly related to this apparent bug . I think we have no test coverage for this kind of upgrade scenario because AFAIK JenkinsRule cannot express it.
          Daniel Beck made changes -
          Link New: This issue is related to JENKINS-41727 [ JENKINS-41727 ]
          Daniel Beck made changes -
          Link Original: This issue is related to JENKINS-41727 [ JENKINS-41727 ]
          Ryan Campbell made changes -
          Description Original: h3. Steps to reproduce:

          Install 2.84

          Pass setup wizard installing no plugins.

          Update to 2.93 for same home
          h3. Expected:

          Update installs command-launcher plugin (plus deps as needed)
          h3. Actual:

          No plugins installed
          New: The plugin manager is supposed to install detached plugins if you upgrade from a version which previously had them installed to a version which now has them detached. This is not working for some reason and we need to investigate why.

          h3. Steps to reproduce:

          Install 2.84

          Pass setup wizard installing no plugins.

          Update to 2.93 for same home
          h3. Expected:

          Update installs command-launcher plugin (plus deps as needed)
          h3. Actual:

          No plugins installed
          Daniel Beck made changes -
          Description Original: The plugin manager is supposed to install detached plugins if you upgrade from a version which previously had them installed to a version which now has them detached. This is not working for some reason and we need to investigate why.

          h3. Steps to reproduce:

          Install 2.84

          Pass setup wizard installing no plugins.

          Update to 2.93 for same home
          h3. Expected:

          Update installs command-launcher plugin (plus deps as needed)
          h3. Actual:

          No plugins installed
          New: The plugin manager is supposed to install detached plugins if you upgrade from a version which previously had their functionality as part of core to a version which now has it detached. This is not working for some reason and we need to investigate why.
          h3. Steps to reproduce:

          Install 2.84

          Pass setup wizard installing no plugins.

          Update to 2.93 for same home
          h3. Expected:

          Update installs command-launcher plugin (plus deps as needed)
          h3. Actual:

          No plugins installed

          Daniel Beck added a comment -

          Can the ATH do upgrade tests? We could go from 2.85 to SUT and see whether the plugin gets installed (for every future pair of 'attached core version' and 'plugin')

          Daniel Beck added a comment - Can the ATH do upgrade tests? We could go from 2.85 to SUT and see whether the plugin gets installed (for every future pair of 'attached core version' and 'plugin')
          CloudBees Inc. made changes -
          Remote Link New: This issue links to "CloudBees Internal OSS-2588 (Web Link)" [ 18470 ]

          Devin Nusbaum added a comment -

          I was able to reproduce the issue. I didn't see any log entries about upgrading during the upgrade process (even with a custom logger for PluginManager). I used the "Upgrade automatically" button from CoreUpdateMonitor, is it expected for the block in the following if statement to not be entered in that case?

          if (InstallState.UPGRADE.equals(installState)) {
              LOGGER.log(INFO, "Upgrading Jenkins. ...
              ...
          } else {
              ... code Jesse linked to ...
          }
          

          The logic in the else would only upgrade a detached plugin that is already installed which is not the case for command-launcher when upgrading from 2.84 to 2.93. Maybe a recent change has broken something with InstallState?

          Devin Nusbaum added a comment - I was able to reproduce the issue. I didn't see any log entries about upgrading during the upgrade process (even with a custom logger for PluginManager). I used the "Upgrade automatically" button from CoreUpdateMonitor, is it expected for the block in the following if statement to not be entered in that case? if (InstallState.UPGRADE.equals(installState)) { LOGGER.log(INFO, "Upgrading Jenkins. ... ... } else { ... code Jesse linked to ... } The logic in the else would only upgrade a detached plugin that is already installed which is not the case for command-launcher when upgrading from 2.84 to 2.93. Maybe a recent change has broken something with InstallState?
          Devin Nusbaum made changes -
          Assignee New: Devin Nusbaum [ dnusbaum ]

            dnusbaum Devin Nusbaum
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: