Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48405

Use NIO in Util.deleteFile for better error messages

    XMLWordPrintable

Details

    Description

      Switching to NIO will improve the error messages when a file cannot be deleted, and will allow us to remove some JNR and Ant Chmod usages in Util#makeWritable.

      This should affect all of the recursive deletion methods in hudson.model.FilePath and hudson.model.Util as they all eventually call Util#deleteFile.

      Attachments

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-36088 Use NIO rather than JNR whenever possible

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-47324 FilePath API in Jenkins should propagate errors

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            dnusbaum Devin Nusbaum created issue -
            dnusbaum Devin Nusbaum made changes -
            Field Original Value New Value
            Labels diagnostics jdk7
            dnusbaum Devin Nusbaum made changes -
            Link This issue relates to JENKINS-36088 [ JENKINS-36088 ]
            dnusbaum Devin Nusbaum made changes -
            Link This issue relates to JENKINS-47324 [ JENKINS-47324 ]
            dnusbaum Devin Nusbaum made changes -
            Description Switching to NIO will improve the error messages when a file cannot be deleted, and will allow us to remove some JNR and Ant Chmod usages in Util#makeWritable.

            This should affect all of the recursive deletion methods in {{hudson.model.FilePath}} and {{hudson.model.Util}} as they all eventually call {{Util#deleteFile}}.             		Switching to NIO will improve the error messages when a file cannot be deleted, and will allow us to remove some JNR and Ant Chmod usages in {{Util#makeWritable}}.

            This should affect all of the recursive deletion methods in {{hudson.model.FilePath}} and {{hudson.model.Util}} as they all eventually call {{Util#deleteFile}}.
            dnusbaum Devin Nusbaum made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            danielbeck Daniel Beck made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]

            People

              dnusbaum Devin Nusbaum
              dnusbaum Devin Nusbaum
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: