Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48593

System property hudson.consoleTailKB is ignored

    XMLWordPrintable

Details

    Description

      The system property "hudson.consoleTailKB" is supposed to control how many KB of console log is shown in the default console view.

      It is used in two places:

      https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/hudson/model/Run/console.jelly#L38
      https://github.com/jenkinsci/workflow-support-plugin/blob/master/src/main/resources/org/jenkinsci/plugins/workflow/support/actions/LogActionImpl/index.jelly#L39

      Both jelly scripts expect a method getSystemProperty(key) on the Functions class. But that method does not exist. Therefore the default of 150 KB is always used and the system property is ignored.

      The fix is available in this PR: https://github.com/jenkinsci/jenkins/pull/3200

       

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          jan_z Jan Zuchhold created issue -
          oleg_nenashev Oleg Nenashev made changes -
          Field Original Value New Value
          Assignee Jan Zuchhold [ jan_z ]
          oleg_nenashev Oleg Nenashev made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          oleg_nenashev Oleg Nenashev made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          oleg_nenashev Oleg Nenashev made changes -
          Remote Link This issue links to "https://github.com/jenkinsci/jenkins/pull/3200 (Web Link)" [ 19423 ]
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jan Zuchhold
          Path:
          core/src/main/java/hudson/Functions.java
          http://jenkins-ci.org/commit/jenkins/006c51256e58d9b691956962d9fd624fb0c1e08b
          Log:
          JENKINS-48593 - Add getSystemProperty(key) to fix hudson.consoleTailKB system property (#3200)

          • Add getSystemProperty(key) to fix hudson.consoleTailKB system property
          • Add Javadoc, @Restricted and delegate to SystemProperties

          These changes were requested by @daniel-beck.

          • PR was not merged in time for 2.96
          • Changes as requested by @oleg-nenashev
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jan Zuchhold Path: core/src/main/java/hudson/Functions.java http://jenkins-ci.org/commit/jenkins/006c51256e58d9b691956962d9fd624fb0c1e08b Log: JENKINS-48593 - Add getSystemProperty(key) to fix hudson.consoleTailKB system property (#3200) Add getSystemProperty(key) to fix hudson.consoleTailKB system property Add Javadoc, @Restricted and delegate to SystemProperties These changes were requested by @daniel-beck. PR was not merged in time for 2.96 Changes as requested by @oleg-nenashev
          oleg_nenashev Oleg Nenashev added a comment -

          The change has been integrated towards 2.98.
          Marked it as lts-candidate

          oleg_nenashev Oleg Nenashev added a comment - The change has been integrated towards 2.98. Marked it as lts-candidate
          oleg_nenashev Oleg Nenashev made changes -
          Resolution Fixed [ 1 ]
          Status In Review [ 10005 ] Resolved [ 5 ]
          oleg_nenashev Oleg Nenashev made changes -
          Labels lts-candidate
          olivergondza Oliver Gondža made changes -
          Labels lts-candidate 2.89.3-fixed
          danielbeck Daniel Beck made changes -
          Labels 2.89.3-fixed 2.89.3-fixed regression

          People

            jan_z Jan Zuchhold
            jan_z Jan Zuchhold
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: