Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48638

Simplified/clarified Jenkins.getInstance

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Similar Issues:

      Description

      JENKINS-34857 tracks an abortive attempt to make Jenkins.getInstance throw IllegalStateException as it is documented to do. While fixes like JENKINS-48543 could make that possible, it is safer and more straightforward to have one nondeprecated method which is @CheckForNull (but rarely used) and one nondeprecated method which is @Nonnull (and recommended for most callers).

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-34857 FATAL: Jenkins has not been started, or was already shut down

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

          Task - A task that needs to be done. JENKINS-48543 Avoid slave → master callables

          • Major - Major loss of function.
          • Open
          links to

          Web Link PR 3195

            Activity

            Ascending order - Click to sort in descending order
            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue relates to JENKINS-34857 [ JENKINS-34857 ]
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-48543 [ JENKINS-48543 ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "PR 3195 (Web Link)" [ 19501 ]
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/Hudson.java
            core/src/main/java/jenkins/model/Jenkins.java
            core/src/main/resources/META-INF/upgrade/Hudson.hint
            core/src/main/resources/META-INF/upgrade/Jenkins.hint
            http://jenkins-ci.org/commit/jenkins/001a33c747feb437a1bf5f0349b6988f517ec9a8
            Log:
            JENKINS-48638 Deprecate Jenkins.getInstance in favor of (usually) get (#3195)

            • Deprecate Jenkins.getInstance in favor of (usually) getActiveInstance.
            • Introduced get() as a concise non-null accessor.
            • May as well suggest rewrites of getActiveInstance too.
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Hudson.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/META-INF/upgrade/Hudson.hint core/src/main/resources/META-INF/upgrade/Jenkins.hint http://jenkins-ci.org/commit/jenkins/001a33c747feb437a1bf5f0349b6988f517ec9a8 Log: JENKINS-48638 Deprecate Jenkins.getInstance in favor of (usually) get (#3195) Deprecate Jenkins.getInstance in favor of (usually) getActiveInstance. Introduced get() as a concise non-null accessor. May as well suggest rewrites of getActiveInstance too.
            Hide
            Permalink
            jglick Jesse Glick added a comment -

            Merged toward 2.98.

            Show
            jglick Jesse Glick added a comment - Merged toward 2.98.
            jglick Jesse Glick made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]

              People

              Assignee:
              jglick Jesse Glick
              Reporter:
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: