-
Improvement
-
Resolution: Fixed
-
Minor
-
Jenkins 2.89.2
Jira Plugin 2.5
The issueCache in hudson.plugins.jira.JiraSite make use of Guava cache.
/** * Returns the remote issue with the given id or <code>null</code> if it wasn't found. */ @CheckForNull public JiraIssue getIssue(final String id) throws IOException { try { Issue issue = issueCache.get(id, new Callable<Issue>() { public Issue call() throws Exception { JiraSession session = getSession(); Issue issue = null; if (session != null) { issue = session.getIssue(id); } return issue; } }); if (issue == null) { return null; } return new JiraIssue(issue); } catch (ExecutionException e) { throw new IOException(e); } }
As noticed in the com.google.common.cache.Cache JavaDoc,
V get(K key, Callable<? extends V> valueLoader) throws ExecutionException;
valueLoader must not return null; it may either return a non-null value or throw an exception.
session.getIssue(id) may return null if no such issue exists, causing throwing unhandled RuntimeExcepting com.google.common.cache.CacheLoader$InvalidCacheLoadException.
Since no such issue can be found in Jira site, we can positively cache the null issue.
There are various reasons for the issue can NOT be found in Jira site. Let's leave it from this issue.
- is related to
-
JENKINS-35998 No issue update if at least one issue does not exists
-
- Reopened
-
- links to
[JENKINS-48716] Prevent Guava InvalidCacheLoadException
| Environment |
Original:
Jenkins 2.89.2, Jira Plugin 2.5 |
New:
Jenkins 2.89.2 Jira Plugin 2.5 |
| Description |
New:
The issueCache in hudson.plugins.jira.JiraSite make use of Guava cache. {code:java} /** * Returns the remote issue with the given id or <code>null</code> if it wasn't found. */ @CheckForNull public JiraIssue getIssue(final String id) throws IOException { try { Issue issue = issueCache.get(id, new Callable<Issue>() { public Issue call() throws Exception { JiraSession session = getSession(); Issue issue = null; if (session != null) { issue = session.getIssue(id); } return issue; } }); if (issue == null) { return null; } return new JiraIssue(issue); } catch (ExecutionException e) { throw new IOException(e); } } {code} As noticed in the com.google.common.cache.Cache JavaDoc, {code:java} V get(K key, Callable<? extends V> valueLoader) throws ExecutionException; {code} valueLoader *must not* return null; it may either return a non-null value or throw an exception. session.getIssue(id) may return null if no such issue exists, causing throwing unhandled RuntimeExcepting com.google.common.cache.CacheLoader$InvalidCacheLoadException. Since no such issue can be found in Jira site, we can safely cache the |
| Description |
Original:
The issueCache in hudson.plugins.jira.JiraSite make use of Guava cache. {code:java} /** * Returns the remote issue with the given id or <code>null</code> if it wasn't found. */ @CheckForNull public JiraIssue getIssue(final String id) throws IOException { try { Issue issue = issueCache.get(id, new Callable<Issue>() { public Issue call() throws Exception { JiraSession session = getSession(); Issue issue = null; if (session != null) { issue = session.getIssue(id); } return issue; } }); if (issue == null) { return null; } return new JiraIssue(issue); } catch (ExecutionException e) { throw new IOException(e); } } {code} As noticed in the com.google.common.cache.Cache JavaDoc, {code:java} V get(K key, Callable<? extends V> valueLoader) throws ExecutionException; {code} valueLoader *must not* return null; it may either return a non-null value or throw an exception. session.getIssue(id) may return null if no such issue exists, causing throwing unhandled RuntimeExcepting com.google.common.cache.CacheLoader$InvalidCacheLoadException. Since no such issue can be found in Jira site, we can safely cache the |
New:
The issueCache in hudson.plugins.jira.JiraSite make use of Guava cache. {code:java} /** * Returns the remote issue with the given id or <code>null</code> if it wasn't found. */ @CheckForNull public JiraIssue getIssue(final String id) throws IOException { try { Issue issue = issueCache.get(id, new Callable<Issue>() { public Issue call() throws Exception { JiraSession session = getSession(); Issue issue = null; if (session != null) { issue = session.getIssue(id); } return issue; } }); if (issue == null) { return null; } return new JiraIssue(issue); } catch (ExecutionException e) { throw new IOException(e); } } {code} As noticed in the com.google.common.cache.Cache JavaDoc, {code:java} V get(K key, Callable<? extends V> valueLoader) throws ExecutionException; {code} valueLoader *must not* return null; it may either return a non-null value or throw an exception. session.getIssue(id) may return null if no such issue exists, causing throwing unhandled RuntimeExcepting com.google.common.cache.CacheLoader$InvalidCacheLoadException. Since no such issue can be found in Jira site, we can positively cache the null issue. There are various reasons for the issue can NOT be found in Jira site. Let's leave it from this issue. |
| Link | New: This issue is related to JENKINS-35998 [ JENKINS-35998 ] |
| Assignee | New: Zhenlei Huang [ gmshake ] |
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
| Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
| Remote Link | New: This issue links to "PR-136 (Web Link)" [ 19725 ] |
| Labels | Original: exception plugin | New: jira-plugin-2.5.1 |
| Resolution | New: Fixed [ 1 ] | |
| Status | Original: In Review [ 10005 ] | New: Resolved [ 5 ] |