Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48761

Jenkins Agents do not connect after update from version 2.95 to version 2.99 and jobs fail

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • core, remoting
    • CentOS root node and 2 macOS agents connecting to it through JNLP4.

      Seeing something that sounds similar to https://issues.jenkins-ci.org/browse/JENKINS-48754.

      "After having installed Jenkins Version 2.99, none of my agents did connect to the server anymore. Even a restart of the java script on the slave did not help."

      Workaround: Update Remoting on the agent side to 3.15

      Agent is launched like so:

      java -jar agent.jar -jnlpUrl https://<Jenkins URL>/computer/<AgentName>/<>.jnlp -secret <Agent Secret>
      

          [JENKINS-48761] Jenkins Agents do not connect after update from version 2.95 to version 2.99 and jobs fail

          Goffredo Marocchi added a comment - - edited

          May be related... Suggested workaround is to update remoting to 3.15 for the agents. oleg_nenashev how would I do that?

          Remoting on the master should have happened with the 2.98 Jenkins update:

           Update Remoting from 3.14 to 3.15 to fix several issues. (full changelog, issue 37566, issue 37670, issue 38696, issue 46724, issue 47965, issue 48055, issue 48130, issue 48133, issue 48309) 
          

          Goffredo Marocchi added a comment - - edited May be related... Suggested workaround is to update remoting to 3.15 for the agents. oleg_nenashev how would I do that? Remoting on the master should have happened with the 2.98 Jenkins update: Update Remoting from 3.14 to 3.15 to fix several issues. (full changelog, issue 37566, issue 37670, issue 38696, issue 46724, issue 47965, issue 48055, issue 48130, issue 48133, issue 48309)

          Oleg Nenashev added a comment -

          > Suggested workaround is to update remoting to 3.15 for the agents. Oleg Nenashev how would I do that?

          Depends on which Launcher you use...

          • SSH Slaves get updated automatically
          • Windows Slaves (Java Web Start ones) may need manual update of slave.jar OR service restart if automatic upgrade is enabled
          • Swarm Plugin - update to the latest Swarm Plugin Client
          • Other agent types - to be handled on a case-by-case basis

          Oleg Nenashev added a comment - > Suggested workaround is to update remoting to 3.15 for the agents. Oleg Nenashev how would I do that? Depends on which Launcher you use... SSH Slaves get updated automatically Windows Slaves (Java Web Start ones) may need manual update of slave.jar OR service restart if automatic upgrade is enabled Swarm Plugin - update to the latest Swarm Plugin Client Other agent types - to be handled on a case-by-case basis

          Stupid me...

          wget https://<Jenkins CI>/jnlpJars/agent.jar
          

          ... results in a connected Agent .

          Goffredo Marocchi added a comment - Stupid me... wget https: //<Jenkins CI>/jnlpJars/agent.jar ... results in a connected Agent .

          Oleg Nenashev added a comment -

          Well, it SHOULD be working with old agent versions

          Oleg Nenashev added a comment - Well, it SHOULD be working with old agent versions

          Fair enough, thanks for working on it .

          Goffredo Marocchi added a comment - Fair enough, thanks for working on it .

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/Launcher.java
          core/src/main/java/hudson/model/Computer.java
          core/src/main/java/hudson/slaves/ChannelPinger.java
          core/src/main/java/hudson/slaves/SlaveComputer.java
          core/src/main/java/jenkins/security/MasterToSlaveCallable.java
          core/src/main/java/jenkins/slaves/StandardOutputSwapper.java
          http://jenkins-ci.org/commit/jenkins/4eb314b32742a07dcc68e716b7de1d31f0f917c8
          Log:
          JENKINS-48761 - Restore binary compatibility with agents running old Remoting versions

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/Launcher.java core/src/main/java/hudson/model/Computer.java core/src/main/java/hudson/slaves/ChannelPinger.java core/src/main/java/hudson/slaves/SlaveComputer.java core/src/main/java/jenkins/security/MasterToSlaveCallable.java core/src/main/java/jenkins/slaves/StandardOutputSwapper.java http://jenkins-ci.org/commit/jenkins/4eb314b32742a07dcc68e716b7de1d31f0f917c8 Log: JENKINS-48761 - Restore binary compatibility with agents running old Remoting versions

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/jenkins/security/MasterToSlaveCallable.java
          http://jenkins-ci.org/commit/jenkins/cf1589734f98d895ecfab0ffda18976527f8d507
          Log:
          JENKINS-48761 - Use pre-Remoting 3.0 ChannelClosedException APIs

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/jenkins/security/MasterToSlaveCallable.java http://jenkins-ci.org/commit/jenkins/cf1589734f98d895ecfab0ffda18976527f8d507 Log: JENKINS-48761 - Use pre-Remoting 3.0 ChannelClosedException APIs

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          test/pom.xml
          test/src/test/java/jenkins/slaves/OldRemotingAgentTest.java
          http://jenkins-ci.org/commit/jenkins/8a34983d4571bab3acce87bb84ecd05a8251e528
          Log:
          JENKINS-48761 - Create a smoke test for old agents

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: test/pom.xml test/src/test/java/jenkins/slaves/OldRemotingAgentTest.java http://jenkins-ci.org/commit/jenkins/8a34983d4571bab3acce87bb84ecd05a8251e528 Log: JENKINS-48761 - Create a smoke test for old agents

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/filter/resources/jenkins/slaves/remoting-info.properties
          core/src/main/java/hudson/Launcher.java
          core/src/main/java/hudson/TcpSlaveAgentListener.java
          core/src/main/java/hudson/model/Computer.java
          core/src/main/java/hudson/slaves/ChannelPinger.java
          core/src/main/java/hudson/slaves/SlaveComputer.java
          core/src/main/java/jenkins/security/MasterToSlaveCallable.java
          core/src/main/java/jenkins/slaves/RemotingVersionInfo.java
          core/src/main/java/jenkins/slaves/StandardOutputSwapper.java
          core/src/test/java/jenkins/slaves/RemotingVersionInfoTest.java
          pom.xml
          test/pom.xml
          test/src/test/java/jenkins/slaves/OldRemotingAgentTest.java
          http://jenkins-ci.org/commit/jenkins/01b8ed8c71dee97d661bd5bf4b8e4bc5ecd636ae
          Log:
          JENKINS-48761 - Address review comments from @jglick

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/filter/resources/jenkins/slaves/remoting-info.properties core/src/main/java/hudson/Launcher.java core/src/main/java/hudson/TcpSlaveAgentListener.java core/src/main/java/hudson/model/Computer.java core/src/main/java/hudson/slaves/ChannelPinger.java core/src/main/java/hudson/slaves/SlaveComputer.java core/src/main/java/jenkins/security/MasterToSlaveCallable.java core/src/main/java/jenkins/slaves/RemotingVersionInfo.java core/src/main/java/jenkins/slaves/StandardOutputSwapper.java core/src/test/java/jenkins/slaves/RemotingVersionInfoTest.java pom.xml test/pom.xml test/src/test/java/jenkins/slaves/OldRemotingAgentTest.java http://jenkins-ci.org/commit/jenkins/01b8ed8c71dee97d661bd5bf4b8e4bc5ecd636ae Log: JENKINS-48761 - Address review comments from @jglick

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/filter/resources/jenkins/slaves/remoting-info.properties
          core/src/main/java/hudson/Launcher.java
          core/src/main/java/hudson/TcpSlaveAgentListener.java
          core/src/main/java/hudson/model/Computer.java
          core/src/main/java/hudson/slaves/SlaveComputer.java
          core/src/main/java/jenkins/security/MasterToSlaveCallable.java
          core/src/main/java/jenkins/slaves/RemotingVersionInfo.java
          core/src/test/java/jenkins/slaves/RemotingVersionInfoTest.java
          pom.xml
          test/pom.xml
          test/src/test/java/jenkins/slaves/OldRemotingAgentTest.java
          http://jenkins-ci.org/commit/jenkins/8eb4254b0f56086f6576c108913fc5d066f4be9b
          Log:
          Merge pull request #3212 from oleg-nenashev/bug/JENKINS-48761-remoting-API

          JENKINS-48761 - Restore binary compatibility with agents running old Remoting versions

          Compare: https://github.com/jenkinsci/jenkins/compare/99ca10114332...8eb4254b0f56

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/filter/resources/jenkins/slaves/remoting-info.properties core/src/main/java/hudson/Launcher.java core/src/main/java/hudson/TcpSlaveAgentListener.java core/src/main/java/hudson/model/Computer.java core/src/main/java/hudson/slaves/SlaveComputer.java core/src/main/java/jenkins/security/MasterToSlaveCallable.java core/src/main/java/jenkins/slaves/RemotingVersionInfo.java core/src/test/java/jenkins/slaves/RemotingVersionInfoTest.java pom.xml test/pom.xml test/src/test/java/jenkins/slaves/OldRemotingAgentTest.java http://jenkins-ci.org/commit/jenkins/8eb4254b0f56086f6576c108913fc5d066f4be9b Log: Merge pull request #3212 from oleg-nenashev/bug/ JENKINS-48761 -remoting-API JENKINS-48761 - Restore binary compatibility with agents running old Remoting versions Compare: https://github.com/jenkinsci/jenkins/compare/99ca10114332...8eb4254b0f56

          Oleg Nenashev added a comment -

          It should be resolved in Jenkins 2.100, the release is currently in the progress.
          Retrospective thread: https://groups.google.com/forum/#!topic/jenkinsci-dev/-VQ5YU0yYhg

          Oleg Nenashev added a comment - It should be resolved in Jenkins 2.100, the release is currently in the progress. Retrospective thread: https://groups.google.com/forum/#!topic/jenkinsci-dev/-VQ5YU0yYhg

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          content/_data/changelogs/weekly.yml
          http://jenkins-ci.org/commit/jenkins.io/ac42d83bf51e56e826991839a5471eccdd767543
          Log:
          Changelog: noting JENKINS-48761/JENKINS-48754 in Jenkins 2.100.

          The PR also adds warning banners to 2.98/2.99

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: content/_data/changelogs/weekly.yml http://jenkins-ci.org/commit/jenkins.io/ac42d83bf51e56e826991839a5471eccdd767543 Log: Changelog: noting JENKINS-48761 / JENKINS-48754 in Jenkins 2.100. The PR also adds warning banners to 2.98/2.99

          Code changed in jenkins
          User: R. Tyler Croy
          Path:
          content/_data/changelogs/weekly.yml
          http://jenkins-ci.org/commit/jenkins.io/99fe6d097fd1cc1f6797ad7b816c98dec3261a37
          Log:
          Merge pull request #1305 from oleg-nenashev/changelog/2.100

          Changelog: noting JENKINS-48761/JENKINS-48754 in Jenkins 2.100.

          Compare: https://github.com/jenkins-infra/jenkins.io/compare/62362762ff55...99fe6d097fd1

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: R. Tyler Croy Path: content/_data/changelogs/weekly.yml http://jenkins-ci.org/commit/jenkins.io/99fe6d097fd1cc1f6797ad7b816c98dec3261a37 Log: Merge pull request #1305 from oleg-nenashev/changelog/2.100 Changelog: noting JENKINS-48761 / JENKINS-48754 in Jenkins 2.100. Compare: https://github.com/jenkins-infra/jenkins.io/compare/62362762ff55...99fe6d097fd1

          Hello oleg_nenashev would it be possible for this ticket to be made private or deleted?

          Goffredo Marocchi added a comment - Hello oleg_nenashev would it be possible for this ticket to be made private or deleted?

            oleg_nenashev Oleg Nenashev
            panajev Goffredo Marocchi
            Votes:
            3 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: