Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48986

<f:select> broken if inside table

    XMLWordPrintable

Details

    Description

      bug introduced in JENKINS-42443

      https://github.com/jenkinsci/jenkins/commit/ed329d1088c164df560b9299cd9096ae76519418#diff-11b7f44b11e4a3dbf03e0baff633eb44R8

      findFollowingTR(listBox, "validation-error-area") looks for first parent TR tag, which could be not the one that should be used (the one from <f:entry>) that causes js error

      Uncaught TypeError: Cannot read property 'firstChild' of undefined
      at updateListBox (select.js:8)
      at select.js:79
      at h (hudson-behavior.js:1295)
      at refillOnChange (hudson-behavior.js:1310)
      at select.js:77
      at Array.forEach (<anonymous>)
      at behavior.js:111
      at Array.forEach (<anonymous>)
      at behavior.js:107
      at Array.forEach (<anonymous>)

      which causes dropdown not to be populated 

      example jelly which doesn't in jenkins 2.50+

      https://github.com/jenkinsci/jclouds-plugin/blob/936aed28def5f2434dbdaaa72d260aadd3f623da/jclouds-plugin/src/main/resources/jenkins/plugins/jclouds/compute/UserData/config.jelly

       

       

       

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          tommywo Tomasz Wojtun added a comment -

          stephenconnolly can you look into this?

          tommywo Tomasz Wojtun added a comment - stephenconnolly can you look into this?
          stephenconnolly Stephen Connolly added a comment -

          jclouds should be using an <f:entry> to hold the <f:select> so this is a bug in jclouds IMHO

          stephenconnolly Stephen Connolly added a comment - jclouds should be using an <f:entry> to hold the <f:select> so this is a bug in jclouds IMHO
          tommywo Tomasz Wojtun added a comment -

          it's hold in this entry: https://github.com/jenkinsci/jclouds-plugin/blob/936aed28def5f2434dbdaaa72d260aadd3f623da/jclouds-plugin/src/main/resources/jenkins/plugins/jclouds/compute/JCloudsSlaveTemplate/config.jelly#L127

           

          tommywo Tomasz Wojtun added a comment - it's hold in this entry: https://github.com/jenkinsci/jclouds-plugin/blob/936aed28def5f2434dbdaaa72d260aadd3f623da/jclouds-plugin/src/main/resources/jenkins/plugins/jclouds/compute/JCloudsSlaveTemplate/config.jelly#L127  
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Tomasz Wojtuń
          Path:
          jclouds-plugin/src/main/resources/jenkins/plugins/jclouds/compute/UserData/config.jelly
          jclouds-plugin/src/main/webapp/jclouds.js
          http://jenkins-ci.org/commit/jclouds-plugin/2e9fa0d1d5ef22662dd3ecd971f89c858a4d5ee4
          Log:
          workaround for JENKINS-48986

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tomasz Wojtuń Path: jclouds-plugin/src/main/resources/jenkins/plugins/jclouds/compute/UserData/config.jelly jclouds-plugin/src/main/webapp/jclouds.js http://jenkins-ci.org/commit/jclouds-plugin/2e9fa0d1d5ef22662dd3ecd971f89c858a4d5ee4 Log: workaround for JENKINS-48986
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Fritz Elfert
          Path:
          jclouds-plugin/src/main/resources/jenkins/plugins/jclouds/compute/UserData/config.jelly
          jclouds-plugin/src/main/webapp/jclouds.js
          http://jenkins-ci.org/commit/jclouds-plugin/c102b4a4b0281f6af8a19385759a2ff8e524480c
          Log:
          Merge pull request #126 from stepstone-tech/master

          workaround for JENKINS-48986

          Compare: https://github.com/jenkinsci/jclouds-plugin/compare/8d9593007465...c102b4a4b028

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Fritz Elfert Path: jclouds-plugin/src/main/resources/jenkins/plugins/jclouds/compute/UserData/config.jelly jclouds-plugin/src/main/webapp/jclouds.js http://jenkins-ci.org/commit/jclouds-plugin/c102b4a4b0281f6af8a19385759a2ff8e524480c Log: Merge pull request #126 from stepstone-tech/master workaround for JENKINS-48986 Compare: https://github.com/jenkinsci/jclouds-plugin/compare/8d9593007465...c102b4a4b028

          People

            Unassigned Unassigned
            tommywo Tomasz Wojtun
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: