Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49017

configSubmit exception with Textarea choices ended with empty line

    XMLWordPrintable

Details

    Description

      After upgrading to Jenkins 2.102 I'm getting exception on applying new job config (configSubmit), if the job contains extensible-choice Textarea parameter with choices list ending with empty line. After removing empty line - configSubmit works fine, but the next time I enter job's configuration page - empty line appears again, so I have to remove this empty line every time I modify job settings.

      java.lang.UnsupportedOperationException: Refusing to marshal java.util.RandomAccessSubList for security reasons; see https://jenkins.io/redirect/class-filter/
          at hudson.util.XStream2$BlacklistedTypesConverter.marshal(XStream2.java:530)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
          at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
          at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
          at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
      Caused: java.lang.RuntimeException: Failed to serialize jp.ikedam.jenkins.plugins.extensible_choice_parameter.TextareaChoiceListProvider#choiceList for class jp.ikedam.jenkins.plugins.extensible_choice_parameter.TextareaChoiceListProvider
          at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
          at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
          at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
          at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
          at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
          at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
          at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
          at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
      Caused: java.lang.RuntimeException: Failed to serialize jp.ikedam.jenkins.plugins.extensible_choice_parameter.ExtensibleChoiceParameterDefinition#choiceListProvider for class jp.ikedam.jenkins.plugins.extensible_choice_parameter.ExtensibleChoiceParameterDefinition
          at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
          at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
          at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
          at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
          at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
          at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
          at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88)
          at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64)
          at com.thoughtworks.xstream.converters.collections.CollectionConverter.marshal(CollectionConverter.java:74)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
          at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
          at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
          at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
      Caused: java.lang.RuntimeException: Failed to serialize hudson.model.ParametersDefinitionProperty#parameterDefinitions for class hudson.model.ParametersDefinitionProperty
          at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
          at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
          at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
          at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
          at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
          at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
          at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88)
          at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64)
          at hudson.util.CopyOnWriteList$ConverterImpl.marshal(CopyOnWriteList.java:187)
          at hudson.util.XStream2$AssociatedConverterImpl.marshal(XStream2.java:448)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
          at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
          at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
          at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
      Caused: java.lang.RuntimeException: Failed to serialize hudson.model.Job#properties for class hudson.model.FreeStyleProject
          at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
          at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
          at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
          at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
          at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
          at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
          at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
          at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
          at com.thoughtworks.xstream.core.TreeMarshaller.start(TreeMarshaller.java:82)
          at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.marshal(AbstractTreeMarshallingStrategy.java:37)
          at com.thoughtworks.xstream.XStream.marshal(XStream.java:1026)
          at com.thoughtworks.xstream.XStream.marshal(XStream.java:1015)
          at com.thoughtworks.xstream.XStream.toXML(XStream.java:988)
          at hudson.XmlFile.write(XmlFile.java:194)
      Caused: java.io.IOException
          at hudson.XmlFile.write(XmlFile.java:201)
          at hudson.model.AbstractItem.save(AbstractItem.java:483)
          at hudson.model.Job.save(Job.java:196)
          at hudson.model.AbstractProject.save(AbstractProject.java:289)
          at hudson.BulkChange.commit(BulkChange.java:98)
          at hudson.model.Job.doConfigSubmit(Job.java:1355)
          at hudson.model.AbstractProject.doConfigSubmit(AbstractProject.java:772)
          at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)
          at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:343)
          at org.kohsuke.stapler.interceptor.RequirePOST$Processor.invoke(RequirePOST.java:77)
          at org.kohsuke.stapler.PreInvokeInterceptedFunction.invoke(PreInvokeInterceptedFunction.java:26)
          at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:184)
          at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:117)
          at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:129)
          at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
          at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:715)
          at org.kohsuke.stapler.Stapler.invoke(Stapler.java:845)
          at org.kohsuke.stapler.MetaClass$5.doDispatch(MetaClass.java:248)
          at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
          at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:715)
          at org.kohsuke.stapler.Stapler.invoke(Stapler.java:845)
          at org.kohsuke.stapler.Stapler.invoke(Stapler.java:649)
          at org.kohsuke.stapler.Stapler.service(Stapler.java:238)
          at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
          at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841)
          at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1650)
          at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:154)
          at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:157)
          at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
          at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:99)
          at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
          at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
          at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
          at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
          at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:117)
          at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
          at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
          at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
          at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142)
          at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
          at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271)
          at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
          at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93)
          at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
          at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
          at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67)
          at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
          at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:90)
          at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171)
          at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
          at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49)
          at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
          at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82)
          at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
          at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30)
          at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
          at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:533)
          at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
          at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:524)
          at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
          at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:190)
          at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1595)
          at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:188)
          at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1253)
          at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:168)
          at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:473)
          at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1564)
          at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:166)
          at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1155)
          at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
          at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
          at org.eclipse.jetty.server.Server.handle(Server.java:564)
          at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:317)
          at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
          at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:279)
          at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:110)
          at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:124)
          at org.eclipse.jetty.util.thread.Invocable.invokePreferred(Invocable.java:128)
          at org.eclipse.jetty.util.thread.Invocable$InvocableExecutor.invoke(Invocable.java:222)
          at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:294)
          at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:199)
          at winstone.BoundedExecutorService$1.run(BoundedExecutorService.java:77)
          at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
          at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
          at java.lang.Thread.run(Thread.java:748)
      

      Attachments

        Issue Links

          Activity

            oleg_nenashev Oleg Nenashev added a comment -

            Makes sense to fix it on the core's side IMO

            oleg_nenashev Oleg Nenashev added a comment - Makes sense to fix it on the core's side IMO
            oleg_nenashev Oleg Nenashev added a comment -

            PCT successfully reproduces the issue. I will submit a custom patch, because I am not sure I will have time to land whitelists in 2.103

            oleg_nenashev Oleg Nenashev added a comment - PCT successfully reproduces the issue. I will submit a custom patch, because I am not sure I will have time to land whitelists in 2.103
            oleg_nenashev Oleg Nenashev added a comment -

            Created a hotfix in https://github.com/jenkinsci/extensible-choice-parameter-plugin/pull/33. Generally we may need to whitelist all sublist types in the Jenkins core. WDYT jglick?

            oleg_nenashev Oleg Nenashev added a comment - Created a hotfix in https://github.com/jenkinsci/extensible-choice-parameter-plugin/pull/33 . Generally we may need to whitelist all sublist types in the Jenkins core. WDYT jglick ?
            oleg_nenashev Oleg Nenashev added a comment - Also created https://github.com/jenkinsci/jenkins/pull/3252 for the core

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/resources/jenkins/security/whitelisted-classes.txt
            http://jenkins-ci.org/commit/jenkins/6a85f93fb7891d1e2c90ac7efdca2d8d7fa7e1d4
            Log:
            JENKINS-49017 - Whitelist java.util.Sublist and java.util.RandomAccessSublist

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/resources/jenkins/security/whitelisted-classes.txt http://jenkins-ci.org/commit/jenkins/6a85f93fb7891d1e2c90ac7efdca2d8d7fa7e1d4 Log: JENKINS-49017 - Whitelist java.util.Sublist and java.util.RandomAccessSublist

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/resources/jenkins/security/whitelisted-classes.txt
            http://jenkins-ci.org/commit/jenkins/0d1f80ba9f58d879cf562941b2d7ca2d6bb970f6
            Log:
            Merge pull request #3252 from oleg-nenashev/feature/JENKINS-49017-sublist

            JENKINS-49017 - Whitelist java.util.Sublist and java.util.RandomAccessSublist

            Compare: https://github.com/jenkinsci/jenkins/compare/4dc9fbf307f7...0d1f80ba9f58

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/resources/jenkins/security/whitelisted-classes.txt http://jenkins-ci.org/commit/jenkins/0d1f80ba9f58d879cf562941b2d7ca2d6bb970f6 Log: Merge pull request #3252 from oleg-nenashev/feature/ JENKINS-49017 -sublist JENKINS-49017 - Whitelist java.util.Sublist and java.util.RandomAccessSublist Compare: https://github.com/jenkinsci/jenkins/compare/4dc9fbf307f7...0d1f80ba9f58

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/resources/META-INF/hudson.remoting.ClassFilter
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/7e7de6edff39b82cb8d801a33a22696762050eea
            Log:
            JENKINS-49017 - Whitelist java.util.RandomAccessSublist

            This type is being returned by `ArrayList#sublist()` being used in the plugin.
            Seems to be a valid use-case.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/resources/META-INF/hudson.remoting.ClassFilter http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/7e7de6edff39b82cb8d801a33a22696762050eea Log: JENKINS-49017 - Whitelist java.util.RandomAccessSublist This type is being returned by `ArrayList#sublist()` being used in the plugin. Seems to be a valid use-case.

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/resources/META-INF/hudson.remoting.ClassFilter
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/87a4fb6200ffaf16412a6079f72f1a3f48fe3e93
            Log:
            Merge pull request #33 from oleg-nenashev/JENKINS-49017-jep-200

            JENKINS-49017 - Whitelist java.util.RandomAccessSublist to make the plugin compatible with Jenkins 2.102+

            Compare: https://github.com/jenkinsci/extensible-choice-parameter-plugin/compare/e8393e1d1987...87a4fb6200ff

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/resources/META-INF/hudson.remoting.ClassFilter http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/87a4fb6200ffaf16412a6079f72f1a3f48fe3e93 Log: Merge pull request #33 from oleg-nenashev/ JENKINS-49017 -jep-200 JENKINS-49017 - Whitelist java.util.RandomAccessSublist to make the plugin compatible with Jenkins 2.102+ Compare: https://github.com/jenkinsci/extensible-choice-parameter-plugin/compare/e8393e1d1987...87a4fb6200ff
            ikedam ikedam added a comment -

            urusha oleg_nenashev

            Merged the PR and released extensible-choice-parameter-1.4.2.
            It will be available in the update center in a day.
            Thanks for the report and the fix.

            ikedam ikedam added a comment - urusha oleg_nenashev Merged the PR and released extensible-choice-parameter-1.4.2. It will be available in the update center in a day. Thanks for the report and the fix.

            Code changed in jenkins
            User: ikedam
            Path:
            pom.xml
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchQueueDecisionHandler.java
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchRunListener.java
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/510132ee60ed0e7ee5dc1083035dccc76ab0bcbc
            Log:
            JENKINS-49017JENKINS-49210 Allow to run tests against latest cores

            • This change allows us to run "mvn test -Djenkins.version=2.102 -Djava.level=8" to test compatibility with JEP-200
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: pom.xml src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchQueueDecisionHandler.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchRunListener.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/510132ee60ed0e7ee5dc1083035dccc76ab0bcbc Log: JENKINS-49017 JENKINS-49210 Allow to run tests against latest cores This change allows us to run "mvn test -Djenkins.version=2.102 -Djava.level=8" to test compatibility with JEP-200

            Code changed in jenkins
            User: ikedam
            Path:
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProviderJenkinsTest.java
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/TextareaChoiceListProviderJenkinsTest.java
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/7c6a39bcf4069edeb71b9723052f0506135273cb
            Log:
            JENKINS-49017JENKINS-49210 Add tests to reproduce issues with JEP-200

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProviderJenkinsTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/TextareaChoiceListProviderJenkinsTest.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/7c6a39bcf4069edeb71b9723052f0506135273cb Log: JENKINS-49017 JENKINS-49210 Add tests to reproduce issues with JEP-200

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/utility/TextareaStringListUtility.java
            src/main/resources/META-INF/hudson.remoting.ClassFilter
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest.java
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/config.xml
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jobs/JobWithSublist/config.xml
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jp.ikedam.jenkins.plugins.extensible_choice_parameter.GlobalTextareaChoiceListProvider.xml
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/afa9f3236d668a427cbcb8e504b32fc59af26dfb
            Log:
            [FIXED JENKINS-49210] JENKINS-49017 Do not use RandomAccessSubList

            • As fix for JEP-200.
            • Unfortunately I have to continue to allow RandomAccessSubList for configurations save with 1.4.2-.
            • To simplify xml.
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/utility/TextareaStringListUtility.java src/main/resources/META-INF/hudson.remoting.ClassFilter src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest.java src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/config.xml src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jobs/JobWithSublist/config.xml src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jp.ikedam.jenkins.plugins.extensible_choice_parameter.GlobalTextareaChoiceListProvider.xml http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/afa9f3236d668a427cbcb8e504b32fc59af26dfb Log: [FIXED JENKINS-49210] JENKINS-49017 Do not use RandomAccessSubList As fix for JEP-200. Unfortunately I have to continue to allow RandomAccessSubList for configurations save with 1.4.2-. To simplify xml.

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/utility/TextareaStringListUtility.java
            src/main/resources/META-INF/hudson.remoting.ClassFilter
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest.java
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/config.xml
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jobs/JobWithSublist/config.xml
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jp.ikedam.jenkins.plugins.extensible_choice_parameter.GlobalTextareaChoiceListProvider.xml
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/c009a1c9b10071ca5457707491424f261dfbb4c6
            Log:
            Merge pull request #37 from ikedam/feature/JENKINS-49210_NoSublist

            JENKINS-49210 JENKINS-49017 Do not use RandomAccessSubList

            Compare: https://github.com/jenkinsci/extensible-choice-parameter-plugin/compare/584197ec252e...c009a1c9b100

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/utility/TextareaStringListUtility.java src/main/resources/META-INF/hudson.remoting.ClassFilter src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest.java src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/config.xml src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jobs/JobWithSublist/config.xml src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jp.ikedam.jenkins.plugins.extensible_choice_parameter.GlobalTextareaChoiceListProvider.xml http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/c009a1c9b10071ca5457707491424f261dfbb4c6 Log: Merge pull request #37 from ikedam/feature/ JENKINS-49210 _NoSublist JENKINS-49210 JENKINS-49017 Do not use RandomAccessSubList Compare: https://github.com/jenkinsci/extensible-choice-parameter-plugin/compare/584197ec252e...c009a1c9b100

            People

              urusha Sergey Urushkin
              urusha Sergey Urushkin
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: