Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49210

Do not use ArrayList#sublist()

XMLWordPrintable

      Improved fix for JENKINS-49017.

      Using ArrayList#sublist() results java.util.RandomAccessSubList, which causes issues with JEP-200 and complicated output of xstream.

      Create a new ArrayList simply.

          [JENKINS-49210] Do not use ArrayList#sublist()

          ikedam created issue -
          ikedam made changes -
          Link New: This issue is related to JENKINS-49017 [ JENKINS-49017 ]
          Matt Phillips made changes -
          Assignee Original: ikedam [ ikedam ] New: Matt Phillips [ mattphi ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          pom.xml
          src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchQueueDecisionHandler.java
          src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchRunListener.java
          src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java
          http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/510132ee60ed0e7ee5dc1083035dccc76ab0bcbc
          Log:
          JENKINS-49017JENKINS-49210 Allow to run tests against latest cores

          • This change allows us to run "mvn test -Djenkins.version=2.102 -Djava.level=8" to test compatibility with JEP-200

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: pom.xml src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchQueueDecisionHandler.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchRunListener.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/510132ee60ed0e7ee5dc1083035dccc76ab0bcbc Log: JENKINS-49017 JENKINS-49210 Allow to run tests against latest cores This change allows us to run "mvn test -Djenkins.version=2.102 -Djava.level=8" to test compatibility with JEP-200

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProviderJenkinsTest.java
          src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/TextareaChoiceListProviderJenkinsTest.java
          http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/7c6a39bcf4069edeb71b9723052f0506135273cb
          Log:
          JENKINS-49017JENKINS-49210 Add tests to reproduce issues with JEP-200

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProviderJenkinsTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/TextareaChoiceListProviderJenkinsTest.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/7c6a39bcf4069edeb71b9723052f0506135273cb Log: JENKINS-49017 JENKINS-49210 Add tests to reproduce issues with JEP-200
          ikedam made changes -
          Assignee Original: Matt Phillips [ mattphi ] New: ikedam [ ikedam ]
          ikedam made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          ikedam added a comment -

          https://github.com/jenkinsci/extensible-choice-parameter-plugin/pull/37

          ikedam added a comment - https://github.com/jenkinsci/extensible-choice-parameter-plugin/pull/37
          ikedam made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/utility/TextareaStringListUtility.java
          src/main/resources/META-INF/hudson.remoting.ClassFilter
          src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java
          src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest.java
          src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/config.xml
          src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jobs/JobWithSublist/config.xml
          src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jp.ikedam.jenkins.plugins.extensible_choice_parameter.GlobalTextareaChoiceListProvider.xml
          http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/afa9f3236d668a427cbcb8e504b32fc59af26dfb
          Log:
          [FIXED JENKINS-49210] JENKINS-49017 Do not use RandomAccessSubList

          • As fix for JEP-200.
          • Unfortunately I have to continue to allow RandomAccessSubList for configurations save with 1.4.2-.
          • To simplify xml.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/utility/TextareaStringListUtility.java src/main/resources/META-INF/hudson.remoting.ClassFilter src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest.java src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/config.xml src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jobs/JobWithSublist/config.xml src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/IntegrationTest/testJEP200/jp.ikedam.jenkins.plugins.extensible_choice_parameter.GlobalTextareaChoiceListProvider.xml http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/afa9f3236d668a427cbcb8e504b32fc59af26dfb Log: [FIXED JENKINS-49210] JENKINS-49017 Do not use RandomAccessSubList As fix for JEP-200. Unfortunately I have to continue to allow RandomAccessSubList for configurations save with 1.4.2-. To simplify xml.

            ikedam ikedam
            ikedam ikedam
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: