Were you using Matrix builds, or did you have any slave nodes? I'm the one who
made the change to the PerforceMailResolver. It was relying on an instance
variable that was volitile in a distributed build environment. I suspect that
it only worked when there was only one node, or perhaps it worked so long as it
was called before any distributed builds had run. I didn't see any way to fix
it while also supporting distributed matrix builds.

Isn't there a simple workaround in that you can just edit the user's information
to set the email address manually? I realize that's not ideal, but there's no
equivalent workaround for broken distributed builds, so unless someone can
figure out how to support both, I think the distributed builds are more
important than getting email addresses from perforce. I'm sure it is possible
to do both, I just didn't see how when I looked at it.

http://n4.nabble.com/PerforceMailResolver-is-broken-td395080.html

No, not using Matrix builds (yet - am considering it, but hesitant).
Yes, have some slaves. I haven't verified whether email lookup only fails on
slaves or also on Master.
As far as I recall, the email lookup used to take place at the end of the build,
when/if it was necessary in order to blame someone. But I could be wrong.

Yes, I can (and have) edit the users when this happens, which it fortunately
rarely does these days, but a fix would definitely be nice. I agree that matrix
builds are more important, though

The work-around of adding users' emails manually doesn't really work for installations with 270+ users, unfortunately.

As near as I can tell, the mail resolver was working fine before this change, though you are completely right in fixing the instance variable at the expense of this functionality.

I'll take a look at it to see if I can't get it working again, but it looks like it will be pretty complicated.

If performing a (simple) user lookup is so difficult to add in the code, then I'd be afraid to even look at it

On a serious note, there's no requirement that the user lookup is the last thing to be done, so if it's possible to perform it during checkout/polling/whenever, before any distribution takes place, then perhaps that's a working solution? The user(s) in question obviously have touched the code, so their email addresses are interesting - we might not need it on /this/ build, but we're almost certain to need it /sometime/.

Code changed in hudson
User: : rpetti
Path:
trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceMailResolver.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=24485
Log:
[FIXED JENKINS-4933] fixed perforce email resolution. It should now work normally again.

I've submitted a fix to the trunk. It appears to work fine in my tests using both a master build and a slave build, but more testing is certainly welcome.

Nice. I can only test released stuff, so I'll wait ...