Emil Wypych added a comment - 2018-02-12 12:25 Hello, rmpestano ! Could you please update me on the status of this issue? Have you already checked this?

Rafael Pestano added a comment - 2018-02-12 16:29 - edited Hi ewypych ,   I could not look into this yet, are you sure it is related to last-changes? I don't see last-changes in stacktrace. When you remove the plugin the error stops?    Also have you tried with last-changes v2.5?  (Now I see you've tested with previous versions).

Emil Wypych added a comment - 2018-02-12 17:06 Hi,  I'm sure, I have checked this. When I add the Last Changes as the post-build action (even with the simplest job, just one shell step without any parameters, but with the valid git repository), this stacktrace appears in Jenkins log. Without the Publish Last Changes, everything is ok. I know that Last Changes isn't mentioned in the stacktrace and that's why it was difficult to check which plugin cause this problem.   I've just run the docker image jenkins/jenkins:lts (2.89.3), fresh installation, default plugins + Last Changes. Created new Freestyle Job, xml: <?xml version='1.0' encoding='UTF-8'?> <project> <description></description> <keepDependencies>false</keepDependencies> <properties/> <scm class="hudson.plugins.git.GitSCM" plugin="git@3.7.0"> <configVersion>2</configVersion> <userRemoteConfigs> <hudson.plugins.git.UserRemoteConfig> <url>https://github.com/ewypych/icinga-domain-expiration-plugin.git</url> </hudson.plugins.git.UserRemoteConfig> </userRemoteConfigs> <branches> <hudson.plugins.git.BranchSpec> <name>*/master</name> </hudson.plugins.git.BranchSpec> </branches> <doGenerateSubmoduleConfigurations>false</doGenerateSubmoduleConfigurations> <submoduleCfg class="list"/> <extensions/> </scm> <canRoam>true</canRoam> <disabled>false</disabled> <blockBuildWhenDownstreamBuilding>false</blockBuildWhenDownstreamBuilding> <blockBuildWhenUpstreamBuilding>false</blockBuildWhenUpstreamBuilding> <triggers/> <concurrentBuild>false</concurrentBuild> <builders> <hudson.tasks.Shell> <command>echo &quot;test&quot;</command> </hudson.tasks.Shell> </builders> <publishers> <com.github.jenkins.lastchanges.LastChangesPublisher plugin="last-changes@2.6"> <specificRevision></specificRevision> <specificBuild></specificBuild> <since>PREVIOUS_REVISION</since> <format>LINE</format> <matching>NONE</matching> <vcsDir></vcsDir> <showFiles>true</showFiles> <synchronisedScroll>true</synchronisedScroll> <matchWordsThreshold>0.25</matchWordsThreshold> <matchingMaxComparisons>1000</matchingMaxComparisons> <isGit>false</isGit> <isSvn>false</isSvn> </com.github.jenkins.lastchanges.LastChangesPublisher> </publishers> <buildWrappers/> </project> And there is the stacktrace of the warning in the Jenkins logs: Feb 12, 2018 4:51:19 PM WARNING hudson.XmlFile replaceIfNotAtTopLevel JENKINS-45892: reference to hudson.model.FreeStyleProject@46e5a689[test-last-changes] being saved from unexpected /var/jenkins_home/jobs/test-last-changes/builds/1/build.xml java.lang.IllegalStateException at hudson.XmlFile.replaceIfNotAtTopLevel(XmlFile.java:210) at hudson.model.AbstractItem.writeReplace(AbstractItem.java:509) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.thoughtworks.xstream.converters.reflection.SerializationMethodInvoker.callWriteReplace(SerializationMethodInvoker.java:89) at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:141) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84) at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265) at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252) at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224) at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138) at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209) at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88) at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64) at com.thoughtworks.xstream.converters.collections.CollectionConverter.marshal(CollectionConverter.java:74) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84) at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265) at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252) at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224) at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138) at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209) at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88) at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64) at com.thoughtworks.xstream.converters.collections.CollectionConverter.marshal(CollectionConverter.java:74) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84) at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265) at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252) at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224) at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138) at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209) at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43) at com.thoughtworks.xstream.core.TreeMarshaller.start(TreeMarshaller.java:82) at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.marshal(AbstractTreeMarshallingStrategy.java:37) at com.thoughtworks.xstream.XStream.marshal(XStream.java:1026) at com.thoughtworks.xstream.XStream.marshal(XStream.java:1015) at com.thoughtworks.xstream.XStream.toXML(XStream.java:988) at hudson.XmlFile.write(XmlFile.java:181) at hudson.model.Run.save(Run.java:1920) at hudson.model.Run.execute(Run.java:1781) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:421) Without the Last Changes, the job doesn't generate that warning.  In the job above I used GitHub repository but in my company we use a Bitbucket on a daily basis, so we have two different providers.

Emil Wypych added a comment - 2018-02-19 12:37 rmpestano , could you please update me on the status of this issue? Thanks in advance!  

Rafael Pestano added a comment - 2018-02-19 12:56 - edited Hi Emil, thank you for all the details. I'm working on another issue (SECURITY-308) and as soon I got it fixed I will look into this one.

Emil Wypych added a comment - 2018-03-05 09:16 Hi rmpestano ! Have you finished the issue you mentioned? Could you please update me on the status of this issue or give some ETA?   Now we work on Jenkins 2.109 and issue still persists. 

Rafael Pestano added a comment - 2018-03-05 10:10 Hi, the mentioned issue is almost done so I hope to look into this one during this week. Sorry for the delay.

Emil Wypych added a comment - 2018-03-05 10:32 Ok, thanks for the update. No problem - there are more important things and I know about it, just wanted to know how estimation looks like.

Oleg Nenashev added a comment - 2018-03-11 14:37 References which can be cleaned up: https://github.com/jenkinsci/last-changes-plugin/blob/master/src/main/java/com/github/jenkins/lastchanges/LastChangesBuildAction.java#L17 https://github.com/jenkinsci/last-changes-plugin/blob/master/src/main/java/com/github/jenkins/lastchanges/LastChangesProjectAction.java#L13

Oleg Nenashev added a comment - 2018-03-11 17:12 rmpestano FYI https://github.com/jenkinsci/last-changes-plugin/commit/0cb6083a31b207099c5400e4f4a93bee8510f3a5 will not work correctly after the Jenkins restart. The class has no readResolve() resolution, so the value will be null when you save new jobs and reload them from the disk. It will cause NPEs in methods like getLastChangesBuilds(). I would actually suggest modifying getJob() to restore the field if null and then switch all the code to using this method instead of the direct field access. Your mileage may vary

Rafael Pestano added a comment - 2018-03-11 17:41 - edited Hi Oleg, Yes, this issue after restart always happened. Although no NPE is raised the list from getLastChangesBuilds comes empty and only is populated after user runs the job again. Can you point me to an example of how to implement the readResolve to restore the list form disk? Thank you!

Oleg Nenashev added a comment - 2018-03-11 18:03 rmpestano https://wiki.jenkins.io/display/JENKINS/Hint+on+retaining+backward+compatibility , but maybe you do not need that: > I would actually suggest modifying getJob() to restore the field if null and then switch all the code to using this method instead of the direct field access. Your mileage may vary

Rafael Pestano added a comment - 2018-03-12 11:33 oleg_nenashev I've looked into the "xstream" stuff and did not figured out how to "restore the field". If you want to provide a PR or point to a plugin which does that I'll be happy to fix. Meanwhile I'll create another issue for that case.

Rafael Pestano added a comment - 2018-03-12 13:02 Just created  JENKINS-50116 .

Rafael Pestano added a comment - 2018-03-12 13:03 ewypych , can you try with v2.6.1 and share the results?  

Emil Wypych added a comment - 2018-03-12 13:23 rmpestano yes, sure, I will do it today, but at evening (~9 P.M. CET). I will give you feedback when I'm done.  Thank you very much for fast release!

Emil Wypych added a comment - 2018-03-12 20:13 rmpestano I've just updated Last Changes Plugin and made some tests - I confirm that problem was solved. Now I just see SUCCESS: main build action completed: SUCCESS Tested with few different jobs. Do you need something else, or is it enough for confirmation?  Also thank you very much for resolving this issue - logs look much better.  

Rafael Pestano added a comment - 2018-03-12 20:34 Hi ewypych , that's enough, I'll close the issue. Thank you very much for reporting and testing.