• Type: New Feature
• Resolution: Unresolved
• Priority: Major
• Component/s: promoted-builds-plugin
• Labels:

  None
• Environment:

  Ubuntu 16.04
  Jenkins ver. 2.46.2 LTS
  promoted builds plugin v2.28.1

1. 

   Selection_020.png

   44 kB

   2018-02-10 03:32

2. 

   Selection_021.png

   22 kB

   2018-02-10 03:32

3. 

   Selection_022.png

   45 kB

   2018-02-10 03:32

[JENKINS-49486] Approvers field doesn't expand variable in the build

Rick Liu created issue - 2018-02-10 03:30

Rick Liu made changes - 2018-02-10 03:32

Attachment		New: Selection_020.png [ 41420 ]
Attachment		New: Selection_021.png [ 41421 ]
Attachment		New: Selection_022.png [ 41422 ]

Oleg Nenashev made changes - 2018-02-12 08:51

Issue Type

Original: Bug [ 1 ]

New: New Feature [ 2 ]

Oleg Nenashev made changes - 2018-02-12 08:51

Assignee

Original: Oleg Nenashev [ oleg_nenashev ]

Collapse comment: Oleg Nenashev added a comment - 2018-02-12 08:52

Oleg Nenashev added a comment - 2018-02-12 08:52

IMHO it is rather a new feature request, not a defect. Reason: support of properties in this field is not documented anywhere AFAICT. Please correct me if I am wrong

Expand comment: Oleg Nenashev added a comment - 2018-02-12 08:52

Oleg Nenashev added a comment - 2018-02-12 08:52 IMHO it is rather a new feature request, not a defect. Reason: support of properties in this field is not documented anywhere AFAICT. Please correct me if I am wrong

Rick Liu made changes - 2018-03-09 00:38

Comment

[ [~oleg_nenashev] Hi Oleg, If I want to develop this feature, what approach would you recommand? 1. Try to bring in Token Macro plugin's {{TokenMacro.expandAll(build, listener, approval.name)}} in File "*conditions/ManualCondition.java*" [Line118|https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java#L118], [Line140|https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java#L140] 2. Or try something similar in File "*conditions/ParameterizedSelfPromotionCondition.java*" [Line49|https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/java/hudson/plugins/promoted_builds/conditions/ParameterizedSelfPromotionCondition.java#L49] to use {{build.getBuildVariables()}} to cross-reference the variable ]

Rick Liu made changes - 2018-03-09 00:39

Comment

[ [~samsun387] test ]

Collapse comment: Rick Liu added a comment - 2018-03-27 18:30

Rick Liu added a comment - 2018-03-27 18:30

Pull-request prepared:
https://github.com/jenkinsci/promoted-builds-plugin/pull/114

Expand comment: Rick Liu added a comment - 2018-03-27 18:30

Rick Liu added a comment - 2018-03-27 18:30 Pull-request prepared: https://github.com/jenkinsci/promoted-builds-plugin/pull/114