• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • nvm-wrapper-plugin
    • irelevant
      Jenkins ver. 2.89.3
      NVM wrapper 0.1.4

      Once there is nvm installed on the machine, plugin dont inherit and dont respect NVM settings.

      Our case:

      • having NVM at /data/jenkins-misc/nvm/ (same as NVM_DIR system property targets)
      • when using and configure wrapper plugin, all data are generated at jenkins user home- in our case /var/lib/jenkins.nvm (default path)

      Problem is over at following file line (NvmWrapperUtil.java), because there is hardcoded path

      https://github.com/jenkinsci/nvm-wrapper-plugin/blob/97093d1b19467b015565512317d065dc5e752ef7/src/main/java/org/jenkinsci/plugins/nvm/NvmWrapperUtil.java#L21

      Note- because path is hardcoded, it is not possible to override it anyway

      Kindly, please, any possibility to fix this?

      We are started to having serious problem with the free space, because when *.*nvm directory is symlink-ed, than plugin also dont works.

      Thanks in advance

      • Otherwise, if there is any way to solve that, or info who and how to contact, I will appreciate

          [JENKINS-49720] NVM wrapper hard-coded path

          Tomas Salazar added a comment -

          How do you set *NVM_DIR*property ?

          Tomas Salazar added a comment - How do you set *NVM_DIR*property ?

          Pavel Novak added a comment -

          Hi Tomas,

          • it is available nvm.env file, and it is also set as a system env variable
          • it comes from nvm install script, so its defined during nvm instalation

          Pavel Novak added a comment - Hi Tomas, it is available nvm.env file, and it is also set as a system env variable it comes from nvm install script, so its defined during nvm instalation

          Tomas Salazar added a comment -

          Thank, I know what is happening working on it to fix.

          Tomas Salazar added a comment - Thank, I know what is happening working on it to fix.

          Pavel Novak added a comment -

          Thank you very much,
          I appreciate it

          Pavel Novak added a comment - Thank you very much, I appreciate it

          Pavel Novak added a comment -

          Hi Tomas,
          please, are you able to provide some approximate estimate time, when we can expect the fix implementation?

          Thanks in advance
          @atoms 

           

          Pavel Novak added a comment - Hi Tomas, please, are you able to provide some approximate estimate time, when we can expect the fix implementation? Thanks in advance @ atoms    

          Eloy Lafuente added a comment -

          Hi,

          any news here? We are facing some concurrency problem not being able to configure the NVM_DIR and making the plugin to honor it would be awesome!

          Ciao

          Eloy Lafuente added a comment - Hi, any news here? We are facing some concurrency problem not being able to configure the NVM_DIR and making the plugin to honor it would be awesome! Ciao

          Pavel Novak added a comment -

          stronk7

          Hi, not from our side, 
          we (working on RHEL) tried also to symlink the .nvm folder, but it looks like nvm wrapper cannot work with that, so it was not working as expected :/ 

          Pavel Novak added a comment - stronk7 Hi, not from our side,  we (working on RHEL) tried also to symlink the .nvm folder, but it looks like nvm wrapper cannot work with that, so it was not working as expected :/ 

          Tomas Salazar added a comment -

          Hi, I had some progress on this,  I will try to push the changes to end of the day.

          Tomas Salazar added a comment - Hi, I had some progress on this,  I will try to push the changes to end of the day.

          Tomas Salazar added a comment -

          I had published 0.0.16

          Tomas Salazar added a comment - I had published 0.0.16

          Pavel Novak added a comment -

          @atoms 

          • 0.1.6  

          Thanks, Tom.

          We will try to check that once I'll find some time

          Pavel Novak added a comment - @ atoms   0.1.6   Thanks, Tom. We will try to check that once I'll find some time

          Pavel Novak added a comment -

          Hi, 
          so I made some testing.

          I can see there appeared "Customize NVM Installation Settings", in the job configuration, under that you moved NVM Install URL and added NVM_DIR installation dir.

          • I can confirm, when we use this setting to custom path for node installations (new option), then it works, and the given value is taken
          • But, I tried to configure NVM_DIR in global variables (jenkins global config), and its NOT working

          I didn't found the way how to define it on global level,
          maybe, can you advise with this?

          Thanks in advance, 
          and anyway, thanks for fix

           

          Pavel Novak added a comment - Hi,  so I made some testing. I can see there appeared "Customize NVM Installation Settings" , in the job configuration, under that you moved  NVM Install URL and added  NVM_DIR installation dir. I can confirm, when we use this setting to custom path for node installations (new option), then it works, and the given value is taken But, I tried to configure NVM_DIR in global variables (jenkins global config), and its NOT working I didn't found the way how to define it on global level, maybe, can you advise with this? Thanks in advance,  and anyway, thanks for fix  

          Tomas Salazar added a comment -

          I forgot to put the gobal setting , I will put that in another version.

          Tomas Salazar added a comment - I forgot to put the gobal setting , I will put that in another version.

          Pavel Novak added a comment -

          Hah! 

          ok, many thanks 

          Pavel Novak added a comment - Hah!  ok, many thanks 

          Pavel Novak added a comment - - edited

          btw atoms 

          I also noticed 

          • new version of plugin installed 
          • new options on job appeared (as I confirmed above), so it means new version got installed 
          • but in plugin page, I can still see the update available of the nvm-wrapper plugin (I guess you forgot to change the version somewhere or something related to this

          Pavel Novak added a comment - - edited btw atoms   I also noticed  new version of plugin installed  new options on job appeared (as I confirmed above), so it means new version got installed  but in plugin page, I can still see the update available of the nvm-wrapper plugin (I guess you forgot to change the version somewhere or something related to this

          Tomas Salazar added a comment -

          whch version of jenkins are you using ?

          Tomas Salazar added a comment - whch version of jenkins are you using ?

          Pavel Novak added a comment - - edited

          atoms  Jenkins ver. 2.107.3 
          issue with version is noticable as well in Jenkins ver. 2.121.2

           

          Btw also two points, which were noticed, not major but 

          • there is some issue with "NVM Advanced Settings" and "Customize NVM Installation Settings" options
          • when you will tick the checkboxes, then reload the page
          • checkboxes seems like they are not checked (I am not sure what that will do if you will re-save the job)

          Pavel Novak added a comment - - edited atoms    Jenkins ver. 2.107.3   issue with version is noticable as well in  Jenkins ver. 2.121.2   Btw also two points, which were noticed, not major but  there is some issue with "NVM Advanced Settings" and "Customize NVM Installation Settings" options when you will tick the checkboxes, then reload the page checkboxes seems like they are not checked (I am not sure what that will do if you will re-save the job)

          Roman Sichnyi added a comment -
          • new version of plugin installed 
          • new options on job appeared (as I confirmed above), so it means new version got installed 
          • but in plugin page, I can still see the update available of the nvm-wrapper plugin (I guess you forgot to change the version somewhere or something related to this

           

          same here. we're on jenkins 2.121.3

          Roman Sichnyi added a comment - new version of plugin installed  new options on job appeared (as I confirmed above), so it means new version got installed  but in plugin page, I can still see the update available of the nvm-wrapper plugin (I guess you forgot to change the version somewhere or something related to this   same here. we're on jenkins 2.121.3

          Pavel Novak added a comment -

          Hi Tome, atoms
          please, can we expect update ? 

          Also, please, review the issue with versioning if possible.

           

          Thanks in advance.

          Pavel Novak added a comment - Hi Tome, atoms ,  please, can we expect update ?  Also, please, review the issue with versioning if possible.   Thanks in advance.

          Tomas Salazar added a comment - - edited

          Hi, I had worked on a new version, I'm testing it now.

          Tomas Salazar added a comment - - edited Hi, I had worked on a new version, I'm testing it now.

          Tomas Salazar added a comment -

          Resolved on 0.1.7

          Tomas Salazar added a comment - Resolved on 0.1.7

          Pavel Novak added a comment -

          atoms 

          Hi, I can see you resolved the issue, please, can you confirm also the option for global configuration is in place?

          Thanks 

          Pavel Novak added a comment - atoms   Hi, I can see you resolved the issue, please, can you confirm also the option for global configuration is in place? Thanks 

            atoms Tomas Salazar
            pavenova Pavel Novak
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: