Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49737

Extras Executable WAR should warn everybody that Java 9 is not supported

    XMLWordPrintable

Details

    Description

      Currently Jenkins does not support Java 9, but Extras Executable WAR does not warn about that: https://github.com/jenkinsci/extras-executable-war/blob/49322726d410fac8aa0b5cb7b00934e62f3b89e3/src/main/java/Main.java#L118-L138

      It would be great to add Java 9 check there and to at least print the warning. Maybe it's better to just fail fast.

      Attachments

        Issue Links

          Activity

            amit_magar Amit Magar added a comment -

            Hi Oleg,

            Thanks for your input. I made the requested changes.

            Amit

            amit_magar Amit Magar added a comment - Hi Oleg, Thanks for your input. I made the requested changes. Amit

            Code changed in jenkins
            User: Amit Jagannath Magar
            Path:
            src/main/java/Main.java
            http://jenkins-ci.org/commit/extras-executable-war/9cf9059c509ce73112d40f50269cf39d626f70c6
            Log:
            JENKINS-49737 - Issue(Print error to Java Version 9) (#14)

            • Revert "[maven-release-plugin] prepare for next development iteration"

            This reverts commit 105703afd80d7e7e106e33372c3cbdca4ce34f2d.

            • Delete org.eclipse.jdt.core.prefs

            Deleting the eclipse files

            • Delete org.eclipse.m2e.core.prefs
            • Delete .classpath
            • Delete .project

            Deleting the Eclipse File

            • Update pom.xml

            Reverting to Orignal POM.xml from source repo

            • Making Requested Changes

            Changed comparison to exact java version and changed error message

            • Removed Comment

            Removed comment

            • Fix the code to finally merge it
            • Add space to expected Java version as @batmat suggested
            • Remove extra spaces to trigger CI
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Amit Jagannath Magar Path: src/main/java/Main.java http://jenkins-ci.org/commit/extras-executable-war/9cf9059c509ce73112d40f50269cf39d626f70c6 Log: JENKINS-49737 - Issue(Print error to Java Version 9) (#14) Solving JENKINS-49737 Issue(Print error to Java Version 9) Revert " [maven-release-plugin] prepare for next development iteration" This reverts commit 105703afd80d7e7e106e33372c3cbdca4ce34f2d. Delete org.eclipse.jdt.core.prefs Deleting the eclipse files Delete org.eclipse.m2e.core.prefs Delete .classpath Delete .project Deleting the Eclipse File Update pom.xml Reverting to Orignal POM.xml from source repo Making Requested Changes Changed comparison to exact java version and changed error message Removed Comment Removed comment Fix the code to finally merge it Add space to expected Java version as @batmat suggested Remove extra spaces to trigger CI

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            war/pom.xml
            http://jenkins-ci.org/commit/jenkins/fa54b49f3281d5e0a0bf2d7c64e417a3158bd6a8
            Log:
            JENKINS-49737 - Update Extras Executable WAR to 1.38 (#3336)

            • Use the released version of Extras Executable War 1.38
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: war/pom.xml http://jenkins-ci.org/commit/jenkins/fa54b49f3281d5e0a0bf2d7c64e417a3158bd6a8 Log: JENKINS-49737 - Update Extras Executable WAR to 1.38 (#3336) JENKINS-49737 - Update Extras Executable WAR to 1.38 Use the released version of Extras Executable War 1.38
            oleg_nenashev Oleg Nenashev added a comment -

            The patch has been integrated towards 2.111

            oleg_nenashev Oleg Nenashev added a comment - The patch has been integrated towards 2.111

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            war/pom.xml
            http://jenkins-ci.org/commit/jenkins/f513419c76ab6d81f95ed66c0d90f98686783b52
            Log:
            JENKINS-49737 - Update Extras Executable WAR to 1.38 (#3336)

            • Use the released version of Extras Executable War 1.38

            (cherry picked from commit fa54b49f3281d5e0a0bf2d7c64e417a3158bd6a8)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: war/pom.xml http://jenkins-ci.org/commit/jenkins/f513419c76ab6d81f95ed66c0d90f98686783b52 Log: JENKINS-49737 - Update Extras Executable WAR to 1.38 (#3336) JENKINS-49737 - Update Extras Executable WAR to 1.38 Use the released version of Extras Executable War 1.38 (cherry picked from commit fa54b49f3281d5e0a0bf2d7c64e417a3158bd6a8)

            People

              amit_magar Amit Magar
              oleg_nenashev Oleg Nenashev
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: