Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49795

Bad serialization of ParametersAction.parameterDefinitionNames

      Splitting out of JENKINS-49573 at oleg_nenashev's request. See that issue for discussion.

          [JENKINS-49795] Bad serialization of ParametersAction.parameterDefinitionNames

          Jesse Glick created issue -
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 3312 (Web Link)" [ 20186 ]
          Jesse Glick made changes -
          Link New: This issue relates to JENKINS-49573 [ JENKINS-49573 ]
          Jesse Glick made changes -
          Labels Original: lts-candidate New: lts-candidate serialization xstream
          Jesse Glick made changes -
          Link New: This issue relates to SECURITY-170 [ SECURITY-170 ]

          Jesse Glick added a comment -

          If this is accepted for LTS backport, I would propose including only the single-line patch to ParametersAction, not the logging change to ClassFilterImpl nor the addition to ParametersAction2Test which depends on it.

          Jesse Glick added a comment - If this is accepted for LTS backport, I would propose including only the single-line patch to ParametersAction , not the logging change to ClassFilterImpl nor the addition to ParametersAction2Test which depends on it.

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/model/ParametersAction.java
          core/src/main/java/jenkins/security/ClassFilterImpl.java
          test/src/test/java/hudson/model/ParametersAction2Test.java
          http://jenkins-ci.org/commit/jenkins/29f146c7c2861fc50522f2bfe183fcaef06713c7
          Log:
          Merge pull request #3312 from jglick/inner-madness-JENKINS-49573

          JENKINS-49795 Fix bad serialization of ParametersAction.parameterDefinitionNames and make sure this kind of mistake produces a warning in the future

          Compare: https://github.com/jenkinsci/jenkins/compare/852ecdc5f2a7...29f146c7c286

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/ParametersAction.java core/src/main/java/jenkins/security/ClassFilterImpl.java test/src/test/java/hudson/model/ParametersAction2Test.java http://jenkins-ci.org/commit/jenkins/29f146c7c2861fc50522f2bfe183fcaef06713c7 Log: Merge pull request #3312 from jglick/inner-madness- JENKINS-49573 JENKINS-49795 Fix bad serialization of ParametersAction.parameterDefinitionNames and make sure this kind of mistake produces a warning in the future Compare: https://github.com/jenkinsci/jenkins/compare/852ecdc5f2a7...29f146c7c286

          Oleg Nenashev added a comment -

          The fix has been integrated towards 2.110

          Oleg Nenashev added a comment - The fix has been integrated towards 2.110
          Oleg Nenashev made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: