Details
-
Type:
Improvement
-
Status: Resolved (View Workflow)
-
Priority:
Minor
-
Resolution: Done
-
Component/s: blueocean-acceptance-test
-
Labels:None
-
Similar Issues:
-
Epic Link:
Description
Summary:
Making changes to build agent settings in a Jenkinsfile is an important feature available in the editor, but none of our existing tests cover this path. A simple ATH test (or even an addition to another, existing test) would be a nice coverage improvement.
Ideas:
An offline test could create a repository including an existing Jenkinsfile, stored in our resources directory, like we're doing here. This existing Jenkinsfile might include something like:
agent { label ("linux") }
which we could then use the editor to change into
agent any
And then verify that the changes were made correctly.
Attachments
Activity
Field | Original Value | New Value |
---|---|---|
Description |
*Summary:* Making changes to build agent settings in a Jenkinsfile is an important feature available in the editor, but none of our existing tests cover this path. A simple ATH test (or even an addition to another, existing test) would be a nice coverage improement. *Ideas:* An offline test could create a repository including an existing Jenkinsfile, stored in [our resources directory|https://github.com/jenkinsci/blueocean-plugin/tree/master/acceptance-tests/src/test/resources/io/blueocean/ath/offline], like we're doing [here|https://github.com/jenkinsci/blueocean-plugin/tree/master/acceptance-tests/src/test/resources/io/blueocean/ath/offline/multibranch/ParallelNavigationTest]. This existing Jenkinsfile might include something like: {code:none} agent { label ("linux") } {code} which we could then use the editor to change into {code:none} agent any {code} And then verify that the changes were made correctly. |
*Summary:* Making changes to build agent settings in a Jenkinsfile is an important feature available in the editor, but none of our existing tests cover this path. A simple ATH test (or even an addition to another, existing test) would be a nice coverage improvement. *Ideas:* An offline test could create a repository including an existing Jenkinsfile, stored in [our resources directory|https://github.com/jenkinsci/blueocean-plugin/tree/master/acceptance-tests/src/test/resources/io/blueocean/ath/offline], like we're doing [here|https://github.com/jenkinsci/blueocean-plugin/tree/master/acceptance-tests/src/test/resources/io/blueocean/ath/offline/multibranch/ParallelNavigationTest]. This existing Jenkinsfile might include something like: {code:none} agent { label ("linux") } {code} which we could then use the editor to change into {code:none} agent any {code} And then verify that the changes were made correctly. |
Epic Link | JENKINS-36178 [ 172150 ] |
Assignee | Karl Shultz [ kshultz ] |
Status | Open [ 1 ] | In Progress [ 3 ] |
Status | In Progress [ 3 ] | In Review [ 10005 ] |
Resolution | Done [ 10000 ] | |
Status | In Review [ 10005 ] | Resolved [ 5 ] |
Component/s | blueocean-acceptance-test [ 23731 ] | |
Component/s | blueocean-pipeline-editor-plugin [ 21828 ] |
PR up.