Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49928

Add editor ATH coverage for changing agent settings in a Jenkinsfile

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Summary:
      Making changes to build agent settings in a Jenkinsfile is an important feature available in the editor, but none of our existing tests cover this path. A simple ATH test (or even an addition to another, existing test) would be a nice coverage improvement.

      Ideas:
      An offline test could create a repository including an existing Jenkinsfile, stored in our resources directory, like we're doing here. This existing Jenkinsfile might include something like:

      agent {
          label ("linux")
      }
      

      which we could then use the editor to change into

      agent any
      

      And then verify that the changes were made correctly.

        Attachments

          Activity

          kshultz Karl Shultz created issue -
          kshultz Karl Shultz made changes -
          Field Original Value New Value
          Description *Summary:*
          Making changes to build agent settings in a Jenkinsfile is an important feature available in the editor, but none of our existing tests cover this path. A simple ATH test (or even an addition to another, existing test) would be a nice coverage improement.

          *Ideas:*
          An offline test could create a repository including an existing Jenkinsfile, stored in [our resources directory|https://github.com/jenkinsci/blueocean-plugin/tree/master/acceptance-tests/src/test/resources/io/blueocean/ath/offline], like we're doing [here|https://github.com/jenkinsci/blueocean-plugin/tree/master/acceptance-tests/src/test/resources/io/blueocean/ath/offline/multibranch/ParallelNavigationTest]. This existing Jenkinsfile might include something like:
          {code:none}
          agent {
              label ("linux")
          }
          {code}
          which we could then use the editor to change into
          {code:none}
          agent any
          {code}
          And then verify that the changes were made correctly.
          *Summary:*
          Making changes to build agent settings in a Jenkinsfile is an important feature available in the editor, but none of our existing tests cover this path. A simple ATH test (or even an addition to another, existing test) would be a nice coverage improvement.

          *Ideas:*
          An offline test could create a repository including an existing Jenkinsfile, stored in [our resources directory|https://github.com/jenkinsci/blueocean-plugin/tree/master/acceptance-tests/src/test/resources/io/blueocean/ath/offline], like we're doing [here|https://github.com/jenkinsci/blueocean-plugin/tree/master/acceptance-tests/src/test/resources/io/blueocean/ath/offline/multibranch/ParallelNavigationTest]. This existing Jenkinsfile might include something like:
          {code:none}
          agent {
              label ("linux")
          }
          {code}
          which we could then use the editor to change into
          {code:none}
          agent any
          {code}
          And then verify that the changes were made correctly.
          kshultz Karl Shultz made changes -
          Epic Link JENKINS-36178 [ 172150 ]
          kshultz Karl Shultz made changes -
          Assignee Karl Shultz [ kshultz ]
          kshultz Karl Shultz made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          kshultz Karl Shultz added a comment -
          Show
          kshultz Karl Shultz added a comment - PR up .
          kshultz Karl Shultz made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          Hide
          kshultz Karl Shultz added a comment -
          Show
          kshultz Karl Shultz added a comment - Merged 1716 .
          kshultz Karl Shultz made changes -
          Resolution Done [ 10000 ]
          Status In Review [ 10005 ] Resolved [ 5 ]
          kshultz Karl Shultz made changes -
          Component/s blueocean-acceptance-test [ 23731 ]
          Component/s blueocean-pipeline-editor-plugin [ 21828 ]

            People

            Assignee:
            kshultz Karl Shultz
            Reporter:
            kshultz Karl Shultz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: