Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49987

Cleanup anonymous class usages for Remoting in Jenkins Core, Remoting and Modules

    • Cleanup anonymous class usages for Remoting in Jenkins Core, Remoting and Modules
    • Remoting 3.28

      After adding extra diagnostics for cases like JENKINS-49795, there will be warning reports about anonymous classes being serialized over Remoting. Somebody needs to cleanup these usages.

      Examples:

          [JENKINS-49987] Cleanup anonymous class usages for Remoting in Jenkins Core, Remoting and Modules

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Link New: This issue relates to JENKINS-49795 [ JENKINS-49795 ]
          Oleg Nenashev made changes -
          Description New: After adding extra diagnostics for cases like JENKINS-49795, there will be warning reports about anonymous classes being serialized over Remoting. Somebody needs to cleanup these usages.

          Examples:

          * https://github.com/jenkinsci/jenkins/search?utf8=%E2%9C%93&q=%22new+MasterToSlaveCallable%22&type=
          * https://github.com/jenkinsci/remoting/blob/9b8fd56e780f0c042c8ac35333e87faba8c5f81f/src/main/java/hudson/remoting/forward/PortForwarder.java#L135
          * ...
          Oleg Nenashev made changes -
          Assignee Original: Oleg Nenashev [ oleg_nenashev ]
          Oleg Nenashev made changes -
          Labels New: diagnostics serialization
          Jesse Glick made changes -
          Epic Child New: JENKINS-49994 [ 188991 ]
          Jesse Glick made changes -
          Comment [ Note that currently the diagnostic lives in {{ClassFilterImpl}} in core, so it will apply to all XStream usages, but only to _inbound_ Remoting commands. Probably it should be moved to {{ClassFilter.STANDARD}} so that we would find instances of the much more common case of _outbound_ Remoting callables using anonymous inner classes. ]
          Jeff Thompson made changes -
          Assignee New: Jeff Thompson [ jthompson ]

          Jeff Thompson added a comment -

          This will be picked up by a Jenkins weekly build soon.

          Jeff Thompson added a comment - This will be picked up by a Jenkins weekly build soon.
          Jeff Thompson made changes -
          Released As New: Remoting 3.28
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

            jthompson Jeff Thompson
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: