Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50057

email-ext: Unable to unset triggers

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • email-ext-plugin
    • None
    • Client:
        MacOS 10.13.3
        Chrome Version 64.0.3282.186
        Safari Version 11.0.3
      Server:
        Ubuntu 16.04
        Jenkins 2.89.4
        email-ext 2.61
    • 2.73

      I am unable to unset ext-email triggers form the Manage Jenkins > configuration page. If I click on a checked trigger the checkmark is removed. I then press the apply button, it flashes a "saved" message, then I press save, which takes me back to the Jenkins home page. However, when I return to the Manage Jenkins > configuration page the triggers that I tried to unset are again checked. 

      When the apply button is pressed it seems to work as expected, however there are no entries in the JSON for any of the triggers. If I were to take an educated guess the action of unchecking the checkbox is not behaving as expected, therefore the javascript collecting the form data does not consider the triggers changed. Now, the opposite is not true, if I set a previously unset trigger it behaves as expected.

      I am also receiving javascript errors in the console upon page load; screen shot included below.

        1. Screen Shot 2018-03-08 at 11.35.33 AM.png
          Screen Shot 2018-03-08 at 11.35.33 AM.png
          128 kB
        2. jenkins-config-behavior.mov
          8.92 MB

          [JENKINS-50057] email-ext: Unable to unset triggers

          Bryon Bean created issue -
          Bryon Bean made changes -
          Summary Original: Unable to unset triggers New: email-ext: Unable to unset triggers
          Oleg Nenashev made changes -
          Assignee Original: R. Tyler Croy [ rtyler ]

          Oleg Nenashev added a comment -

          It has nothing to do with INFRA, moving the ticket

          Oleg Nenashev added a comment - It has nothing to do with INFRA, moving the ticket
          Oleg Nenashev made changes -
          Component/s New: email-ext-plugin [ 15538 ]
          Component/s Original: core [ 21134 ]
          Key Original: INFRA-1528 New: JENKINS-50057
          Workflow Original: classic default workflow [ 226424 ] New: JNJira + In-Review [ 226468 ]
          Project Original: Infrastructure [ 10301 ] New: Jenkins [ 10172 ]
          Alex Earl made changes -
          Assignee New: Alex Earl [ slide_o_mix ]

          Alex Earl added a comment -

          I verified that if you uncheck ALL default triggers, then update will occur. Basically this is to avoid people shooting themselves in the foot and complaining that no email triggers are setup by default. Generally, the behavior is that if there are no default triggers defined then at least the "Failure - Any" trigger is added by default. This was the historical behavior of the plugin. Would this be acceptable? Basically, if you uncheck everything, it will set "Failure - Any" as selected?

          Alex Earl added a comment - I verified that if you uncheck ALL default triggers, then update will occur. Basically this is to avoid people shooting themselves in the foot and complaining that no email triggers are setup by default. Generally, the behavior is that if there are no default triggers defined then at least the "Failure - Any" trigger is added by default. This was the historical behavior of the plugin. Would this be acceptable? Basically, if you uncheck everything, it will set "Failure - Any" as selected?

          Alex Earl added a comment -

          Updates for JCasC also helped fix this type of issue.

          Alex Earl added a comment - Updates for JCasC also helped fix this type of issue.
          Alex Earl made changes -
          Released As New: 2.73
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

            slide_o_mix Alex Earl
            bryonbean Bryon Bean
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: