Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50216

Google Auth Plugin is incompatible with Jenkins 2.102+

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      11:53:59 FATAL: Could not call com.google.jenkins.plugins.source.GoogleRobotUsernamePassword.writeObject() : Failed to serialize com.google.jenkins.plugins.source.GoogleRobotUsernamePasswordModule$ForRemote#credentials for class com.google.jenkins.plugins.source.GoogleRobotUsernamePasswordModule$ForRemote
      11:53:59 ---- Debugging information ----
      11:53:59 message             : Could not call com.google.jenkins.plugins.source.GoogleRobotUsernamePassword.writeObject()
      11:53:59 cause-exception     : java.lang.RuntimeException
      11:53:59 cause-message       : Failed to serialize com.google.jenkins.plugins.source.GoogleRobotUsernamePasswordModule$ForRemote#credentials for class com.google.jenkins.plugins.source.GoogleRobotUsernamePasswordModule$ForRemote
      11:53:59 -------------------------------
      11:53:59 java.lang.UnsupportedOperationException: Refusing to marshal org.joda.time.chrono.ISOChronology$Stub for security reasons; see https://jenkins.io/redirect/class-filter/
      11:53:59 	at hudson.util.XStream2$BlacklistedTypesConverter.marshal(XStream2.java:543)
      11:53:59 	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
      11:53:59 	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
      11:53:59 	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
      11:53:59 	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88)
      11:53:59 	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.marshal(AbstractReflectionConverter.java:81)
      11:53:59 	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
      11:53:59 	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
      11:53:59 	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
      11:53:59 	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
      11:53:59 	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
      11:53:59 Caused: java.lang.RuntimeException: Failed to serialize org.joda.time.base.BaseDateTime#iChronology for class org.joda.time.DateTime
      11:53:59 	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
      11:53:59 	at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
      11:53:59 	at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
      11:53:59 	at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
      11:53:59 	at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
      11:53:59 	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
      11:53:59 	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
      11:53:59 	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
      11:53:59 	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
      11:53:59 	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
      11:53:59 Caused: java.lang.RuntimeException: Failed to serialize com.google.jenkins.plugins.credentials.oauth.RemotableGoogleCredentials#expiration for class com.google.jenkins.plugins.credentials.oauth.RemotableGoogleCredentials
      11:53:59 	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
      11:53:59 	at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
      11:53:59 	at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
      11:53:59 	at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
      11:53:59 	at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
      11:53:59 	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
      11:53:59 	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
      11:53:59 	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
      11:53:59 	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
      11:53:59 	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
      11:53:59 Caused: java.lang.RuntimeException: Failed to serialize com.google.jenkins.plugins.source.GoogleRobotUsernamePasswordModule$ForRemote#credentials for class com.google.jenkins.plugins.source.GoogleRobotUsernamePasswordModule$ForRemote
      11:53:59 	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
      11:53:59 	at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
      11:53:59 	at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
      11:53:59 	at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
      11:53:59 	at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
      11:53:59 	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
      11:53:59 	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
      11:53:59 	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
      11:53:59 	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88)
      11:53:59 	at com.thoughtworks.xstream.converters.reflection.SerializableConverter$1.writeToStream(SerializableConverter.java:140)
      11:53:59 	at com.thoughtworks.xstream.core.util.CustomObjectOutputStream.writeObjectOverride(CustomObjectOutputStream.java:84)
      11:53:59 	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:344)
      11:53:59 	at com.google.jenkins.plugins.source.GoogleRobotUsernamePassword.writeObject(GoogleRobotUsernamePassword.java:165)
      11:53:59 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      11:53:59 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      11:53:59 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      11:53:59 	at java.lang.reflect.Method.invoke(Method.java:498)
      11:53:59 	at com.thoughtworks.xstream.converters.reflection.SerializationMethodInvoker.callWriteObject(SerializationMethodInvoker.java:135)
      11:53:59 Caused: com.thoughtworks.xstream.converters.ConversionException: Could not call com.google.jenkins.plugins.source.GoogleRobotUsernamePassword.writeObject() : Failed to serialize com.google.jenkins.plugins.source.GoogleRobotUsernamePasswordModule$ForRemote#credentials for class com.google.jenkins.plugins.source.GoogleRobotUsernamePasswordModule$ForRemote
      11:53:59 ---- Debugging information ----
      11:53:59 message             : Could not call com.google.jenkins.plugins.source.GoogleRobotUsernamePassword.writeObject()
      11:53:59 cause-exception     : java.lang.RuntimeException
      11:53:59 cause-message       : Failed to serialize com.google.jenkins.plugins.source.GoogleRobotUsernamePasswordModule$ForRemote#credentials for class com.google.jenkins.plugins.source.GoogleRobotUsernamePasswordModule$ForRemote
      11:53:59 -------------------------------
      11:53:59 	at com.thoughtworks.xstream.converters.reflection.SerializationMethodInvoker.callWriteObject(SerializationMethodInvoker.java:141)
      11:53:59 	at com.thoughtworks.xstream.converters.reflection.SerializableConverter.doMarshal(SerializableConverter.java:259)
      11:53:59 	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.marshal(AbstractReflectionConverter.java:83)
      11:53:59 	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
      11:53:59 	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
      11:53:59 	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
      11:53:59 	at com.thoughtworks.xstream.core.TreeMarshaller.start(TreeMarshaller.java:82)
      11:53:59 	at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.marshal(AbstractTreeMarshallingStrategy.java:37)
      11:53:59 	at com.thoughtworks.xstream.XStream.marshal(XStream.java:1026)
      11:53:59 	at com.thoughtworks.xstream.XStream.marshal(XStream.java:1015)
      11:53:59 	at com.thoughtworks.xstream.XStream.toXML(XStream.java:988)
      11:53:59 	at com.cloudbees.plugins.credentials.CredentialsProvider.getOrCreateFingerprintOf(CredentialsProvider.java:1399)
      11:53:59 	at com.cloudbees.plugins.credentials.CredentialsProvider.trackAll(CredentialsProvider.java:1457)
      11:53:59 	at com.cloudbees.plugins.credentials.CredentialsProvider.track(CredentialsProvider.java:1421)
      11:53:59 	at hudson.plugins.git.GitSCM.createClient(GitSCM.java:818)
      11:53:59 	at hudson.plugins.git.GitSCM.createClient(GitSCM.java:786)
      11:53:59 	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1154)
      11:53:59 	at hudson.scm.SCM.checkout(SCM.java:504)
      11:53:59 	at hudson.model.AbstractProject.checkout(AbstractProject.java:1203)
      11:53:59 	at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
      11:53:59 	at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
      11:53:59 	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
      11:53:59 	at hudson.model.Run.execute(Run.java:1727)
      11:53:59 	at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
      11:53:59 	at hudson.model.ResourceController.execute(ResourceController.java:97)
      11:53:59 	at hudson.model.Executor.run(Executor.java:429)
      

        Attachments

          Activity

          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          This is https://github.com/jenkinsci/google-source-plugin, not a Google Code. Component is missing due to whatever reason

          Show
          oleg_nenashev Oleg Nenashev added a comment - This is https://github.com/jenkinsci/google-source-plugin , not a Google Code. Component is missing due to whatever reason
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          https://plugins.jenkins.io/google-source-plugin says that the plugin has about 500 installations.
          The plugin is seriously outdated and it has no tests which would allow to confirm the fix.

          @astroilov @gunan @tcnghia If we propose a fix, will you be able to review/release it?

          Show
          oleg_nenashev Oleg Nenashev added a comment - https://plugins.jenkins.io/google-source-plugin says that the plugin has about 500 installations. The plugin is seriously outdated and it has no tests which would allow to confirm the fix. @astroilov @gunan @tcnghia If we propose a fix, will you be able to review/release it?
          Show
          oleg_nenashev Oleg Nenashev added a comment - Andrey Stroilov Gunhan Gulsoy Nghia Tran
          Hide
          jglick Jesse Glick added a comment -

          If it is really attempting to serialize Joda Time types to an XML file, that sounds like a mistake. Prefer to save a plain string in ISO time format or something like that.

          Show
          jglick Jesse Glick added a comment - If it is really attempting to serialize Joda Time types to an XML file, that sounds like a mistake. Prefer to save a plain string in ISO time format or something like that.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          So it is actually a Google OAuth Credentials plugin issue (3000) installs.
          In order to apply a whitelist workaround, one needs to whitelist...

          • org.joda.time.DateTime
          • org.joda.time.base.BaseDateTime
          • org.joda.time.base.AbstractDateTime
          • org.joda.time.base.AbstractInstant
          • org.joda.time.Chronology
          • all implementations of org.joda.time.Chronology which may be actually used in the system (~15 of them in JodaTime directly)

          The field under concern is "private final DateTime expiration;" within RemotableGoogleCredentials. Although the logic can be easily reworked to serialize "lifetimeSeconds" instead, we have an issue with the already persisted data on the disk. Dropping the expiration settings is not something fine IMO, we will need a better migration logic

          Jesse Glick it seems we will need to write a custom XStream deserializer here

          Show
          oleg_nenashev Oleg Nenashev added a comment - So it is actually a Google OAuth Credentials plugin issue (3000) installs. In order to apply a whitelist workaround, one needs to whitelist... org.joda.time.DateTime org.joda.time.base.BaseDateTime org.joda.time.base.AbstractDateTime org.joda.time.base.AbstractInstant org.joda.time.Chronology all implementations of org.joda.time.Chronology which may be actually used in the system (~15 of them in JodaTime directly) The field under concern is "private final DateTime expiration;" within RemotableGoogleCredentials. Although the logic can be easily reworked to serialize "lifetimeSeconds" instead, we have an issue with the already persisted data on the disk. Dropping the expiration settings is not something fine IMO, we will need a better migration logic Jesse Glick it seems we will need to write a custom XStream deserializer here
          Hide
          jglick Jesse Glick added a comment - - edited

          Yes, you could make a static nested class called ConverterImpl which translates an old format to a new. The question is whether anyone really understands what the old format was. Judging by the comment above, it could be a complete mess. TBD.

          (If this expiration field is not super valuable, maybe it could just be reset to one month into the future or something like that?)

          Show
          jglick Jesse Glick added a comment - - edited Yes, you could make a static nested class called ConverterImpl which translates an old format to a new. The question is whether anyone really understands what the old format was. Judging by the comment above, it could be a complete mess. TBD. (If this expiration field is not super valuable, maybe it could just be reset to one month into the future or something like that?)
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          I have submitted plugin facelift patches: https://github.com/jenkinsci/google-source-plugin/pull/6 and https://github.com/jenkinsci/google-oauth-plugin/pull/15 , which enable PCT for the plugins.

          This is what I can do now. https://github.com/jenkinsci/google-oauth-plugin/blob/master/CONTRIBUTING.md explicitly requires signing a Contributor License Agreement (https://cla.developers.google.com/), which I would need to confirm with my employer. Before we spend time on that (it may require weeks to get the CLA approved), I would like to get confirmation from the maintainers that the change will be reviewed and released. If we need an expedited fix, somebody else may need to do it.

          Show
          oleg_nenashev Oleg Nenashev added a comment - I have submitted plugin facelift patches: https://github.com/jenkinsci/google-source-plugin/pull/6 and https://github.com/jenkinsci/google-oauth-plugin/pull/15 , which enable PCT for the plugins. This is what I can do now. https://github.com/jenkinsci/google-oauth-plugin/blob/master/CONTRIBUTING.md explicitly requires signing a Contributor License Agreement ( https://cla.developers.google.com/ ), which I would need to confirm with my employer. Before we spend time on that (it may require weeks to get the CLA approved), I would like to get confirmation from the maintainers that the change will be reviewed and released. If we need an expedited fix, somebody else may need to do it.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -
          Show
          oleg_nenashev Oleg Nenashev added a comment - Andrey Stroilov Gunhan Gulsoy Nghia Tran gentle ping
          Hide
          astroilov Andrey Stroilov added a comment -

          I'd be happy to review and release a fix once the CLA is approved.

          Show
          astroilov Andrey Stroilov added a comment - I'd be happy to review and release a fix once the CLA is approved.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          I have got a response from plugin maintainers regarding this issue. They are ready to help with reviews, and CLA is not longer required according to them. So I have created https://github.com/jenkinsci/google-oauth-plugin/pull/16. Once it is merged, we can proceed with the fix (if prioritized)

          Show
          oleg_nenashev Oleg Nenashev added a comment - I have got a response from plugin maintainers regarding this issue. They are ready to help with reviews, and CLA is not longer required according to them. So I have created https://github.com/jenkinsci/google-oauth-plugin/pull/16 . Once it is merged, we can proceed with the fix (if prioritized)
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          I am still blocked by CLA, but I will update the pull request to contain a fix

          Show
          oleg_nenashev Oleg Nenashev added a comment - I am still blocked by CLA, but I will update the pull request to contain a fix
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          So the example XML format is...

            <expiration>
              <iMillis>1523889095013</iMillis>
              <iChronology class="org.joda.time.chrono.ISOChronology" resolves-to="org.joda.time.chrono.ISOChronology$Stub" serialization="custom">
                <org.joda.time.chrono.ISOChronology_-Stub>
                  <org.joda.time.tz.CachedDateTimeZone resolves-to="org.joda.time.DateTimeZone$Stub" serialization="custom">
                    <org.joda.time.DateTimeZone_-Stub>
                      <string>Europe/Zurich</string>
                    </org.joda.time.DateTimeZone_-Stub>
                  </org.joda.time.tz.CachedDateTimeZone>
                </org.joda.time.chrono.ISOChronology_-Stub>
              </iChronology>
            </expiration>
          

          I can probably apply an XStream converter to that

          Show
          oleg_nenashev Oleg Nenashev added a comment - So the example XML format is... <expiration> <iMillis> 1523889095013 </iMillis> <iChronology class= "org.joda.time.chrono.ISOChronology" resolves-to= "org.joda.time.chrono.ISOChronology$Stub" serialization= "custom" > <org.joda.time.chrono.ISOChronology_-Stub> <org.joda.time.tz.CachedDateTimeZone resolves-to= "org.joda.time.DateTimeZone$Stub" serialization= "custom" > <org.joda.time.DateTimeZone_-Stub> <string> Europe/Zurich </string> </org.joda.time.DateTimeZone_-Stub> </org.joda.time.tz.CachedDateTimeZone> </org.joda.time.chrono.ISOChronology_-Stub> </iChronology> </expiration> I can probably apply an XStream converter to that
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          I have created a fix proposal in https://github.com/jenkinsci/google-oauth-plugin/pull/15, needs reviews

          Show
          oleg_nenashev Oleg Nenashev added a comment - I have created a fix proposal in https://github.com/jenkinsci/google-oauth-plugin/pull/15 , needs reviews
          Show
          oleg_nenashev Oleg Nenashev added a comment - According to https://issues.jenkins-ci.org/browse/JENKINS-50899?focusedCommentId=335821&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-335821 , my fix likely does not work as expected
          Hide
          jglick Jesse Glick added a comment -

          AFAICT this has been misdiagnosed. The errors are indeed coming from XStream, but not as part of persisted settings like you might think. Rather, the stack traces here and in the duplicate all come from CredentialsProvider.getOrCreateFingerprintOf, which uses XStream merely to get a hash to identify credentials. Thus, changing the serial format from one plugin release to another just means that existing fingerprints will no longer match—as if anyone cares.

          RemotableGoogleCredentials is explicitly documented as an ephemeral object to be passed over Remoting. Therefore, there is no compatibility concern about its serial form—we can pick anything.

          Show
          jglick Jesse Glick added a comment - AFAICT this has been misdiagnosed. The errors are indeed coming from XStream, but not as part of persisted settings like you might think. Rather, the stack traces here and in the duplicate all come from CredentialsProvider.getOrCreateFingerprintOf , which uses XStream merely to get a hash to identify credentials. Thus, changing the serial format from one plugin release to another just means that existing fingerprints will no longer match—as if anyone cares. RemotableGoogleCredentials is explicitly documented as an ephemeral object to be passed over Remoting. Therefore, there is no compatibility concern about its serial form—we can pick anything.
          Hide
          jglick Jesse Glick added a comment -

          Filed a simpler revision: PR 17.

          Show
          jglick Jesse Glick added a comment - Filed a simpler revision: PR 17.
          Hide
          jglick Jesse Glick added a comment -

          I suspect that the compatibility impact on even the unimportant fingerprint issue is zero: from what I can tell, the fingerprints were hashing based on an expiration timestamp which is different every time the credentials are used, so it would never have matched to begin with. Since the problematic class is supposed to be ephemeral and apparently for Remoting only, this indicates a design flaw in the plugin. Perhaps it needed to implement CredentialsSnapshotTaker rather than rolling its own GoogleRobotCredentials.forRemote.

          Show
          jglick Jesse Glick added a comment - I suspect that the compatibility impact on even the unimportant fingerprint issue is zero: from what I can tell, the fingerprints were hashing based on an expiration timestamp which is different every time the credentials are used, so it would never have matched to begin with. Since the problematic class is supposed to be ephemeral and apparently for Remoting only, this indicates a design flaw in the plugin. Perhaps it needed to implement CredentialsSnapshotTaker rather than rolling its own GoogleRobotCredentials.forRemote .
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentials.java
          src/main/java/com/google/jenkins/plugins/util/JodaDateTimeConverter.java
          src/test/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentialsIntegrationTest.java
          src/test/resources/com/google/jenkins/plugins/credentials/oauth/jodaDateTimeBroken.xml
          src/test/resources/com/google/jenkins/plugins/credentials/oauth/jodaDateTimeXML.xml
          http://jenkins-ci.org/commit/google-oauth-plugin/c47f47226c036b6f25d252877a34e68a0b1af99e
          Log:
          JENKINS-50216 - Introduce a custom serializer for org.joda.time.DateTime

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentials.java src/main/java/com/google/jenkins/plugins/util/JodaDateTimeConverter.java src/test/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentialsIntegrationTest.java src/test/resources/com/google/jenkins/plugins/credentials/oauth/jodaDateTimeBroken.xml src/test/resources/com/google/jenkins/plugins/credentials/oauth/jodaDateTimeXML.xml http://jenkins-ci.org/commit/google-oauth-plugin/c47f47226c036b6f25d252877a34e68a0b1af99e Log: JENKINS-50216 - Introduce a custom serializer for org.joda.time.DateTime
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          Jenkinsfile
          pom.xml
          http://jenkins-ci.org/commit/google-oauth-plugin/5e0448e8d183f26aaf056a79aa11129e73bb3329
          Log:
          JENKINS-50216 - Add Jenkinsfile to verify JEP-200 regressions

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: Jenkinsfile pom.xml http://jenkins-ci.org/commit/google-oauth-plugin/5e0448e8d183f26aaf056a79aa11129e73bb3329 Log: JENKINS-50216 - Add Jenkinsfile to verify JEP-200 regressions
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/google-oauth-plugin/51fb71acab97b80be2b1cc27aae19d9203a09a09
          Log:
          JENKINS-50216 - Add BouncyCastle API dependency to enable tests against 2.107.2

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/google-oauth-plugin/51fb71acab97b80be2b1cc27aae19d9203a09a09 Log: JENKINS-50216 - Add BouncyCastle API dependency to enable tests against 2.107.2
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentials.java
          src/main/java/com/google/jenkins/plugins/util/JodaDateTimeConverter.java
          src/test/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentialsIntegrationTest.java
          http://jenkins-ci.org/commit/google-oauth-plugin/bb9c2cc5ca5940b2043ee35bf6afb3ac3c7c68af
          Log:
          JENKINS-50216 - Cleanup codestyle and re-enable Checkstyle

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentials.java src/main/java/com/google/jenkins/plugins/util/JodaDateTimeConverter.java src/test/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentialsIntegrationTest.java http://jenkins-ci.org/commit/google-oauth-plugin/bb9c2cc5ca5940b2043ee35bf6afb3ac3c7c68af Log: JENKINS-50216 - Cleanup codestyle and re-enable Checkstyle
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/google/jenkins/plugins/util/JodaDateTimeConverter.java
          src/test/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentialsIntegrationTest.java
          src/test/resources/com/google/jenkins/plugins/credentials/oauth/jodaDateTimeNull.xml
          http://jenkins-ci.org/commit/google-oauth-plugin/dbdef9b760d3c1d21be7d8199022b1bae60864e0
          Log:
          JENKINS-50216 - Joda DateTime converter now has higher priority than JEP-200 blacklist

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/google/jenkins/plugins/util/JodaDateTimeConverter.java src/test/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentialsIntegrationTest.java src/test/resources/com/google/jenkins/plugins/credentials/oauth/jodaDateTimeNull.xml http://jenkins-ci.org/commit/google-oauth-plugin/dbdef9b760d3c1d21be7d8199022b1bae60864e0 Log: JENKINS-50216 - Joda DateTime converter now has higher priority than JEP-200 blacklist
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/google/jenkins/plugins/util/JodaDateTimeConverter.java
          src/main/resources/META-INF/hudson.remoting.ClassFilter
          http://jenkins-ci.org/commit/google-oauth-plugin/498b54bb486d4a5dfd91ca47cfb04fbbf946502f
          Log:
          JENKINS-50216 - Whitelist org.joda.time.DateTime so that there is no need to tweak converter priorities

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/google/jenkins/plugins/util/JodaDateTimeConverter.java src/main/resources/META-INF/hudson.remoting.ClassFilter http://jenkins-ci.org/commit/google-oauth-plugin/498b54bb486d4a5dfd91ca47cfb04fbbf946502f Log: JENKINS-50216 - Whitelist org.joda.time.DateTime so that there is no need to tweak converter priorities
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: astroilov
          Path:
          .gitignore
          Jenkinsfile
          checkstyleJavaHeader
          pom.xml
          src/main/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentials.java
          src/main/resources/com/google/jenkins/plugins/credentials/oauth/GoogleRobotMetadataCredentials/config.jelly
          src/main/resources/com/google/jenkins/plugins/credentials/oauth/GoogleRobotPrivateKeyCredentials/config.jelly
          src/main/resources/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig/config.jelly
          src/main/resources/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig/config.jelly
          http://jenkins-ci.org/commit/google-oauth-plugin/e68bbcc00395124e4b27e90b84e1edeaff33fc74
          Log:
          Merge pull request #17 from jglick/RemotableGoogleCredentials.expiration-JENKINS-50216

          JENKINS-50216 - RemotableGoogleCredentials.expiration fix

          Compare: https://github.com/jenkinsci/google-oauth-plugin/compare/62126a657c2d...e68bbcc00395
          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: astroilov Path: .gitignore Jenkinsfile checkstyleJavaHeader pom.xml src/main/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentials.java src/main/resources/com/google/jenkins/plugins/credentials/oauth/GoogleRobotMetadataCredentials/config.jelly src/main/resources/com/google/jenkins/plugins/credentials/oauth/GoogleRobotPrivateKeyCredentials/config.jelly src/main/resources/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig/config.jelly src/main/resources/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig/config.jelly http://jenkins-ci.org/commit/google-oauth-plugin/e68bbcc00395124e4b27e90b84e1edeaff33fc74 Log: Merge pull request #17 from jglick/RemotableGoogleCredentials.expiration- JENKINS-50216 JENKINS-50216 - RemotableGoogleCredentials.expiration fix Compare: https://github.com/jenkinsci/google-oauth-plugin/compare/62126a657c2d...e68bbcc00395 * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          The fix has been released in 0.6

          Show
          oleg_nenashev Oleg Nenashev added a comment - The fix has been released in 0.6

            People

            Assignee:
            jglick Jesse Glick
            Reporter:
            dmn_dbernardy Dennis Bernardy
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: