Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50293

Repository Connector Plugin does not use Jenkins configured proxy correctly

    XMLWordPrintable

Details

    Description

      Seems it's broken since JENKINS-24243 where proxy settings where moved from RemoteRepository to MavenRepositorySystemSession.

      The proxy set into MavenRepositorySystemSession never gets propageted to RemoteRepository now since the plugin does not use RemoteRepositoryManager nor sets the proxy manually anymore.

      This results in all the calls to repositorySystem.resolveVersionRange, repositorySystem.deploy, repositorySystem.resolveDependencies etc. performed without proxy  

      /**
 * Sets the proxy selector to use for repositories discovered in artifact descriptors. Note that this selector is
 * not used for remote repositories which are passed as request parameters to the repository system, those
 * repositories are supposed to have their proxy (if any) already set.
 * 
 * @param proxySelector The proxy selector to use, may be {@code null}.
 * @return This session for chaining, never {@code null}.
 * @see org.sonatype.aether.repository.RemoteRepository#getProxy()
 */
public DefaultRepositorySystemSession setProxySelector( ProxySelector proxySelector )

      ^^ Note that this selector is not used for remote repositories which are passed as request parameters to the repository system, those repositories are supposed to have their proxy (if any) already set.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          butchyyyy Milan Konir added a comment -

          https://github.com/jenkinsci/repository-connector-plugin/pull/33

          butchyyyy Milan Konir added a comment - https://github.com/jenkinsci/repository-connector-plugin/pull/33
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Milan Koníř
          Path:
          src/main/java/org/jvnet/hudson/plugins/repositoryconnector/aether/Aether.java
          src/test/java/org/jvnet/hudson/plugins/repositoryconnector/aether/AetherTest.java
          http://jenkins-ci.org/commit/repository-connector-plugin/8851b74464cb5cc6041576c70f0c28b45a2650dd
          Log:
          JENKINS-50293 Repository Connector Plugin does not use Jenkins configured proxy correctly (#33)

          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Milan Koníř Path: src/main/java/org/jvnet/hudson/plugins/repositoryconnector/aether/Aether.java src/test/java/org/jvnet/hudson/plugins/repositoryconnector/aether/AetherTest.java http://jenkins-ci.org/commit/repository-connector-plugin/8851b74464cb5cc6041576c70f0c28b45a2650dd Log: JENKINS-50293 Repository Connector Plugin does not use Jenkins configured proxy correctly (#33) * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
          jgangemi Jae Gangemi added a comment -

          releases as 1.2.4, should be available shortly

          jgangemi Jae Gangemi added a comment - releases as 1.2.4 , should be available shortly

          People

            jgangemi Jae Gangemi
            butchyyyy Milan Konir
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: