Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50323

PullRequestSCMHead and PullRequestSCMRevision external use

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • github-branch-source-plugin
    • None
    • Github Branch Source 2.3.3

      While working on an extension filter plugin for GitHub PR labels which adds an SCMHeadEvent implementation I noticed that the constructors for PullRequestSCMHead and PullRequestSCMRevision were package private. Using more generic classes, the scm source rejects the heads returned by the event and so the subscriber cannot operate. A locally modified version of GHBS with public constructors allowed the new plugin to work correctly.

      Discussion at https://groups.google.com/forum/#!topic/jenkinsci-dev/bLoYi3munDw

       

       

          [JENKINS-50323] PullRequestSCMHead and PullRequestSCMRevision external use

          Steven Foster created issue -
          Steven Foster made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Liam Newman made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]
          Jesse Glick made changes -
          Link New: This issue relates to JENKINS-58939 [ JENKINS-58939 ]

            Unassigned Unassigned
            stevenfoster Steven Foster
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: