Details
-
Bug
-
Status: Resolved (View Workflow)
-
Minor
-
Resolution: Fixed
-
None
Description
Problem statement
Consider plugins A and B.
A has an optional dependency to B.
B exposes an extension point called B.
A contains an @Extension(optional=true) or an @OptionalExtension(requiresPlugins = "B") (when using the variant plugin)
and has public class A extends B.
- Set up a new Jenkins instance
- Install plugin A
- Install plugin B
- Check groovy console ExtensionList.lookup(B.class)
- An empty list is returned. Expected to see class A singleton.
After restarting the Jenkins instance, class A singleton is listed properly.
Prior/related work
JENKINS-19976fixed classloading in this kind of situation- JENKINS-19508 is proposing to eliminate this use case altogether
- JENKINS-49026 is a consequence of this problem
Attachments
Issue Links
- relates to
-
-
- Open
-
-
JENKINS-19508 Replace @Extension(optional=true) and optional dependencies with bridge plugins
-
- Open
-
-
JENKINS-19976 Cannot load a class in depended plugin after install before restart
-
- Resolved
-
-
-
- Open
-
- links to
(1 links to)
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
h1. Problem statement Consider plugin A and B. A has an optional dependency to B. B exposes an extension point called B A contains an {{@Extension(optional=true)}} or an {{@OptionalExtension(requiresPlugins = "B")}} (when using the [variant plugin|https://github.com/jenkinsci/variant-plugin]) and has {{public class A extends B}}. * Set up a new Jenkins instance * Install plugin A * Install plugin B * Check groovy console ExtensionList.lookup(B.class) * An empty list is returned. Expected to see class A singleton. After restarting the Jenkins instance, class A singleton is listed properly. h1. Prior/related work * * JENKINS-19508 is proposing to eliminate this use case altogether * JENKINS-49026 is a consequence of this problem |
h1. Problem statement Consider plugin A and B. A has an optional dependency to B. B exposes an extension point called B. A contains an {{@Extension(optional=true)}} or an {{@OptionalExtension(requiresPlugins = "B")}} (when using the [variant plugin|https://github.com/jenkinsci/variant-plugin]) and has {{public class A extends B}}. * Set up a new Jenkins instance * Install plugin A * Install plugin B * Check groovy console ExtensionList.lookup(B.class) * An empty list is returned. Expected to see class A singleton. After restarting the Jenkins instance, class A singleton is listed properly. h1. Prior/related work * * JENKINS-19508 is proposing to eliminate this use case altogether * JENKINS-49026 is a consequence of this problem |
| Description |
h1. Problem statement Consider plugin A and B. A has an optional dependency to B. B exposes an extension point called B. A contains an {{@Extension(optional=true)}} or an {{@OptionalExtension(requiresPlugins = "B")}} (when using the [variant plugin|https://github.com/jenkinsci/variant-plugin]) and has {{public class A extends B}}. * Set up a new Jenkins instance * Install plugin A * Install plugin B * Check groovy console ExtensionList.lookup(B.class) * An empty list is returned. Expected to see class A singleton. After restarting the Jenkins instance, class A singleton is listed properly. h1. Prior/related work * * JENKINS-19508 is proposing to eliminate this use case altogether * JENKINS-49026 is a consequence of this problem |
h1. Problem statement Consider plugins *A* and *B*. *A* has an optional dependency to *B*. *B* exposes an extension point called B. *A* contains an {{@Extension(optional=true)}} or an {{@OptionalExtension(requiresPlugins = "B")}} (when using the [variant plugin|https://github.com/jenkinsci/variant-plugin]) and has {{public class A extends B}}. * Set up a new Jenkins instance * Install plugin *A* * Install plugin *B* * Check groovy console {{ExtensionList.lookup(B.class)}} * An empty list is returned. Expected to see class *A* singleton. After restarting the Jenkins instance, class *A* singleton is listed properly. h1. Prior/related work * * JENKINS-19508 is proposing to eliminate this use case altogether * JENKINS-49026 is a consequence of this problem |
| Link | This issue relates to JENKINS-19508 [ JENKINS-19508 ] |
| Link |
This issue relates to |
| Link | This issue relates to JENKINS-49026 [ JENKINS-49026 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Assignee | Vincent Latombe [ vlatombe ] |
| Status | In Progress [ 3 ] | In Review [ 10005 ] |
| Remote Link | This issue links to "Core PR #3370 (Web Link)" [ 20320 ] |
| Remote Link | This issue links to "CloudBees Internal TIGER-4517 (Web Link)" [ 20556 ] |
Fixed in 2.127.
danielbeck vlatombe It is categorized as RFE, and I do not consider it as backportable. Are you fine with that?
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10005 ] | Resolved [ 5 ] |
| Link | This issue relates to JENKINS-14392 [ JENKINS-14392 ] |
Code changed in jenkins
User: Vincent Latombe
Path:
core/src/main/java/hudson/ExtensionFinder.java
core/src/main/java/hudson/PluginManager.java
test/src/test/java/hudson/PluginManagerTest.java
test/src/test/resources/plugins/jenkins-50336.hpi
test/src/test/resources/plugins/variant.hpi
http://jenkins-ci.org/commit/jenkins/8c1b8b8e144280f9645eaf761ed7f5e894ac7353
Log:
JENKINS-50336Fix loading optional extensions after installing a missing dependency (#3370)JENKINS-50336Only keep extensions that could be loaded in memorySo that delta computations will re-attempt to load any extension that
previously failed or was skipped after a new plugin is installed.
After installing a plugin, need to refresh extensions in order to pick
up extensions that can be loaded thanks to this new plugin.
JENKINS-50336@OptionalExtension annotated classes were not being picked up after dynamic load of variantRecompute GuiceExtensionAnnotation list when refreshing extensions
*NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.