-
Improvement
-
Resolution: Fixed
-
Minor
-
None
Fingerprint log files can grow large, mostly composed of a single, repeated line that provides little to no value, like this:
possibly trimming /var/jenkins_home/fingerprints/[...]
I propose we eliminate this line, to keep the log from growing so large and filling up with useless lines.
This issue is also noted as an aside in a comment on JENKINS-19066.
- links to
[JENKINS-50412] Fingerprints logs should be less verbose
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Remote Link | New: This issue links to "CloudBees Internal OSS-2651 (Web Link)" [ 20555 ] |
Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
Resolution | New: Fixed [ 1 ] | |
Status | Original: In Review [ 10005 ] | New: Resolved [ 5 ] |
Code changed in jenkins
User: Jeff Thompson
Path:
core/src/main/java/hudson/model/FingerprintCleanupThread.java
core/src/test/java/hudson/model/FingerprintCleanupThreadTest.java
http://jenkins-ci.org/commit/jenkins/a9eafdb973d0e9697e2f7a8a3f4e3441464398f4
Log:
JENKINS-50412Fingerprints logs should be less verbose (#3373)JENKINS-50412- Fingerprints logs should be less verboseEliminate the logging line that says
possibly trimming /var/jenkins_home/fingerprints/[...]
This line fills up the fingerprints log file with repetitive, useless information.
The operation it calls provides its own logging that can be turned on if detailed
logging is actually needed instead of running this one repeatedly.
Also, while in the area, convert a couple of FileFilter inner classes to lambdas
and inline them. This reduces unnecessary boilerplate and improves clarity.
In order to make this change testable, I elected to remove the final restriction on the
class and annotate the class as restricted. This allows me to create unit tests for
this change and also verify existing capability at the appropriate level.
Use a reliable check.
*NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.