-
Improvement
-
Resolution: Fixed
-
Minor
-
None
-
Powered by SuggestiMate
The warning text about needing to restart and the button should appear at the bottom of the page, and only after all the pending operations are completed either successfully or unsuccessfully.
I think that's a much better flow for users, although it does mean a bit more work for us to decide when to display it.
(JENKINS-3146 is the original request that resulted in this button.)
[JENKINS-5047] "Restart when no jobs are running" at the top is confusing
I think it would be even better if the restart button would be always visible but does a restart after the installation has been finished. I.e. the restart request needs to be put in some kind of 'queue' until the upgrade has been finished.
I did clicked on the button several times before the update completed hoping it would behave like ulli said.
Code changed in jenkins
User: Ulli Hafner
Path:
core/src/main/java/hudson/model/UpdateCenter.java
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties
core/src/main/resources/hudson/model/UpdateCenter/index.jelly
core/src/main/resources/hudson/model/UpdateCenter/index_de.properties
http://jenkins-ci.org/commit/jenkins/40e9dd70f41ee2e5e9def99e4a8e0754abff4f43
Log:
[FIXED JENKINS-5047] Restart button now adds a restart action to the
queue instead of restarting immediately.
Integrated in jenkins_main_trunk #769
[FIXED JENKINS-5047] Restart button now adds a restart action to the
Ulli Hafner : 40e9dd70f41ee2e5e9def99e4a8e0754abff4f43
Files :
- core/src/main/resources/hudson/model/UpdateCenter/index_de.properties
- core/src/main/java/hudson/model/UpdateCenter.java
- core/src/main/resources/hudson/model/UpdateCenter/index.jelly
- core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties
- core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
Code changed in jenkins
User: Ulli Hafner
Path:
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties
http://jenkins-ci.org/commit/jenkins/59234f0a6470756ef3becdeff550eacd7ed309ce
Log:
JENKINS-5047 Added 'pending' text to action.
Code changed in jenkins
User: Ulli Hafner
Path:
changelog.html
http://jenkins-ci.org/commit/jenkins/119aea8612dee35211b54c03f3a0ec2e014c26d3
Log:
JENKINS-5047 Changlog update.
Compare: https://github.com/jenkinsci/jenkins/compare/b5642ef...119aea8
Integrated in jenkins_main_trunk #771
JENKINS-5047 Added 'pending' text to action.
JENKINS-5047 Changlog update.
Ulli Hafner : 59234f0a6470756ef3becdeff550eacd7ed309ce
Files :
- core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
- core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties
Ulli Hafner : 119aea8612dee35211b54c03f3a0ec2e014c26d3
Files :
- changelog.html
Code changed in jenkins
User: Ulli Hafner
Path:
core/src/main/java/hudson/model/UpdateCenter.java
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties
core/src/main/resources/hudson/model/UpdateCenter/index.jelly
core/src/main/resources/hudson/model/UpdateCenter/index_de.properties
http://jenkins-ci.org/commit/jenkins/40e9dd70f41ee2e5e9def99e4a8e0754abff4f43
Log:
[FIXED JENKINS-5047] Restart button now adds a restart action to the
queue instead of restarting immediately.
Code changed in jenkins
User: Ulli Hafner
Path:
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties
http://jenkins-ci.org/commit/jenkins/59234f0a6470756ef3becdeff550eacd7ed309ce
Log:
JENKINS-5047 Added 'pending' text to action.
Code changed in jenkins
User: Ulli Hafner
Path:
changelog.html
http://jenkins-ci.org/commit/jenkins/119aea8612dee35211b54c03f3a0ec2e014c26d3
Log:
JENKINS-5047 Changlog update.
Code changed in jenkins
User: Ulli Hafner
Path:
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
core/src/main/resources/hudson/model/UpdateCenter/index.jelly
http://jenkins-ci.org/commit/jenkins/393e39727df034a7646be7f6ac05a05f613a09b2
Log:
JENKINS-5047 Fixed JavaScript update during Ajax refresh.
Code changed in jenkins
User: Ulli Hafner
Path:
core/src/main/java/hudson/model/UpdateCenter.java
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties
core/src/main/resources/hudson/model/UpdateCenter/index.jelly
core/src/main/resources/hudson/model/UpdateCenter/index_de.properties
http://jenkins-ci.org/commit/jenkins/40e9dd70f41ee2e5e9def99e4a8e0754abff4f43
Log:
[FIXED JENKINS-5047] Restart button now adds a restart action to the
queue instead of restarting immediately.
Code changed in jenkins
User: Ulli Hafner
Path:
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties
http://jenkins-ci.org/commit/jenkins/59234f0a6470756ef3becdeff550eacd7ed309ce
Log:
JENKINS-5047 Added 'pending' text to action.
Code changed in jenkins
User: Ulli Hafner
Path:
changelog.html
http://jenkins-ci.org/commit/jenkins/119aea8612dee35211b54c03f3a0ec2e014c26d3
Log:
JENKINS-5047 Changlog update.
Code changed in jenkins
User: Ulli Hafner
Path:
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
core/src/main/resources/hudson/model/UpdateCenter/index.jelly
http://jenkins-ci.org/commit/jenkins/393e39727df034a7646be7f6ac05a05f613a09b2
Log:
JENKINS-5047 Fixed JavaScript update during Ajax refresh.
I was just noticing that a few minutes ago, coincidentally. But I don't think it's a "major" issue.