Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5047

"Restart when no jobs are running" at the top is confusing

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      The warning text about needing to restart and the button should appear at the bottom of the page, and only after all the pending operations are completed either successfully or unsuccessfully.

      I think that's a much better flow for users, although it does mean a bit more work for us to decide when to display it.

      (JENKINS-3146 is the original request that resulted in this button.)

          [JENKINS-5047] "Restart when no jobs are running" at the top is confusing

          Kohsuke Kawaguchi created issue -

          Jesse Glick added a comment -

          I was just noticing that a few minutes ago, coincidentally. But I don't think it's a "major" issue.

          Jesse Glick added a comment - I was just noticing that a few minutes ago, coincidentally. But I don't think it's a "major" issue.

          Downgraded to 'minor'

          Kohsuke Kawaguchi added a comment - Downgraded to 'minor'
          Kohsuke Kawaguchi made changes -
          Priority Original: Major [ 3 ] New: Minor [ 4 ]
          mdonohue made changes -
          Component/s New: core [ 15593 ]
          mdonohue made changes -
          Component/s New: gui [ 15492 ]
          Component/s Original: core [ 15593 ]

          Ulli Hafner added a comment -

          I think it would be even better if the restart button would be always visible but does a restart after the installation has been finished. I.e. the restart request needs to be put in some kind of 'queue' until the upgrade has been finished.

          Ulli Hafner added a comment - I think it would be even better if the restart button would be always visible but does a restart after the installation has been finished. I.e. the restart request needs to be put in some kind of 'queue' until the upgrade has been finished.

          dirmeier added a comment -

          I did clicked on the button several times before the update completed hoping it would behave like ulli said.

          dirmeier added a comment - I did clicked on the button several times before the update completed hoping it would behave like ulli said.
          Ulli Hafner made changes -
          Assignee New: Ulli Hafner [ drulli ]

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          core/src/main/java/hudson/model/UpdateCenter.java
          core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly
          core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties
          core/src/main/resources/hudson/model/UpdateCenter/index.jelly
          core/src/main/resources/hudson/model/UpdateCenter/index_de.properties
          http://jenkins-ci.org/commit/jenkins/40e9dd70f41ee2e5e9def99e4a8e0754abff4f43
          Log:
          [FIXED JENKINS-5047] Restart button now adds a restart action to the
          queue instead of restarting immediately.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: core/src/main/java/hudson/model/UpdateCenter.java core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row.jelly core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/row_de.properties core/src/main/resources/hudson/model/UpdateCenter/index.jelly core/src/main/resources/hudson/model/UpdateCenter/index_de.properties http://jenkins-ci.org/commit/jenkins/40e9dd70f41ee2e5e9def99e4a8e0754abff4f43 Log: [FIXED JENKINS-5047] Restart button now adds a restart action to the queue instead of restarting immediately.

            drulli Ulli Hafner
            kohsuke Kohsuke Kawaguchi
            Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: