Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50540

add the runPCT step to the git-plugin on a PR basis

    • Evergreen - Milestone 1

      We need to modify the git-plugin flow so it runs the PCT on PR basis for git-plugin and all the critical upstream dependencies

       Acceptance criteria

      • For every PR to the git-plugin there is a run of the PCT exercising all git-plugin upstream dependencies
      • The run has to be against a TBD version of Jenkins core
        • Latest one
        • The one included in essentials
        • Latest LTS
      • What are the versions of the git-plugin dependencies to use? TBD cc jglick rarabaolaza oleg_nenashev
        • For example the ones included in essentials, the latest ones? Or more generally, what environment are we going to use for this PCT run? The UC, a custom UC generated from essentials.yml a war file generated from the new custom war packager tool using essentials.yml as source...

          [JENKINS-50540] add the runPCT step to the git-plugin on a PR basis

          Isa Vilacides created issue -
          Isa Vilacides made changes -
          Epic Link New: JENKINS-50534 [ 189601 ]
          Isa Vilacides made changes -
          Link New: This issue depends on JENKINS-50539 [ JENKINS-50539 ]
          Raul Arabaolaza made changes -
          Description Original: We need to modify the git-plugin flow so it runs the PCT on PR basis for git-plugin and all the critical upstream dependencies

           *Acceptance criteria*
           * For every PR to the git-plugin there is a run of the PCT exercising all git-plugin upstream dependencies
           * The run has to be against a TBD version of Jenkins core
           ** Latest one
           ** The one included in essentials
           ** Latest LTS
           * What are the versions of the git-plugin dependencies to use? TBD cc [~jglick] [~rarabaolaza] [~oleg_nenashev]
          New: We need to modify the git-plugin flow so it runs the PCT on PR basis for git-plugin and all the critical upstream dependencies

           *Acceptance criteria*
           * For every PR to the git-plugin there is a run of the PCT exercising all git-plugin upstream dependencies
           * The run has to be against a TBD version of Jenkins core
           ** Latest one
           ** The one included in essentials
           ** Latest LTS
           * What are the versions of the git-plugin dependencies to use? TBD cc [~jglick] [~rarabaolaza] [~oleg_nenashev]
           ** For example the ones included in essentials, the latest ones?
          Raul Arabaolaza made changes -
          Description Original: We need to modify the git-plugin flow so it runs the PCT on PR basis for git-plugin and all the critical upstream dependencies

           *Acceptance criteria*
           * For every PR to the git-plugin there is a run of the PCT exercising all git-plugin upstream dependencies
           * The run has to be against a TBD version of Jenkins core
           ** Latest one
           ** The one included in essentials
           ** Latest LTS
           * What are the versions of the git-plugin dependencies to use? TBD cc [~jglick] [~rarabaolaza] [~oleg_nenashev]
           ** For example the ones included in essentials, the latest ones?
          New: We need to modify the git-plugin flow so it runs the PCT on PR basis for git-plugin and all the critical upstream dependencies

           *Acceptance criteria*
           * For every PR to the git-plugin there is a run of the PCT exercising all git-plugin upstream dependencies
           * The run has to be against a TBD version of Jenkins core
           ** Latest one
           ** The one included in essentials
           ** Latest LTS
           * What are the versions of the git-plugin dependencies to use? TBD cc [~jglick] [~rarabaolaza] [~oleg_nenashev]
           ** For example the ones included in essentials, the latest ones? Or more generally, what environment are we going to use for this PCT run? The UC, a custom UC generated from {{essentials.yml}} a war file generated from the new custom war packager tool using {{essentials.yml}} as source
          Raul Arabaolaza made changes -
          Description Original: We need to modify the git-plugin flow so it runs the PCT on PR basis for git-plugin and all the critical upstream dependencies

           *Acceptance criteria*
           * For every PR to the git-plugin there is a run of the PCT exercising all git-plugin upstream dependencies
           * The run has to be against a TBD version of Jenkins core
           ** Latest one
           ** The one included in essentials
           ** Latest LTS
           * What are the versions of the git-plugin dependencies to use? TBD cc [~jglick] [~rarabaolaza] [~oleg_nenashev]
           ** For example the ones included in essentials, the latest ones? Or more generally, what environment are we going to use for this PCT run? The UC, a custom UC generated from {{essentials.yml}} a war file generated from the new custom war packager tool using {{essentials.yml}} as source
          New: We need to modify the git-plugin flow so it runs the PCT on PR basis for git-plugin and all the critical upstream dependencies

           *Acceptance criteria*
           * For every PR to the git-plugin there is a run of the PCT exercising all git-plugin upstream dependencies
           * The run has to be against a TBD version of Jenkins core
           ** Latest one
           ** The one included in essentials
           ** Latest LTS
           * What are the versions of the git-plugin dependencies to use? TBD cc [~jglick] [~rarabaolaza] [~oleg_nenashev]
           ** For example the ones included in essentials, the latest ones? Or more generally, what environment are we going to use for this PCT run? The UC, a custom UC generated from {{essentials.yml}} a war file generated from the new custom war packager tool using {{essentials.yml}} as source...
          R. Tyler Croy made changes -
          Assignee Original: R. Tyler Croy [ rtyler ]

          Oleg Nenashev added a comment -

          > What are the versions of the git-plugin dependencies to use?

          I hit the same issue in my experiments. Version in my package (created by Custom WAR Packager) is older than the one required by a test dependency, so the PCT run fails.

          As we discussed with vilacides, it's better to take the newest version in this case even if the bundled version is older.

          Oleg Nenashev added a comment - > What are the versions of the git-plugin dependencies to use? I hit the same issue in my experiments. Version in my package (created by Custom WAR Packager) is older than the one required by a test dependency, so the PCT run fails. As we discussed with vilacides , it's better to take the newest version in this case even if the bundled version is older.

          Jesse Glick added a comment -

          Version in my package (created by Custom WAR Packager) is older than the one required by a test dependency

          I do not understand how this situation would even arise. Your WAR package should be specifying sufficiently new versions of everything. If you found it necessary to update a test dependency, certainly the WAR package version should be updated to at least that version, if not newer.

          Jesse Glick added a comment - Version in my package (created by Custom WAR Packager) is older than the one required by a test dependency I do not understand how this situation would even arise. Your WAR package should be specifying sufficiently new versions of everything. If you found it necessary to update a test dependency, certainly the WAR package version should be updated to at least that version, if not newer.

          Jesse Glick added a comment -

          In other words I would recommend treating such a situation as a user error and fail with an explicit message.

          Jesse Glick added a comment - In other words I would recommend treating such a situation as a user error and fail with an explicit message.

            rarabaolaza Raul Arabaolaza
            vilacides Isa Vilacides
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: