Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50552

Pipeline projects do not trigger libvirt VM snapshot reverts

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • libvirt-slave-plugin
    • Ubuntu 16.04.3 LTS 64 bit (running directly on the hardware)
      OpenJDK 1.8.0_151
      Jenkins 2.107.1
      Libvirt-plugin 1.8.5
      No proxy.
      Connection method: "Launch Slave Agents via SSH"
      Firefox 59.0.1 and Chrome 64.0.3282.167

      Configuring a snapshot revert within the project via the "Use Snapshots" checkbox or via the "Revert Snapshot" and "Before Snapshot" options on the node configuration does not appear to do anything on pipeline projects. They run exactly as though those settings were completely ignored.

          [JENKINS-50552] Pipeline projects do not trigger libvirt VM snapshot reverts

          Zeta Syanthis created issue -
          Zeta Syanthis made changes -
          Description Original: Configuring a snapshot revert within the project via the "Use Snapshots" checkbox or via the "Revert Snapshot" and "Before Snapshot" options on the node configuration does not appear to do anything on pipeline projects. They run exactly as though those settings were completely ignored.

          Jenkins version: 2.107.1

          Libvirt-plugin version: 1.8.5

          Connection method: "Launch Slave Agents via SSH"
          New: Configuring a snapshot revert within the project via the "Use Snapshots" checkbox or via the "Revert Snapshot" and "Before Snapshot" options on the node configuration does not appear to do anything on pipeline projects. They run exactly as though those settings were completely ignored.
          Environment New: Ubuntu 16.04.3 LTS 64 bit (running directly on the hardware)
          OpenJDK 1.8.0_151
          Jenkins 2.107.1
          Libvirt-plugin 1.8.5
          No proxy.
          Connection method: "Launch Slave Agents via SSH"
          Firefox 59.0.1 and Chrome 64.0.3282.167
          Zeta Syanthis made changes -
          Description Original: Configuring a snapshot revert within the project via the "Use Snapshots" checkbox or via the "Revert Snapshot" and "Before Snapshot" options on the node configuration does not appear to do anything on pipeline projects. They run exactly as though those settings were completely ignored. New: Configuring a snapshot revert within the project via the "Use Snapshots" checkbox or via the "Revert Snapshot" and "Before Snapshot" options on the node configuration does not appear to do anything on pipeline projects. They run exactly as though those settings were completely ignored.

           
          Zeta Syanthis made changes -
          Description Original: Configuring a snapshot revert within the project via the "Use Snapshots" checkbox or via the "Revert Snapshot" and "Before Snapshot" options on the node configuration does not appear to do anything on pipeline projects. They run exactly as though those settings were completely ignored.

           
          New: Configuring a snapshot revert within the project via the "Use Snapshots" checkbox or via the "Revert Snapshot" and "Before Snapshot" options on the node configuration does not appear to do anything on pipeline projects. They run exactly as though those settings were completely ignored.

          Michael Dirks added a comment -

          Can unfortunately confirm this happening. I wanted to switch off of AppVeyor and Travis and have builds in-house (faster and less costly) and ended up running into a situation where the build bots had old versions of the repository and configuration left around, resulting in faster later builds, but eventually resulting in failures due to configuration changes and the same directories being used.

          Jenkins Version: 2.141
          libvirt Slaves plugin Version: 1.8.5
          Remote VM Manager: KVM/QEMU

          Michael Dirks added a comment - Can unfortunately confirm this happening. I wanted to switch off of AppVeyor and Travis and have builds in-house (faster and less costly) and ended up running into a situation where the build bots had old versions of the repository and configuration left around, resulting in faster later builds, but eventually resulting in failures due to configuration changes and the same directories being used. Jenkins Version: 2.141 libvirt Slaves plugin Version: 1.8.5 Remote VM Manager: KVM/QEMU
          Michael Dirks made changes -
          Assignee Original: Philipp Bartsch [ tastybug ] New: Michael Dirks [ xaymar ]

          Michael Dirks added a comment -

          Work on a fix for this has begun. I have the plugin listening to the pipeline complete event now, though I don't think I can make the "Before Snapshot" option work with Pipeline projects.

          Michael Dirks added a comment - Work on a fix for this has begun. I have the plugin listening to the pipeline complete event now, though I don't think I can make the "Before Snapshot" option work with Pipeline projects.
          Michael Dirks made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Michael Dirks added a comment -

          Fix is working. Cleaning up, then submitting a PR.

          Michael Dirks added a comment - Fix is working. Cleaning up, then submitting a PR.

          David Taylor added a comment -

          xaymar any update on the plugin fix? my team is waiting for the "Before Snapshot" and "After Build" options to work within the node config. Any updates?

          David Taylor added a comment - xaymar any update on the plugin fix? my team is waiting for the "Before Snapshot" and "After Build" options to work within the node config. Any updates?

            bgermann Bastian Germann
            zetasyanthis Zeta Syanthis
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: