Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50561

Add @Symbol to "throttle builds" job properties

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Currently the snippet generator suggests/generates:

      properties([[$class: 'JobPropertyImpl', throttle: [count: 1, durationName: 'hour', userBoost: true]]])

        Attachments

          Issue Links

          links to

          Web Link PR #127

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            oleg_nenashev Oleg Nenashev added a comment -

            It is Branch API Plugin: https://github.com/jenkinsci/branch-api-plugin/blob/920700e3a71da949c6c3cd1e30824a825fcc2be2/src/main/java/jenkins/branch/RateLimitBranchProperty.java

            Show
            oleg_nenashev Oleg Nenashev added a comment - It is Branch API Plugin: https://github.com/jenkinsci/branch-api-plugin/blob/920700e3a71da949c6c3cd1e30824a825fcc2be2/src/main/java/jenkins/branch/RateLimitBranchProperty.java
            Hide
            Permalink
            abayer Andrew Bayer added a comment -

            PR up at https://github.com/jenkinsci/branch-api-plugin/pull/127 adding the symbol rateLimitBuilds - I wanted to avoid having "throttle" in the symbol since it means something different here than it does over in Throttle Concurrent Builds.

            Show
            abayer Andrew Bayer added a comment - PR up at https://github.com/jenkinsci/branch-api-plugin/pull/127 adding the symbol rateLimitBuilds - I wanted to avoid having "throttle" in the symbol since it means something different here than it does over in Throttle Concurrent Builds.
            Hide
            Permalink
            ifernandezcalvo Ivan Fernandez Calvo added a comment -

            I have hit this today, the Directive Generator generates the following code that it is wrong

              options {
    rateLimitBuilds([count: 60, durationName: 'hour', userBoost: false])
  }

            it should be this one, notice that it missed adding the `throttle` part

              options {
    rateLimitBuilds(throttle: [count: 60, durationName: 'hour', userBoost: false])
  }
            Show
            ifernandezcalvo Ivan Fernandez Calvo added a comment - I have hit this today, the Directive Generator generates the following code that it is wrong options { rateLimitBuilds([count: 60, durationName: 'hour' , userBoost: false ]) } it should be this one, notice that it missed adding the `throttle` part options { rateLimitBuilds(throttle: [count: 60, durationName: 'hour' , userBoost: false ]) }
            Hide
            Permalink
            bitwiseman Liam Newman added a comment -

            Ivan Fernandez Calvo
            Does the generated code not work?

            Show
            bitwiseman Liam Newman added a comment - Ivan Fernandez Calvo Does the generated code not work?
            Hide
            Permalink
            ifernandezcalvo Ivan Fernandez Calvo added a comment -

            not at all

            Show
            ifernandezcalvo Ivan Fernandez Calvo added a comment - not at all
            Hide
            Permalink
            reinholdfuereder Reinhold Füreder added a comment -

            (I can confirm that it is not working and just silently ignored )

            Show
            reinholdfuereder Reinhold Füreder added a comment - (I can confirm that it is not working and just silently ignored )

              People

              Assignee:
              bitwiseman Liam Newman
              Reporter:
              reinholdfuereder Reinhold Füreder
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated: