Details
-
Type:
Improvement
-
Status: Resolved (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: jenkins-test-harness
-
Labels:None
-
Similar Issues:
Description
JenkinsRule.addCrumb(WebRequest req) replaces all existing parameters rather than just adding a crumb.
This is mildly annoying, the crumb should be added to the list of parameters, not replace them.
Attachments
Issue Links
- links to
Code changed in jenkins
User: James Nord
Path:
src/main/java/org/jvnet/hudson/test/JenkinsRule.java
http://jenkins-ci.org/commit/jenkins-test-harness/4821d0fe49f37d699a5ca294f0719f3287839eef
Log:
JENKINS-50590do not remove all request parameters when adding a crumbIf you had a WebRequest with existing Parameters specified then adding a
crumb would remove all of those headers. THis is somewhat suprising.
I thought about making getCrumbHeaderNVP() public but went with the
option that should anyway cause the least suprise. The crumb is now
added to the list of parameters rather than replacing them. It is added
first such that if there where existing crumb fields the newly added one
should be first.